From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C21BCD37B0 for ; Mon, 18 Sep 2023 21:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbjIRVML (ORCPT ); Mon, 18 Sep 2023 17:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjIRVML (ORCPT ); Mon, 18 Sep 2023 17:12:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B248E; Mon, 18 Sep 2023 14:12:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8AAEC433C8; Mon, 18 Sep 2023 21:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695071525; bh=m/n53GAvddAGYEj8KIWHPEfGhiEY0hHq/daTN/xqmFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lT6zdRyXLl3hGuDf4Nmys6NDjz2efBIL530DSrN/5R5/MRcQKduO3iwEIe/7x/+w2 Z8CCwA50YfY9NmcTYlhnpktZTivUUex6T+i5eEfh0sP7g4927U7pMO84D07R5uQK5M vBIlzWxcu1TwjS/d4EVqTPKVPrLn4+69kUMEIoDy7RwpksLVaFf/wg9sZXzQ8NEJ79 p1VOE/dv37lACSur8VEm86e4EzSZJsXMvfFNl5tCpidcZat1b2us9VdssDOB+m1zRj NLYItvKkINSQ6o1g6ynePQDp+4HuEpK3ybeCVliZ7KCbTkdDnCDOXVbkuvfwSJT7cG XDOt1yurB5n0A== Received: (nullmailer pid 1768524 invoked by uid 1000); Mon, 18 Sep 2023 21:12:02 -0000 Date: Mon, 18 Sep 2023 16:12:02 -0500 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Sergio Paracuellos , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Message-ID: <20230918211202.GA1743810-robh@kernel.org> References: <20230917162837.277405-1-arinc.unal@arinc9.com> <20230917162837.277405-2-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230917162837.277405-2-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, Sep 17, 2023 at 07:28:37PM +0300, Arınç ÜNAL wrote: > Document the pins of each group on the MediaTek MTMIPS SoC pin controllers. > > Signed-off-by: Arınç ÜNAL > --- > .../pinctrl/mediatek,mt7620-pinctrl.yaml | 22 ++++++++++++- > .../pinctrl/mediatek,mt7621-pinctrl.yaml | 18 +++++++++- > .../pinctrl/mediatek,mt76x8-pinctrl.yaml | 33 ++++++++++++++++++- > .../pinctrl/ralink,rt2880-pinctrl.yaml | 17 +++++++++- > .../pinctrl/ralink,rt305x-pinctrl.yaml | 16 ++++++++- > .../pinctrl/ralink,rt3352-pinctrl.yaml | 17 +++++++++- > .../pinctrl/ralink,rt3883-pinctrl.yaml | 16 ++++++++- > .../pinctrl/ralink,rt5350-pinctrl.yaml | 13 +++++++- > 8 files changed, 144 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml > index 221adcef6e14..eb9d9d2bd90f 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml > @@ -44,8 +44,28 @@ patternProperties: > wdt refclk, wdt rst, wled] > > groups: > - description: > + description: | > An array of strings. Each string contains the name of a group. > + > + group pins > + ------------------------------------------------------------------ > + "i2c" 1, 2 > + "spi" 3, 4, 5, 6 > + "uartf" 7, 8, 9, 10, 11, 12, 13, 14 > + "uartlite" 15, 16 > + "wdt" 17 > + "pa" 18, 19, 20, 21 > + "mdio" 22, 23 > + "rgmii1" 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35 > + "pcie" 36 > + "spi refclk" 37, 38, 39 > + "ephy" 40, 41, 42, 43, 44 > + "nd_sd" 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, > + 57, 58, 59 > + > + "rgmii2" 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71 > + "wled" 72 This list of strings should be an enum like 'function' above. > + > maxItems: 1 This is wrong if more than 1 string is allowed... Same goes for the rest of the changes. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67F1FC46CA1 for ; Mon, 18 Sep 2023 21:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o8ry/QnOUnUpklSPzILG4i9Gd+Mwp9vJYHMhrANqmqE=; b=fn1Zasy7d1ciI+ DM9D6jsAe95QbGGOhkPwYcb+90R16AY+J/rVZPXCDBUJLpteEdrZJkIGaiqQq5vDpZ+8BDoTXBCvo HPQGtWSbjEp5sw8FOQf1GGA4e2a4H5HR0V9WuR17xHseG7+LKscjMygc40sgqkqmIH2FLNS/ueMwi lWTS9TOQzpqmi0dRBmzjjmf4ssgM4Sb8Sp446ETwYarQRr7r+fnIjiUTV9Wvwv+M9ixFMw/YOk+yK br8JbFHWCpCOzhQlMFH4O0avy0wBmSzVdvA1cjpkpa5ZBzP6z09w/3NYLt05mE3flDrsY67+S0TPU Ts2qXR/kQn9aeInxOfug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiLXO-00GMlA-0N; Mon, 18 Sep 2023 21:12:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiLXK-00GMkJ-2z; Mon, 18 Sep 2023 21:12:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32D6C61368; Mon, 18 Sep 2023 21:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8AAEC433C8; Mon, 18 Sep 2023 21:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695071525; bh=m/n53GAvddAGYEj8KIWHPEfGhiEY0hHq/daTN/xqmFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lT6zdRyXLl3hGuDf4Nmys6NDjz2efBIL530DSrN/5R5/MRcQKduO3iwEIe/7x/+w2 Z8CCwA50YfY9NmcTYlhnpktZTivUUex6T+i5eEfh0sP7g4927U7pMO84D07R5uQK5M vBIlzWxcu1TwjS/d4EVqTPKVPrLn4+69kUMEIoDy7RwpksLVaFf/wg9sZXzQ8NEJ79 p1VOE/dv37lACSur8VEm86e4EzSZJsXMvfFNl5tCpidcZat1b2us9VdssDOB+m1zRj NLYItvKkINSQ6o1g6ynePQDp+4HuEpK3ybeCVliZ7KCbTkdDnCDOXVbkuvfwSJT7cG XDOt1yurB5n0A== Received: (nullmailer pid 1768524 invoked by uid 1000); Mon, 18 Sep 2023 21:12:02 -0000 Date: Mon, 18 Sep 2023 16:12:02 -0500 From: Rob Herring To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Sergio Paracuellos , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups Message-ID: <20230918211202.GA1743810-robh@kernel.org> References: <20230917162837.277405-1-arinc.unal@arinc9.com> <20230917162837.277405-2-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230917162837.277405-2-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230918_141207_054127_78892DFF X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBTZXAgMTcsIDIwMjMgYXQgMDc6Mjg6MzdQTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiBEb2N1bWVudCB0aGUgcGlucyBvZiBlYWNoIGdyb3VwIG9uIHRoZSBNZWRpYVRlayBN VE1JUFMgU29DIHBpbiBjb250cm9sbGVycy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBcsSxbsOnIMOc TkFMIDxhcmluYy51bmFsQGFyaW5jOS5jb20+Cj4gLS0tCj4gIC4uLi9waW5jdHJsL21lZGlhdGVr LG10NzYyMC1waW5jdHJsLnlhbWwgICAgICB8IDIyICsrKysrKysrKysrKy0KPiAgLi4uL3BpbmN0 cmwvbWVkaWF0ZWssbXQ3NjIxLXBpbmN0cmwueWFtbCAgICAgIHwgMTggKysrKysrKysrLQo+ICAu Li4vcGluY3RybC9tZWRpYXRlayxtdDc2eDgtcGluY3RybC55YW1sICAgICAgfCAzMyArKysrKysr KysrKysrKysrKystCj4gIC4uLi9waW5jdHJsL3JhbGluayxydDI4ODAtcGluY3RybC55YW1sICAg ICAgICB8IDE3ICsrKysrKysrKy0KPiAgLi4uL3BpbmN0cmwvcmFsaW5rLHJ0MzA1eC1waW5jdHJs LnlhbWwgICAgICAgIHwgMTYgKysrKysrKystCj4gIC4uLi9waW5jdHJsL3JhbGluayxydDMzNTIt cGluY3RybC55YW1sICAgICAgICB8IDE3ICsrKysrKysrKy0KPiAgLi4uL3BpbmN0cmwvcmFsaW5r LHJ0Mzg4My1waW5jdHJsLnlhbWwgICAgICAgIHwgMTYgKysrKysrKystCj4gIC4uLi9waW5jdHJs L3JhbGluayxydDUzNTAtcGluY3RybC55YW1sICAgICAgICB8IDEzICsrKysrKystCj4gIDggZmls ZXMgY2hhbmdlZCwgMTQ0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waW5jdHJsL21lZGlhdGVr LG10NzYyMC1waW5jdHJsLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv cGluY3RybC9tZWRpYXRlayxtdDc2MjAtcGluY3RybC55YW1sCj4gaW5kZXggMjIxYWRjZWY2ZTE0 Li5lYjlkOWQyYmQ5MGYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BpbmN0cmwvbWVkaWF0ZWssbXQ3NjIwLXBpbmN0cmwueWFtbAo+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waW5jdHJsL21lZGlhdGVrLG10NzYyMC1waW5j dHJsLnlhbWwKPiBAQCAtNDQsOCArNDQsMjggQEAgcGF0dGVyblByb3BlcnRpZXM6Cj4gICAgICAg ICAgICAgICAgICAgICB3ZHQgcmVmY2xrLCB3ZHQgcnN0LCB3bGVkXQo+ICAKPiAgICAgICAgICAg IGdyb3VwczoKPiAtICAgICAgICAgICAgZGVzY3JpcHRpb246Cj4gKyAgICAgICAgICAgIGRlc2Ny aXB0aW9uOiB8Cj4gICAgICAgICAgICAgICAgQW4gYXJyYXkgb2Ygc3RyaW5ncy4gRWFjaCBzdHJp bmcgY29udGFpbnMgdGhlIG5hbWUgb2YgYSBncm91cC4KPiArCj4gKyAgICAgICAgICAgICAgZ3Jv dXAgICAgICAgICAgICAgcGlucwo+ICsgICAgICAgICAgICAgIC0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsgICAgICAg ICAgICAgICJpMmMiICAgICAgICAgICAgIDEsIDIKPiArICAgICAgICAgICAgICAic3BpIiAgICAg ICAgICAgICAzLCA0LCA1LCA2Cj4gKyAgICAgICAgICAgICAgInVhcnRmIiAgICAgICAgICAgNywg OCwgOSwgMTAsIDExLCAxMiwgMTMsIDE0Cj4gKyAgICAgICAgICAgICAgInVhcnRsaXRlIiAgICAg ICAgMTUsIDE2Cj4gKyAgICAgICAgICAgICAgIndkdCIgICAgICAgICAgICAgMTcKPiArICAgICAg ICAgICAgICAicGEiICAgICAgICAgICAgICAxOCwgMTksIDIwLCAyMQo+ICsgICAgICAgICAgICAg ICJtZGlvIiAgICAgICAgICAgIDIyLCAyMwo+ICsgICAgICAgICAgICAgICJyZ21paTEiICAgICAg ICAgIDI0LCAyNSwgMjYsIDI3LCAyOCwgMjksIDMwLCAzMSwgMzIsIDMzLCAzNCwgMzUKPiArICAg ICAgICAgICAgICAicGNpZSIgICAgICAgICAgICAzNgo+ICsgICAgICAgICAgICAgICJzcGkgcmVm Y2xrIiAgICAgIDM3LCAzOCwgMzkKPiArICAgICAgICAgICAgICAiZXBoeSIgICAgICAgICAgICA0 MCwgNDEsIDQyLCA0MywgNDQKPiArICAgICAgICAgICAgICAibmRfc2QiICAgICAgICAgICA0NSwg NDYsIDQ3LCA0OCwgNDksIDUwLCA1MSwgNTIsIDUzLCA1NCwgNTUsIDU2LAo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDU3LCA1OCwgNTkKPiArCj4gKyAgICAgICAgICAgICAgInJn bWlpMiIgICAgICAgICAgNjAsIDYxLCA2MiwgNjMsIDY0LCA2NSwgNjYsIDY3LCA2OCwgNjksIDcw LCA3MQo+ICsgICAgICAgICAgICAgICJ3bGVkIiAgICAgICAgICAgIDcyCgpUaGlzIGxpc3Qgb2Yg c3RyaW5ncyBzaG91bGQgYmUgYW4gZW51bSBsaWtlICdmdW5jdGlvbicgYWJvdmUuCgo+ICsKPiAg ICAgICAgICAgICAgbWF4SXRlbXM6IDEKClRoaXMgaXMgd3JvbmcgaWYgbW9yZSB0aGFuIDEgc3Ry aW5nIGlzIGFsbG93ZWQuLi4KClNhbWUgZ29lcyBmb3IgdGhlIHJlc3Qgb2YgdGhlIGNoYW5nZXMu CgpSb2IKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK