From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF96CE79AC for ; Wed, 20 Sep 2023 05:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbjITFuW (ORCPT ); Wed, 20 Sep 2023 01:50:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232380AbjITFuU (ORCPT ); Wed, 20 Sep 2023 01:50:20 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7C6A394; Tue, 19 Sep 2023 22:50:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DFB3580A0; Wed, 20 Sep 2023 05:50:14 +0000 (UTC) Date: Wed, 20 Sep 2023 08:50:13 +0300 From: Tony Lindgren To: "H. Nikolaus Schaller" Cc: Tomi Valkeinen , David Airlie , Daniel Vetter , Douglas Anderson , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , sre@kernel.org, Laurent Pinchart , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached Message-ID: <20230920055013.GP5285@atomide.com> References: <929c46beecf77f2ebfa9f8c9b1c09f6ec610c31a.1695130648.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <929c46beecf77f2ebfa9f8c9b1c09f6ec610c31a.1695130648.git.hns@goldelico.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * H. Nikolaus Schaller [230919 13:38]: > dsi_init_output() called by dsi_probe() may fail. In that > case mipi_dsi_host_unregister() is called which may call > omap_dsi_host_detach() with uninitialized dsi->dsidev > because omap_dsi_host_attach() was never called before. > > This happens if the panel driver asks for an EPROBE_DEFER. > > So let's suppress the WARN() in this special case. Reviewed-by: Tony Lindgren Thanks, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD4A6CE79AD for ; Wed, 20 Sep 2023 05:50:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 345E810E079; Wed, 20 Sep 2023 05:50:19 +0000 (UTC) Received: from muru.com (muru.com [72.249.23.125]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CF8410E079 for ; Wed, 20 Sep 2023 05:50:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DFB3580A0; Wed, 20 Sep 2023 05:50:14 +0000 (UTC) Date: Wed, 20 Sep 2023 08:50:13 +0300 From: Tony Lindgren To: "H. Nikolaus Schaller" Subject: Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached Message-ID: <20230920055013.GP5285@atomide.com> References: <929c46beecf77f2ebfa9f8c9b1c09f6ec610c31a.1695130648.git.hns@goldelico.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <929c46beecf77f2ebfa9f8c9b1c09f6ec610c31a.1695130648.git.hns@goldelico.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: letux-kernel@openphoenux.org, Arnd Bergmann , Tomi Valkeinen , kernel@pyra-handheld.com, sre@kernel.org, dri-devel@lists.freedesktop.org, Douglas Anderson , Laurent Pinchart , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * H. Nikolaus Schaller [230919 13:38]: > dsi_init_output() called by dsi_probe() may fail. In that > case mipi_dsi_host_unregister() is called which may call > omap_dsi_host_detach() with uninitialized dsi->dsidev > because omap_dsi_host_attach() was never called before. > > This happens if the panel driver asks for an EPROBE_DEFER. > > So let's suppress the WARN() in this special case. Reviewed-by: Tony Lindgren Thanks, Tony