From: Lee Jones <lee@kernel.org>
To: sunying@nj.iscas.ac.cn
Cc: linux-kernel@vger.kernel.org, renyanjie01@gmail.com,
pengpeng@iscas.ac.cn
Subject: Re: [PATCH] mfd: ab8500: remove non-existent configuration "#ifdef CONFIG_AB8500_DEBUG"
Date: Wed, 20 Sep 2023 13:13:38 +0100 [thread overview]
Message-ID: <20230920121338.GE13143@google.com> (raw)
In-Reply-To: <20230913084559.18141-1-sunying@nj.iscas.ac.cn>
On Wed, 13 Sep 2023, sunying@nj.iscas.ac.cn wrote:
> From: Ying Sun <sunying@nj.iscas.ac.cn>
>
> The CONFIG_AB8500_DEBUG has been deleted in
> [PATCH]mfd: ab8500: Drop debugfs module.
In future please use the following format when referencing commits:
3d4d1266597c0 ("mfd: ab8500: Drop debugfs module")
I have fixed this for you this time.
> The condition "#ifdef CONFIG_AB8500_DEBUG" in
> include/linux/mfd/abx500/ab8500.h:502
> cannot be valid. It is recommended to delete redundant code.
>
> Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
> Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
> ---
> include/linux/mfd/abx500/ab8500.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/mfd/abx500/ab8500.h b/include/linux/mfd/abx500/ab8500.h
> index 09fb3c56e7d7..76d326ea8eba 100644
> --- a/include/linux/mfd/abx500/ab8500.h
> +++ b/include/linux/mfd/abx500/ab8500.h
> @@ -499,13 +499,7 @@ static inline int is_ab9540_2p0_or_earlier(struct ab8500 *ab)
>
> void ab8500_override_turn_on_stat(u8 mask, u8 set);
>
> -#ifdef CONFIG_AB8500_DEBUG
> -extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size);
> -void ab8500_dump_all_banks(struct device *dev);
> -void ab8500_debug_register_interrupt(int line);
> -#else
> static inline void ab8500_dump_all_banks(struct device *dev) {}
> static inline void ab8500_debug_register_interrupt(int line) {}
> -#endif
>
> #endif /* MFD_AB8500_H */
> --
> 2.17.1
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-09-20 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 8:45 [PATCH] mfd: ab8500: remove non-existent configuration "#ifdef CONFIG_AB8500_DEBUG" sunying
2023-09-20 12:12 ` (subset) " Lee Jones
2023-09-20 12:13 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920121338.GE13143@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=renyanjie01@gmail.com \
--cc=sunying@nj.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.