From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org,
sam@gentoo.org
Subject: Re: [ANNOUNCE] ipset 7.18 released
Date: Wed, 20 Sep 2023 14:50:56 +0200 [thread overview]
Message-ID: <20230920125056.GA25778@breakpoint.cc> (raw)
In-Reply-To: <0r045rnn-70s8-34pq-o5o3-nr3q48n9sq68@vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
You might want to CC author of that change.
> On Wednesday 2023-09-20 13:20, Jan Engelhardt wrote:
> >On Tuesday 2023-09-19 20:26, Jozsef Kadlecsik wrote:
> >>
> >>I'm happy to announce ipset 7.18, which brings a few fixes, backports,
> >>tests suite fixes and json output support.
> >
> >The installation of the pkgconfig file is now broken.
> >
> >> - lib/Makefile.am: fix pkgconfig dir (Sam James)
> >
> >Aaaaagh.. that change completely broke installation and must be reverted.
>
> commit 326932be0c4f47756f9809cad5a103ac310f700d
> Author: Sam James <sam@gentoo.org>
> Date: Sat Jan 28 19:23:54 2023 +0100
>
> lib/Makefile.am: fix pkgconfig dir
>
> Signed-off-by: Sam James <sam@gentoo.org>
> Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
>
> Can I just take a moment to vent about this some more.
> The change is, in the words of another Linux developer, utter garbage.
> ${libdir} contains ${prefix} and did so for eternities.
>
> The commit message is utter garbage too, because it does not
> even try to make an argument to even _have_ the change in the
> first place. Allowing such an underdocumented change is a
> failure in the review process itself.
next prev parent reply other threads:[~2023-09-20 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 18:26 [ANNOUNCE] ipset 7.18 released Jozsef Kadlecsik
2023-09-20 11:20 ` Jan Engelhardt
2023-09-20 11:30 ` Jan Engelhardt
2023-09-20 12:50 ` Florian Westphal [this message]
2023-09-20 13:03 ` Sam James
2023-09-20 13:03 ` Sam James
2023-09-21 6:56 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920125056.GA25778@breakpoint.cc \
--to=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.