Re: [PATCH] bmips: Add Inteno XG6846 board

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2196 bytes --]

On Wed, Sep 20, 2023 at 09:42:25AM +0200, Linus Walleij wrote:

> This adds support for the Inteno XG6846 board based on the
> Broadcom MIPS 6328 SoC.
> 
> The default boot will read a uImage from flash and boot it.
> 
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
[snip]
> diff --git a/arch/mips/dts/inteno,xg6846.dts b/arch/mips/dts/inteno,xg6846.dts
> new file mode 100644
> index 000000000000..180cfdcac9d4
> --- /dev/null
> +++ b/arch/mips/dts/inteno,xg6846.dts
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2023 Linus Walleij <linusw@kernel.org>
> + *
> + * This is a diet version of the device tree from Linux,
> + * suitable for U-Boot.
> + */

We shouldn't need a diet version of the tree.  If it's reasonably done
and stable in the kernel, we can even move towards just passing the
U-Boot tree along to Linux.

> diff --git a/board/inteno/xg6846/Kconfig b/board/inteno/xg6846/Kconfig
> new file mode 100644
> index 000000000000..4dd78b3b1960
> --- /dev/null
> +++ b/board/inteno/xg6846/Kconfig
> @@ -0,0 +1,12 @@
> +if BOARD_INTENO_XG6846
> +
> +config SYS_BOARD
> +	default "xg6846"
> +
> +config SYS_VENDOR
> +	default "inteno"
> +
> +config SYS_CONFIG_NAME
> +	default "inteno_xg6846"
> +
> +endif
[snip]
> diff --git a/board/inteno/xg6846/Makefile b/board/inteno/xg6846/Makefile
> new file mode 100644
> index 000000000000..311e1db7a775
> --- /dev/null
> +++ b/board/inteno/xg6846/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +
> +obj-y += xg6846.o
> diff --git a/board/inteno/xg6846/xg6846.c b/board/inteno/xg6846/xg6846.c
> new file mode 100644
> index 000000000000..b3b6751a6256
> --- /dev/null
> +++ b/board/inteno/xg6846/xg6846.c
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2023 Linus Walleij <linusw@kernel.org>
> + */
> +
> +#include <common.h>

So basically just an empty object file.  Can we just _not_ have
something here, if we perhaps don't set SYS_BOARD?  I assume if there's
just nothing here the link rules fail.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]