From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EED8AC0031C for ; Wed, 20 Sep 2023 17:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234563AbjITRAo (ORCPT ); Wed, 20 Sep 2023 13:00:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234174AbjITRAo (ORCPT ); Wed, 20 Sep 2023 13:00:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2757599 for ; Wed, 20 Sep 2023 10:00:38 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC063C433C8; Wed, 20 Sep 2023 17:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1695229237; bh=6CLGRuI55KYQEJdw8sxo7+Egh525MWdjpXny+NxXLGY=; h=Date:To:From:Subject:From; b=CndQzvxv7S7C7Pyd/Mk6YFPVEUBu+2BCH7xJqKJFvrJNsiB6R6VR1rl8jlc5pINrV 2eJfVL7jWKQqSQZzMeXUscX9VMQ+uvbBUMMjxPCO42lfy9Jkc1czHj74x0X5R9a//0 /Mohxu6hO+2DFGzyNU/VtzG/d/RIlb6vZst5BFCk= Date: Wed, 20 Sep 2023 10:00:36 -0700 To: mm-commits@vger.kernel.org, lkp@intel.com, bhe@redhat.com, akpm@linux-foundation.org From: Andrew Morton Subject: + x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix.patch added to mm-nonmm-unstable branch Message-Id: <20230920170037.AC063C433C8@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: x86: kdump: move crash_low_size_default() code into has been added to the -mm mm-nonmm-unstable branch. Its filename is x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Baoquan He Subject: x86: kdump: move crash_low_size_default() code into Content-type: text/plain LKP reported below error with 'W=1' and randconfig. ========= >> arch/x86/kernel/setup.c:476:15: warning: no previous prototype for function 'crash_low_size_default' [-Wmissing-prototypes] unsigned long crash_low_size_default(void) ^ arch/x86/kernel/setup.c:476:1: note: declare 'static' if the function is not intended to be used outside of this translation unit unsigned long crash_low_size_default(void) ^ static 1 warning generated. ========= In that config, CONFIG_KEXEC is not set. So all KEXEC/CRASH related configs depending on CONFIG_KEXEC are all unset. Then the declaration in won't be seen. Finally the warning is caused. So move the code of crash_low_size_default() into x86's , and make it static inline to fix the warning. Link: https://lkml.kernel.org/r/ZQpeAjOmuMJBFw1/@MiWiFi-R3L-srv Signed-off-by: Baoquan He Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309141534.moH4dTcz-lkp@intel.com/ Signed-off-by: Andrew Morton --- arch/x86/include/asm/crash_core.h | 10 +++++++++- arch/x86/kernel/setup.c | 12 ------------ 2 files changed, 9 insertions(+), 13 deletions(-) --- a/arch/x86/include/asm/crash_core.h~x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix +++ a/arch/x86/include/asm/crash_core.h @@ -18,6 +18,7 @@ * no good way to detect the paging mode of the target kernel which will be * loaded for dumping. */ +extern unsigned long swiotlb_size_or_default(void); #ifdef CONFIG_X86_32 # define CRASH_ADDR_LOW_MAX SZ_512M @@ -29,6 +30,13 @@ # define DEFAULT_CRASH_KERNEL_LOW_SIZE crash_low_size_default() -extern unsigned long crash_low_size_default(void); +static inline unsigned long crash_low_size_default(void) +{ +#ifdef CONFIG_X86_64 + return max(swiotlb_size_or_default() + (8UL << 20), 256UL << 20); +#else + return 0; +#endif +} #endif /* _X86_CRASH_CORE_H */ --- a/arch/x86/kernel/setup.c~x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix +++ a/arch/x86/kernel/setup.c @@ -470,18 +470,6 @@ static void __init memblock_x86_reserve_ } } -/* - * --------- Crashkernel reservation ------------------------------ - */ -unsigned long crash_low_size_default(void) -{ -#ifdef CONFIG_X86_64 - return max(swiotlb_size_or_default() + (8UL << 20), 256UL << 20); -#else - return 0; -#endif -} - static void __init arch_reserve_crashkernel(void) { unsigned long long crash_base, crash_size, low_size = 0; _ Patches currently in -mm which might be from bhe@redhat.com are crash_corec-remove-unnecessary-parameter-of-function.patch crash_core-change-the-prototype-of-function-parse_crashkernel.patch crash_core-change-parse_crashkernel-to-support-crashkernel=highlow-parsing.patch crash_core-add-generic-function-to-do-reservation.patch crash_core-move-crashk_res-definition-into-crash_corec.patch x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code.patch x86-kdump-use-generic-interface-to-simplify-crashkernel-reservation-code-fix.patch arm64-kdump-use-generic-interface-to-simplify-crashkernel-reservation.patch riscv-kdump-use-generic-interface-to-simplify-crashkernel-reservation.patch crash_corec-remove-unneeded-functions.patch