From: Tony Lindgren <tony@atomide.com>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
bcousson@baylibre.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, jarkko.nikula@bitmer.com,
dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src
Date: Thu, 21 Sep 2023 15:16:26 +0300 [thread overview]
Message-ID: <20230921121626.GT5285@atomide.com> (raw)
In-Reply-To: <dac768d2-2c66-4d6b-b3d3-d1ef69103c76@gmail.com>
* Péter Ujfalusi <peter.ujfalusi@gmail.com> [230920 17:40]:
> It is not the parent's fck, it is the PRCM clock which is selected as
> the sourcee of the clock generator (CLKS) for BCLK/FSYNC. That is the
> functional clock as well for the McBSP instance.
Oh OK
> Out of reset it is using the PRCM source which is fine in all current users.
> I would do this fix or workaround in a different way: instead of
> ignoring the error, avoid it in the first place. Do nothing if the
> already selected clock is requested.
> That would remove the error and will fail in case the reparenting is not
> working -> boards will know this and might be able to do something about
> it in a reasonable way.
>
> How that sounds?
Sounds good to me :)
Tony
next prev parent reply other threads:[~2023-09-21 12:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 19:03 [PATCH 0/3] ARM: omap4: embt2ws: Add audio support Andreas Kemnade
2023-07-05 19:03 ` [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Andreas Kemnade
2023-09-19 18:25 ` Péter Ujfalusi
2023-09-20 6:33 ` Tony Lindgren
2023-09-20 14:52 ` Andreas Kemnade
2023-09-20 17:24 ` Péter Ujfalusi
2023-09-20 17:40 ` Péter Ujfalusi
2023-09-21 12:16 ` Tony Lindgren [this message]
2023-10-06 10:23 ` Tony Lindgren
2023-10-06 19:30 ` Andreas Kemnade
2023-10-07 6:25 ` Tony Lindgren
2023-10-07 7:11 ` Andreas Kemnade
2023-10-07 7:41 ` Tony Lindgren
2023-10-07 8:34 ` Andreas Kemnade
2023-10-12 14:41 ` Péter Ujfalusi
2023-10-13 11:25 ` Andreas Kemnade
2023-10-25 14:21 ` Péter Ujfalusi
2023-10-15 21:48 ` Andreas Kemnade
2023-10-18 5:23 ` Tony Lindgren
2023-10-18 6:21 ` Andreas Kemnade
2023-07-05 19:03 ` [PATCH 2/3] ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode Andreas Kemnade
2023-07-05 19:21 ` Mark Brown
2023-07-05 19:56 ` Andreas Kemnade
2023-07-06 12:02 ` Mark Brown
2023-07-08 13:03 ` Andreas Kemnade
2023-07-10 16:36 ` Mark Brown
2023-07-05 19:03 ` [PATCH 3/3] ARM: dts: omap4: embt2ws: Add audio support Andreas Kemnade
2023-07-05 19:23 ` Mark Brown
2023-07-19 17:47 ` (subset) [PATCH 0/3] ARM: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921121626.GT5285@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jarkko.nikula@bitmer.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.