From: kernel test robot <lkp@intel.com>
To: Kairui Song <ryncsn@gmail.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v3 1/6] workingset: simplify and use a more intuitive model
Date: Thu, 21 Sep 2023 19:58:05 +0800 [thread overview]
Message-ID: <202309211955.PP1nkFx4-lkp@intel.com> (raw)
In-Reply-To: <20230920190244.16839-2-ryncsn@gmail.com>
Hi Kairui,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc2 next-20230921]
[cannot apply to akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/workingset-simplify-and-use-a-more-intuitive-model/20230921-030515
base: linus/master
patch link: https://lore.kernel.org/r/20230920190244.16839-2-ryncsn%40gmail.com
patch subject: [RFC PATCH v3 1/6] workingset: simplify and use a more intuitive model
config: mips-pic32mzda_defconfig (https://download.01.org/0day-ci/archive/20230921/202309211955.PP1nkFx4-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309211955.PP1nkFx4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309211955.PP1nkFx4-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> mm/workingset.c:345:6: warning: no previous prototype for function 'workingset_age_nonresident' [-Wmissing-prototypes]
345 | void workingset_age_nonresident(struct lruvec *lruvec, unsigned long nr_pages)
| ^
mm/workingset.c:345:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
345 | void workingset_age_nonresident(struct lruvec *lruvec, unsigned long nr_pages)
| ^
| static
1 warning generated.
vim +/workingset_age_nonresident +345 mm/workingset.c
ac35a490237446 Yu Zhao 2022-09-18 334
31d8fcac00fcf4 Johannes Weiner 2020-06-25 335 /**
31d8fcac00fcf4 Johannes Weiner 2020-06-25 336 * workingset_age_nonresident - age non-resident entries as LRU ages
e755f4af08b74e Xiaofei Tan 2020-10-15 337 * @lruvec: the lruvec that was aged
31d8fcac00fcf4 Johannes Weiner 2020-06-25 338 * @nr_pages: the number of pages to count
31d8fcac00fcf4 Johannes Weiner 2020-06-25 339 *
31d8fcac00fcf4 Johannes Weiner 2020-06-25 340 * As in-memory pages are aged, non-resident pages need to be aged as
31d8fcac00fcf4 Johannes Weiner 2020-06-25 341 * well, in order for the refault distances later on to be comparable
31d8fcac00fcf4 Johannes Weiner 2020-06-25 342 * to the in-memory dimensions. This function allows reclaim and LRU
31d8fcac00fcf4 Johannes Weiner 2020-06-25 343 * operations to drive the non-resident aging along in parallel.
31d8fcac00fcf4 Johannes Weiner 2020-06-25 344 */
31d8fcac00fcf4 Johannes Weiner 2020-06-25 @345 void workingset_age_nonresident(struct lruvec *lruvec, unsigned long nr_pages)
b910718a948a91 Johannes Weiner 2019-11-30 346 {
b910718a948a91 Johannes Weiner 2019-11-30 347 /*
b910718a948a91 Johannes Weiner 2019-11-30 348 * Reclaiming a cgroup means reclaiming all its children in a
b910718a948a91 Johannes Weiner 2019-11-30 349 * round-robin fashion. That means that each cgroup has an LRU
b910718a948a91 Johannes Weiner 2019-11-30 350 * order that is composed of the LRU orders of its child
b910718a948a91 Johannes Weiner 2019-11-30 351 * cgroups; and every page has an LRU position not just in the
b910718a948a91 Johannes Weiner 2019-11-30 352 * cgroup that owns it, but in all of that group's ancestors.
b910718a948a91 Johannes Weiner 2019-11-30 353 *
b910718a948a91 Johannes Weiner 2019-11-30 354 * So when the physical inactive list of a leaf cgroup ages,
b910718a948a91 Johannes Weiner 2019-11-30 355 * the virtual inactive lists of all its parents, including
b910718a948a91 Johannes Weiner 2019-11-30 356 * the root cgroup's, age as well.
b910718a948a91 Johannes Weiner 2019-11-30 357 */
b910718a948a91 Johannes Weiner 2019-11-30 358 do {
31d8fcac00fcf4 Johannes Weiner 2020-06-25 359 atomic_long_add(nr_pages, &lruvec->nonresident_age);
31d8fcac00fcf4 Johannes Weiner 2020-06-25 360 } while ((lruvec = parent_lruvec(lruvec)));
b910718a948a91 Johannes Weiner 2019-11-30 361 }
b910718a948a91 Johannes Weiner 2019-11-30 362
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-21 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 19:02 [RFC PATCH v3 0/6] Refault distance update with MGLRU support Kairui Song
2023-09-20 19:02 ` [RFC PATCH v3 1/6] workingset: simplify and use a more intuitive model Kairui Song
2023-09-21 11:58 ` kernel test robot [this message]
2023-09-21 14:52 ` kernel test robot
2023-09-21 21:42 ` kernel test robot
2023-09-20 19:02 ` [RFC PATCH v3 2/6] workingset: move refault distance checking into to a helper Kairui Song
2023-09-20 19:02 ` [RFC PATCH v3 3/6] workignset: simplify the initilization code Kairui Song
2023-09-20 19:02 ` [RFC PATCH v3 4/6] workingset: simplify lru_gen_test_recent Kairui Song
2023-09-21 1:29 ` kernel test robot
2023-09-20 19:02 ` [RFC PATCH v3 5/6] mm, lru_gen: convert avg_total and avg_refaulted to atomic Kairui Song
2023-09-20 19:02 ` [RFC PATCH v3 6/6] workingset, lru_gen: apply refault-distance based re-activation Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309211955.PP1nkFx4-lkp@intel.com \
--to=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ryncsn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.