From: Greg KH <gregkh@linuxfoundation.org>
To: huangli05 <huangli05@inspur.com>
Cc: osmtendev@gmail.com, speakup@linux-speakup.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: modify syntax errors in comments
Date: Thu, 21 Sep 2023 09:34:05 +0200 [thread overview]
Message-ID: <2023092135-waving-duct-00d0@gregkh> (raw)
In-Reply-To: <20230921021349.3350-1-huangli05@inspur.com>
On Thu, Sep 21, 2023 at 10:13:49AM +0800, huangli05 wrote:
> From: “huangli05“ <huangli05@inspur.com>
>
> Change "/* We want to set the the speech synthesis" to "/* We want to set the speech synthesis"
>
> Signed-off-by: “huangli05“ <huangli05@inspur.com>
> ---
> drivers/accessibility/speakup/speakup_soft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 6d446824677b..6549bfb96e7f 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -446,7 +446,7 @@ static int softsynth_adjust(struct spk_synth *synth, struct st_var_header *var)
> if (var->var_id != PUNC_LEVEL)
> return 0;
>
> - /* We want to set the the speech synthesis punctuation level
> + /* We want to set the speech synthesis punctuation level
> * accordingly, so it properly tunes speaking A_PUNC characters */
> var_data = var->data;
> if (!var_data)
> --
> 2.31.1
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
- It looks like you did not use your "real" name for the patch on either
the Signed-off-by: line, or the From: line (both of which have to
match). Please read the kernel file,
Documentation/process/submitting-patches.rst for how to do this
correctly.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2023-09-21 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 2:13 [PATCH] staging: speakup: modify syntax errors in comments huangli05
2023-09-21 7:34 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-19 7:42 huangli05
2023-09-19 8:19 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023092135-waving-duct-00d0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=huangli05@inspur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osmtendev@gmail.com \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.