From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 480D4E7D0D6 for ; Fri, 22 Sep 2023 06:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbjIVG7a (ORCPT ); Fri, 22 Sep 2023 02:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjIVG73 (ORCPT ); Fri, 22 Sep 2023 02:59:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FBBFCE for ; Thu, 21 Sep 2023 23:59:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4127DC433C7; Fri, 22 Sep 2023 06:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695365963; bh=2n8SD+onKMJABH4WMhTAB1SsrMLN1yDHzsgPQ+4sc3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aG1J4bn5YJ+sfPda1ZNWXajcMhMxx67Mm6WKAqlmz3wWSMmOFMg1vGtXT4vhmiRpm l72kkCU5rankG31iHp3O8RR6wdFkI7sJdbIrrOIqdsXpQ6OGfCz4XgTI2EiHpjB7vq LCaZy6Pk6Hxb2MNUJw2BAZcjzMfCQQVg6LmfWes7pVT3+vuXiEpS/zITA1oX2qrp20 52hSPf26Oa4GxkBoGQUbjb5tcsw+H1q0MU8r3EYozlhL21GxGJiQXJxcc0vzMhl4Py dlsL+l+HDB5b8SwIub7+v5XdYISUX82v6HnDi+r80S7zN9kNe/kfGwrqTSM+OPRcbb RzGR0rdXMhtEA== Date: Fri, 22 Sep 2023 07:59:19 +0100 From: Lee Jones To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: turris-omnia: Fix unused variable Message-ID: <20230922065919.GA3660432@google.com> References: <20230921205025.20303-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230921205025.20303-1-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, 21 Sep 2023, Marek Behún wrote: > The variable ret is not used in this function. > > Fixes: 28350bc0ac77 ("leds: turris-omnia: Do not use SMBUS calls") > Closes: https://lore.kernel.org/linux-leds/202309212215.Yl5VQaSm-lkp@intel.com/T/#u > Signed-off-by: Marek Behún > --- > drivers/leds/leds-turris-omnia.c | 1 - > 1 file changed, 1 deletion(-) I already fixed and squashed this. How was this missed when you tested the set? -- Lee Jones [李琼斯]