From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 797FF34CEC for ; Fri, 22 Sep 2023 13:47:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695390451; x=1726926451; h=date:from:to:cc:subject:message-id:mime-version; bh=F4tnO2ys+7MG1fsAdnnBNqaZxYzd27l0klkzJe0enYw=; b=TdwsUijAKy8UEAV5Hz1dXEeos4DmAW0bQQnN/RCg1cT2Np33GMAigBqe Z6CEBcK4u3wjBAx8mImlPANFjnM4AOmyN8iBBZVyr/crIBJrhh8knIMD5 EVmuIMPfoNdVxO0EUVxh1Ag/PmyCfAsweYdec5lm9ZbJJIsQtfc3MkDHT uFwO994EZVoxcaIyiXfmB55RSgHToQPBqDmx1mc43DHPQlK8zTjqQeDZd N9CZl+Fa8gHljIn62ydAdHU9cBIYBH0vNCyLVdNcWilPLfQpICqDFha9q s73VFx5jgUNs8A3rJKr0EIaJNd2okIZ/kn2p0U3uSj8kenr+POB5xAVAC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="447307594" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="447307594" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2023 06:47:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10841"; a="890814526" X-IronPort-AV: E=Sophos;i="6.03,167,1694761200"; d="scan'208";a="890814526" Received: from lkp-server02.sh.intel.com (HELO 493f6c7fed5d) ([10.239.97.151]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2023 06:46:31 -0700 Received: from kbuild by 493f6c7fed5d with local (Exim 4.96) (envelope-from ) id 1qjgV9-0000n2-04; Fri, 22 Sep 2023 13:47:23 +0000 Date: Fri, 22 Sep 2023 21:47:12 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/char/hw_random/jh7110-trng.c:303 starfive_trng_probe() warn: passing zero to 'dev_err_probe' Message-ID: <202309222117.3FNLbVwj-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Herbert Xu CC: Conor Dooley CC: Jia Jie Ho Hi Herbert, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 27bbf45eae9ca98877a2d52a92a188147cd61b07 commit: c7410b425de40e9b163eef781e1bdacf1bf2962e hwrng: starfive - Enable compile testing date: 8 months ago :::::: branch date: 19 hours ago :::::: commit date: 8 months ago config: csky-randconfig-r071-20230917 (https://download.01.org/0day-ci/archive/20230922/202309222117.3FNLbVwj-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 13.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230922/202309222117.3FNLbVwj-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202309222117.3FNLbVwj-lkp@intel.com/ smatch warnings: drivers/char/hw_random/jh7110-trng.c:303 starfive_trng_probe() warn: passing zero to 'dev_err_probe' vim +/dev_err_probe +303 drivers/char/hw_random/jh7110-trng.c c388f458bc34eb Jia Jie Ho 2023-01-17 273 c388f458bc34eb Jia Jie Ho 2023-01-17 274 static int starfive_trng_probe(struct platform_device *pdev) c388f458bc34eb Jia Jie Ho 2023-01-17 275 { c388f458bc34eb Jia Jie Ho 2023-01-17 276 int ret; c388f458bc34eb Jia Jie Ho 2023-01-17 277 int irq; c388f458bc34eb Jia Jie Ho 2023-01-17 278 struct starfive_trng *trng; c388f458bc34eb Jia Jie Ho 2023-01-17 279 c388f458bc34eb Jia Jie Ho 2023-01-17 280 trng = devm_kzalloc(&pdev->dev, sizeof(*trng), GFP_KERNEL); c388f458bc34eb Jia Jie Ho 2023-01-17 281 if (!trng) c388f458bc34eb Jia Jie Ho 2023-01-17 282 return -ENOMEM; c388f458bc34eb Jia Jie Ho 2023-01-17 283 c388f458bc34eb Jia Jie Ho 2023-01-17 284 platform_set_drvdata(pdev, trng); c388f458bc34eb Jia Jie Ho 2023-01-17 285 trng->dev = &pdev->dev; c388f458bc34eb Jia Jie Ho 2023-01-17 286 c388f458bc34eb Jia Jie Ho 2023-01-17 287 trng->base = devm_platform_ioremap_resource(pdev, 0); c388f458bc34eb Jia Jie Ho 2023-01-17 288 if (IS_ERR(trng->base)) c388f458bc34eb Jia Jie Ho 2023-01-17 289 return dev_err_probe(&pdev->dev, PTR_ERR(trng->base), c388f458bc34eb Jia Jie Ho 2023-01-17 290 "Error remapping memory for platform device.\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 291 c388f458bc34eb Jia Jie Ho 2023-01-17 292 irq = platform_get_irq(pdev, 0); c388f458bc34eb Jia Jie Ho 2023-01-17 293 if (irq < 0) c388f458bc34eb Jia Jie Ho 2023-01-17 294 return irq; c388f458bc34eb Jia Jie Ho 2023-01-17 295 c388f458bc34eb Jia Jie Ho 2023-01-17 296 init_completion(&trng->random_done); c388f458bc34eb Jia Jie Ho 2023-01-17 297 init_completion(&trng->reseed_done); c388f458bc34eb Jia Jie Ho 2023-01-17 298 spin_lock_init(&trng->write_lock); c388f458bc34eb Jia Jie Ho 2023-01-17 299 c388f458bc34eb Jia Jie Ho 2023-01-17 300 ret = devm_request_irq(&pdev->dev, irq, starfive_trng_irq, 0, pdev->name, c388f458bc34eb Jia Jie Ho 2023-01-17 301 (void *)trng); c388f458bc34eb Jia Jie Ho 2023-01-17 302 if (ret) c388f458bc34eb Jia Jie Ho 2023-01-17 @303 return dev_err_probe(&pdev->dev, irq, c388f458bc34eb Jia Jie Ho 2023-01-17 304 "Failed to register interrupt handler\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 305 c388f458bc34eb Jia Jie Ho 2023-01-17 306 trng->hclk = devm_clk_get(&pdev->dev, "hclk"); c388f458bc34eb Jia Jie Ho 2023-01-17 307 if (IS_ERR(trng->hclk)) c388f458bc34eb Jia Jie Ho 2023-01-17 308 return dev_err_probe(&pdev->dev, PTR_ERR(trng->hclk), c388f458bc34eb Jia Jie Ho 2023-01-17 309 "Error getting hardware reference clock\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 310 c388f458bc34eb Jia Jie Ho 2023-01-17 311 trng->ahb = devm_clk_get(&pdev->dev, "ahb"); c388f458bc34eb Jia Jie Ho 2023-01-17 312 if (IS_ERR(trng->ahb)) c388f458bc34eb Jia Jie Ho 2023-01-17 313 return dev_err_probe(&pdev->dev, PTR_ERR(trng->ahb), c388f458bc34eb Jia Jie Ho 2023-01-17 314 "Error getting ahb reference clock\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 315 c388f458bc34eb Jia Jie Ho 2023-01-17 316 trng->rst = devm_reset_control_get_shared(&pdev->dev, NULL); c388f458bc34eb Jia Jie Ho 2023-01-17 317 if (IS_ERR(trng->rst)) c388f458bc34eb Jia Jie Ho 2023-01-17 318 return dev_err_probe(&pdev->dev, PTR_ERR(trng->rst), c388f458bc34eb Jia Jie Ho 2023-01-17 319 "Error getting hardware reset line\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 320 c388f458bc34eb Jia Jie Ho 2023-01-17 321 clk_prepare_enable(trng->hclk); c388f458bc34eb Jia Jie Ho 2023-01-17 322 clk_prepare_enable(trng->ahb); c388f458bc34eb Jia Jie Ho 2023-01-17 323 reset_control_deassert(trng->rst); c388f458bc34eb Jia Jie Ho 2023-01-17 324 c388f458bc34eb Jia Jie Ho 2023-01-17 325 trng->rng.name = dev_driver_string(&pdev->dev); c388f458bc34eb Jia Jie Ho 2023-01-17 326 trng->rng.init = starfive_trng_init; c388f458bc34eb Jia Jie Ho 2023-01-17 327 trng->rng.cleanup = starfive_trng_cleanup; c388f458bc34eb Jia Jie Ho 2023-01-17 328 trng->rng.read = starfive_trng_read; c388f458bc34eb Jia Jie Ho 2023-01-17 329 c388f458bc34eb Jia Jie Ho 2023-01-17 330 trng->mode = PRNG_256BIT; c388f458bc34eb Jia Jie Ho 2023-01-17 331 trng->mission = 1; c388f458bc34eb Jia Jie Ho 2023-01-17 332 trng->reseed = RANDOM_RESEED; c388f458bc34eb Jia Jie Ho 2023-01-17 333 c388f458bc34eb Jia Jie Ho 2023-01-17 334 pm_runtime_use_autosuspend(&pdev->dev); c388f458bc34eb Jia Jie Ho 2023-01-17 335 pm_runtime_set_autosuspend_delay(&pdev->dev, 100); c388f458bc34eb Jia Jie Ho 2023-01-17 336 pm_runtime_enable(&pdev->dev); c388f458bc34eb Jia Jie Ho 2023-01-17 337 c388f458bc34eb Jia Jie Ho 2023-01-17 338 ret = devm_hwrng_register(&pdev->dev, &trng->rng); c388f458bc34eb Jia Jie Ho 2023-01-17 339 if (ret) { c388f458bc34eb Jia Jie Ho 2023-01-17 340 pm_runtime_disable(&pdev->dev); c388f458bc34eb Jia Jie Ho 2023-01-17 341 c388f458bc34eb Jia Jie Ho 2023-01-17 342 reset_control_assert(trng->rst); c388f458bc34eb Jia Jie Ho 2023-01-17 343 clk_disable_unprepare(trng->ahb); c388f458bc34eb Jia Jie Ho 2023-01-17 344 clk_disable_unprepare(trng->hclk); c388f458bc34eb Jia Jie Ho 2023-01-17 345 c388f458bc34eb Jia Jie Ho 2023-01-17 346 return dev_err_probe(&pdev->dev, ret, "Failed to register hwrng\n"); c388f458bc34eb Jia Jie Ho 2023-01-17 347 } c388f458bc34eb Jia Jie Ho 2023-01-17 348 c388f458bc34eb Jia Jie Ho 2023-01-17 349 return 0; c388f458bc34eb Jia Jie Ho 2023-01-17 350 } c388f458bc34eb Jia Jie Ho 2023-01-17 351 :::::: The code at line 303 was first introduced by commit :::::: c388f458bc34eb3a5728b67f6614f9375cd99087 hwrng: starfive - Add TRNG driver for StarFive SoC :::::: TO: Jia Jie Ho :::::: CC: Herbert Xu -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki