From: kernel test robot <lkp@intel.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v3 6/7] iommu: Retire bus ops
Date: Sun, 24 Sep 2023 09:18:12 +0800 [thread overview]
Message-ID: <202309240920.GEdNuhRO-lkp@intel.com> (raw)
In-Reply-To: <c43f24d2fce3f4e02bc9056a30021ee45e19e35b.1694693889.git.robin.murphy@arm.com>
Hi Robin,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v6.6-rc2 next-20230921]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Robin-Murphy/iommu-Factor-out-some-helpers/20230916-010009
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/c43f24d2fce3f4e02bc9056a30021ee45e19e35b.1694693889.git.robin.murphy%40arm.com
patch subject: [PATCH v3 6/7] iommu: Retire bus ops
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230924/202309240920.GEdNuhRO-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230924/202309240920.GEdNuhRO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309240920.GEdNuhRO-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/iommu/iommu.c: In function 'iommu_device_register_bus':
>> drivers/iommu/iommu.c:318:12: error: 'struct bus_type' has no member named 'iommu_ops'
318 | bus->iommu_ops = ops;
| ^~
vim +318 drivers/iommu/iommu.c
23a1b46f15d575 Jason Gunthorpe 2023-08-02 296
23a1b46f15d575 Jason Gunthorpe 2023-08-02 297 /*
23a1b46f15d575 Jason Gunthorpe 2023-08-02 298 * Register an iommu driver against a single bus. This is only used by iommufd
23a1b46f15d575 Jason Gunthorpe 2023-08-02 299 * selftest to create a mock iommu driver. The caller must provide
23a1b46f15d575 Jason Gunthorpe 2023-08-02 300 * some memory to hold a notifier_block.
23a1b46f15d575 Jason Gunthorpe 2023-08-02 301 */
23a1b46f15d575 Jason Gunthorpe 2023-08-02 302 int iommu_device_register_bus(struct iommu_device *iommu,
23a1b46f15d575 Jason Gunthorpe 2023-08-02 303 const struct iommu_ops *ops, struct bus_type *bus,
23a1b46f15d575 Jason Gunthorpe 2023-08-02 304 struct notifier_block *nb)
23a1b46f15d575 Jason Gunthorpe 2023-08-02 305 {
23a1b46f15d575 Jason Gunthorpe 2023-08-02 306 int err;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 307
23a1b46f15d575 Jason Gunthorpe 2023-08-02 308 iommu->ops = ops;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 309 nb->notifier_call = iommu_bus_notifier;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 310 err = bus_register_notifier(bus, nb);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 311 if (err)
23a1b46f15d575 Jason Gunthorpe 2023-08-02 312 return err;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 313
23a1b46f15d575 Jason Gunthorpe 2023-08-02 314 spin_lock(&iommu_device_lock);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 315 list_add_tail(&iommu->list, &iommu_device_list);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 316 spin_unlock(&iommu_device_lock);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 317
23a1b46f15d575 Jason Gunthorpe 2023-08-02 @318 bus->iommu_ops = ops;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 319 err = bus_iommu_probe(bus);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 320 if (err) {
23a1b46f15d575 Jason Gunthorpe 2023-08-02 321 iommu_device_unregister_bus(iommu, bus, nb);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 322 return err;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 323 }
23a1b46f15d575 Jason Gunthorpe 2023-08-02 324 return 0;
23a1b46f15d575 Jason Gunthorpe 2023-08-02 325 }
23a1b46f15d575 Jason Gunthorpe 2023-08-02 326 EXPORT_SYMBOL_GPL(iommu_device_register_bus);
23a1b46f15d575 Jason Gunthorpe 2023-08-02 327 #endif
23a1b46f15d575 Jason Gunthorpe 2023-08-02 328
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-24 1:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 16:58 [PATCH v3 0/7] Iommu: Retire bus ops Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-15 16:58 ` [PATCH v3 1/7] iommu: Factor out some helpers Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-18 16:36 ` Jason Gunthorpe
2023-09-18 16:36 ` Jason Gunthorpe
2023-09-15 16:58 ` [PATCH v3 2/7] iommu: Decouple iommu_present() from bus ops Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-18 17:12 ` Jason Gunthorpe
2023-09-18 17:12 ` Jason Gunthorpe
2023-09-18 19:21 ` Robin Murphy
2023-09-18 19:21 ` Robin Murphy
2023-09-18 23:25 ` Jason Gunthorpe
2023-09-18 23:25 ` Jason Gunthorpe
2023-09-15 16:58 ` [PATCH v3 3/7] iommu: Validate that devices match domains Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-18 5:49 ` Baolu Lu
2023-09-18 5:49 ` Baolu Lu
2023-09-18 10:08 ` Robin Murphy
2023-09-18 10:08 ` Robin Murphy
2023-09-15 16:58 ` [PATCH v3 4/7] iommu: Switch __iommu_domain_alloc() to device ops Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-18 6:10 ` Baolu Lu
2023-09-18 6:10 ` Baolu Lu
2023-09-18 10:36 ` Robin Murphy
2023-09-18 10:36 ` Robin Murphy
2023-09-15 16:58 ` [PATCH v3 5/7] iommu/arm-smmu: Don't register fwnode for legacy binding Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-15 16:58 ` [PATCH v3 6/7] iommu: Retire bus ops Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-24 1:18 ` kernel test robot [this message]
2023-09-15 16:58 ` [PATCH v3 7/7] iommu: Clean up open-coded ownership checks Robin Murphy
2023-09-15 16:58 ` Robin Murphy
2023-09-18 16:24 ` [PATCH v3 0/7] Iommu: Retire bus ops Jason Gunthorpe
2023-09-18 16:24 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309240920.GEdNuhRO-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.