Re: [PATCH] accel/ivpu: Add Arrow Lake pci id

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

On Fri, Sep 22, 2023 at 09:24:08AM -0600, Jeffrey Hugo wrote:
> On 9/22/2023 7:22 AM, Stanislaw Gruszka wrote:
> > Enable VPU on Arrow Lake CPUs.
> > 
> > Reviewed-by: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> > Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > ---
> >   drivers/accel/ivpu/ivpu_drv.c | 1 +
> >   drivers/accel/ivpu/ivpu_drv.h | 2 ++
> >   2 files changed, 3 insertions(+)
> > 
> > diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> > index ba79f397c9e8..aa7314fdbc0f 100644
> > --- a/drivers/accel/ivpu/ivpu_drv.c
> > +++ b/drivers/accel/ivpu/ivpu_drv.c
> > @@ -634,6 +634,7 @@ static void ivpu_dev_fini(struct ivpu_device *vdev)
> >   static struct pci_device_id ivpu_pci_ids[] = {
> >   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_MTL) },
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_ARL) },
> >   	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_LNL) },
> >   	{ }
> >   };
> > diff --git a/drivers/accel/ivpu/ivpu_drv.h b/drivers/accel/ivpu/ivpu_drv.h
> > index 9e8c075fe9ef..03b3d6532fb6 100644
> > --- a/drivers/accel/ivpu/ivpu_drv.h
> > +++ b/drivers/accel/ivpu/ivpu_drv.h
> > @@ -23,6 +23,7 @@
> >   #define DRIVER_DATE "20230117"
> >   #define PCI_DEVICE_ID_MTL   0x7d1d
> > +#define PCI_DEVICE_ID_ARL   0xad1d
> >   #define PCI_DEVICE_ID_LNL   0x643e
> 
> I'm curious, how are these ordered?  Release date?  Doesn't seem like it is
> alphabetical nor numerical by DID.

Yes, it's release date based.

> Not a problem, just something I'd like to know.
> 
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

Thanks
Stanislaw