From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249A11399; Mon, 25 Sep 2023 02:26:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695608789; x=1727144789; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Q7KZnD+OweNbFKPAwXooi6SlHogRzpFGBSpsJx27HIQ=; b=ZgLmLpAtqHMZ44xLt3tvfgYwjMB160+rQMNo17Xq730bOluYOS3s41hQ ixWZzU9pOIz3xd6enrk7vHjOPFjBFMHOY/vrTq9Su8antL6T/Eo1cAWdV 1nkpysJ2+4WLNV5YaUWvlOEb+v2xgJHNO7b1QvuFHeMQVFeJt4prTc7bw IRONbuj3sPQmIkRg1TqwUCwiadPsw7IC4gAFwzbPajURbIHJvPdXboCRU UW3pzFAjI7SbjrbNvlJuzXPNujFxJ1JseW94TZxDGbhg8z0dylp0OWPut D4/EpCa9Xv6Dn7LqH2fQBIqy4F5exa3y8KF335HFwWONLLZHUVMLzv3j3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="378419837" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="378419837" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2023 19:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="748191644" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="748191644" Received: from lkp-server02.sh.intel.com (HELO 32c80313467c) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 24 Sep 2023 19:26:16 -0700 Received: from kbuild by 32c80313467c with local (Exim 4.96) (envelope-from ) id 1qkbIc-0000n9-1g; Mon, 25 Sep 2023 02:26:14 +0000 Date: Mon, 25 Sep 2023 10:25:20 +0800 From: kernel test robot To: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Willem de Bruijn , Jamal Hadi Salim , Cong Wang , Jiri Pirko , netdev@vger.kernel.org, eric.dumazet@gmail.com, Eric Dumazet Subject: Re: [PATCH net-next 3/4] net_sched: sch_fq: add fast path for mostly idle qdisc Message-ID: <202309251006.HEmH6uZd-lkp@intel.com> References: <20230920125418.3675569-4-edumazet@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920125418.3675569-4-edumazet@google.com> Hi Eric, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net_sched-sch_fq-struct-sched_data-reorg/20230920-205744 base: net-next/main patch link: https://lore.kernel.org/r/20230920125418.3675569-4-edumazet%40google.com patch subject: [PATCH net-next 3/4] net_sched: sch_fq: add fast path for mostly idle qdisc config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230925/202309251006.HEmH6uZd-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230925/202309251006.HEmH6uZd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202309251006.HEmH6uZd-lkp@intel.com/ All warnings (new ones prefixed by >>): >> net/sched/sch_fq.c:550:1: warning: unused label 'queue' [-Wunused-label] queue: ^~~~~~ 1 warning generated. vim +/queue +550 net/sched/sch_fq.c 505 506 507 static int fq_enqueue(struct sk_buff *skb, struct Qdisc *sch, 508 struct sk_buff **to_free) 509 { 510 struct fq_sched_data *q = qdisc_priv(sch); 511 struct fq_flow *f; 512 513 if (unlikely(sch->q.qlen >= sch->limit)) 514 return qdisc_drop(skb, sch, to_free); 515 516 q->ktime_cache = ktime_get_ns(); 517 if (!skb->tstamp) { 518 fq_skb_cb(skb)->time_to_send = q->ktime_cache; 519 } else { 520 /* Check if packet timestamp is too far in the future. */ 521 if (fq_packet_beyond_horizon(skb, q)) { 522 if (q->horizon_drop) { 523 q->stat_horizon_drops++; 524 return qdisc_drop(skb, sch, to_free); 525 } 526 q->stat_horizon_caps++; 527 skb->tstamp = q->ktime_cache + q->horizon; 528 } 529 fq_skb_cb(skb)->time_to_send = skb->tstamp; 530 } 531 532 f = fq_classify(sch, skb); 533 if (unlikely(f->qlen >= q->flow_plimit && f != &q->internal)) { 534 q->stat_flows_plimit++; 535 return qdisc_drop(skb, sch, to_free); 536 } 537 538 if (fq_flow_is_detached(f)) { 539 fq_flow_add_tail(&q->new_flows, f); 540 if (time_after(jiffies, f->age + q->flow_refill_delay)) 541 f->credit = max_t(u32, f->credit, q->quantum); 542 } 543 544 if (unlikely(f == &q->internal)) { 545 q->stat_internal_packets++; 546 } else { 547 if (f->qlen == 0) 548 q->inactive_flows--; 549 } > 550 queue: 551 f->qlen++; 552 /* Note: this overwrites f->age */ 553 flow_queue_add(f, skb); 554 555 qdisc_qstats_backlog_inc(sch, skb); 556 sch->q.qlen++; 557 558 return NET_XMIT_SUCCESS; 559 } 560 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki