Re: [yocto] [meta-rockchip][PATCH v2] rock5b: add

[Trevor Woerner <twoerner@gmail.com>]

Hi Anthony,

On Sun 2023-09-24 @ 05:10:41 PM, Anthony Davies wrote:
> Thanks for your work Trevor, I have been waiting for this for a while.
> 
> I am new around here so forgive me if I am being impertinent but my only
> feedback would be to keep the naming of the machines consistent with the dtb
> and uboot defconfig? ie, rock-5b rather then rock5b?

In meta-rockchip we try to follow the naming that the manufacturer gives to
the product. Device-tree names come and go, get munged together, and split
apart. While the kernel might call it rock-5b today, some new board might come
along that causes a refactorisation leading to a whole bunch of renaming.

That said the manufacturer isn't 100% clear on the naming of this product. One
of the original post introducing the product,
https://forum.radxa.com/t/introduce-rock-5-model-b-arm-desktop-level-sbc/8361
shows it written both "Rock5B" and "Rock 5B".

From the manufacturer's own website, they seem to attach the "5" to the "Rock"
(without a space) when they're just saying "Rock5", but add a space when
they're distinguishing between the "A" and "B" variants:
https://wiki.radxa.com/Rock5
https://wiki.radxa.com/Rock5/5b

So the naming could go either way. Given that there are more instances of
"Rock 5B" we could go with what you suggest.

Thanks!