All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: <yann.morin@orange.com>
Cc: Anisse Astier <anisse@astier.eu>,
	Christian Stewart <christian@aperture.us>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv2] package/go: cgo for the target needs the toolchain
Date: Mon, 25 Sep 2023 15:42:32 +0200	[thread overview]
Message-ID: <20230925154232.69fdc4bd@windsurf> (raw)
In-Reply-To: <85bdd1b26ba56471330e98465095d943b54e3e74.1695644947.git.yann.morin@orange.com>

On Mon, 25 Sep 2023 14:29:15 +0200
<yann.morin@orange.com> wrote:

> From: "Yann E. MORIN" <yann.morin@orange.com>

So if you're the author...

> When the target is not supported by go, then there is obviously no need
> to depend on the toolchain (even if we unconditionally enable cgo
> support in only-for-the-host host-go).
> 
> Signed-off-by: Christian Stewart <christian@aperture.us>

Christian should not be the first Signed-off-by, but you should be.

I believe this was originally written by Christian, and you extended
the commit log/improved the patch, so I guess Christian should be kept
as the author.

> [yann.morin@orange.com:
>   - only add the toolchain dependency for target cgo
>   - reword commit log
> ]
> Signed-off-by: Yann E. MORIN <yann.morin@orange.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Anisse Astier <anisse@astier.eu>

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-09-25 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 12:29 [Buildroot] [PATCHv2] package/go: cgo for the target needs the toolchain yann.morin
2023-09-25 13:42 ` Thomas Petazzoni via buildroot [this message]
2023-09-25 13:47   ` yann.morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230925154232.69fdc4bd@windsurf \
    --to=buildroot@buildroot.org \
    --cc=anisse@astier.eu \
    --cc=christian@aperture.us \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.