From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E45E7D240 for ; Tue, 26 Sep 2023 07:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231908AbjIZHZs (ORCPT ); Tue, 26 Sep 2023 03:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbjIZHZq (ORCPT ); Tue, 26 Sep 2023 03:25:46 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9890BDE; Tue, 26 Sep 2023 00:25:40 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DD3A380A3; Tue, 26 Sep 2023 07:25:39 +0000 (UTC) Date: Tue, 26 Sep 2023 10:25:38 +0300 From: Tony Lindgren To: Trevor Woerner Cc: robertcnelson@gmail.com, drew@beagleboard.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v3 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux Message-ID: <20230926072538.GY5285@atomide.com> References: <20230822143051.7640-1-twoerner@gmail.com> <20230822143051.7640-5-twoerner@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822143051.7640-5-twoerner@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Trevor Woerner [230822 14:31]: > Add the default MODE setting of a GPIO pin that was missing from the device > tree (i.e. P2.20/gpio2_00). This is to ensure the GPIO pins match the > pocketbeagle wiring expectations. > > Signed-off-by: Trevor Woerner > --- > arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > index e35d84ca5706..8042917b3b3b 100644 > --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > @@ -271,6 +271,16 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_AD14, PIN_INPUT_PULLUP, MUX_MODE7) > pinctrl-single,bias-pulldown = < 0x10 0x00 0x10 0x18>; > }; > > + /* P2_20 (ZCZ ball T13) gpio2_00 0x888 */ > + P2_20_gpio: P2-20-gpio-pins { > + pinctrl-single,pins = < > + AM33XX_PADCONF(AM335X_PIN_GPMC_CSN3, PIN_INPUT_PULLUP, MUX_MODE7) > + >; > + pinctrl-single,bias-pullup = < 0x10 0x10 0x00 0x18>; > + pinctrl-single,bias-pulldown = < 0x10 0x00 0x10 0x18>; > + }; > + > + > /* P2_10 (ZCZ ball R14) gpio1_20 0x850 PIN 20 */ > P2_10_gpio: P2-10-gpio-pins { > pinctrl-single,pins = < Thanks applying all four patches into omap-for-v6.7/dt. I left out the extra line break above though. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C455E7D243 for ; Tue, 26 Sep 2023 07:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q2RisNkcno4uO9UvLP2+DH8sHkWAL5jSJ437T7Si3Y0=; b=F8jjSZL8D1GZcW aCfDzYjaUlP3oyTy2sKW5oW7mWy5TuCObBqiFJKagZdd5vGCNaN6sHJkcsYWT8Na7sZ/06mxXgQSr I+k9kXP1y+RVDjISpmaHZnD7RkJ7BJ+rqccha2C9vUhUbCSoN1//1Q6VOsU9Y0c2qU2FNCUqL2u5D CDJEguumHFUH4w7NpG4wFPgH2ZNuIh8jbrYeJDSRXIqdIRFKCIU08r9fPpqHb0920b5hu88QlW8wh Kbb/GUIFhflBuvks5HG0dELP1/UcfkRXmZUXhPn9hyU8U0UuaeA45l0ubSIUpsRPsqdYMCHaZVu0X mC+Ru/FUKJbAB81MZiWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql2Ry-00Fn9N-2X; Tue, 26 Sep 2023 07:25:42 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql2Rw-00Fn92-2y for linux-arm-kernel@lists.infradead.org; Tue, 26 Sep 2023 07:25:42 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DD3A380A3; Tue, 26 Sep 2023 07:25:39 +0000 (UTC) Date: Tue, 26 Sep 2023 10:25:38 +0300 From: Tony Lindgren To: Trevor Woerner Cc: robertcnelson@gmail.com, drew@beagleboard.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v3 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux Message-ID: <20230926072538.GY5285@atomide.com> References: <20230822143051.7640-1-twoerner@gmail.com> <20230822143051.7640-5-twoerner@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230822143051.7640-5-twoerner@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_002541_004556_00ECE63D X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Trevor Woerner [230822 14:31]: > Add the default MODE setting of a GPIO pin that was missing from the device > tree (i.e. P2.20/gpio2_00). This is to ensure the GPIO pins match the > pocketbeagle wiring expectations. > > Signed-off-by: Trevor Woerner > --- > arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > index e35d84ca5706..8042917b3b3b 100644 > --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts > @@ -271,6 +271,16 @@ AM33XX_PADCONF(AM335X_PIN_GPMC_AD14, PIN_INPUT_PULLUP, MUX_MODE7) > pinctrl-single,bias-pulldown = < 0x10 0x00 0x10 0x18>; > }; > > + /* P2_20 (ZCZ ball T13) gpio2_00 0x888 */ > + P2_20_gpio: P2-20-gpio-pins { > + pinctrl-single,pins = < > + AM33XX_PADCONF(AM335X_PIN_GPMC_CSN3, PIN_INPUT_PULLUP, MUX_MODE7) > + >; > + pinctrl-single,bias-pullup = < 0x10 0x10 0x00 0x18>; > + pinctrl-single,bias-pulldown = < 0x10 0x00 0x10 0x18>; > + }; > + > + > /* P2_10 (ZCZ ball R14) gpio1_20 0x850 PIN 20 */ > P2_10_gpio: P2-10-gpio-pins { > pinctrl-single,pins = < Thanks applying all four patches into omap-for-v6.7/dt. I left out the extra line break above though. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel