From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43A2E7D26E for ; Tue, 26 Sep 2023 09:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234109AbjIZJRM (ORCPT ); Tue, 26 Sep 2023 05:17:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234093AbjIZJRL (ORCPT ); Tue, 26 Sep 2023 05:17:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4863E126; Tue, 26 Sep 2023 02:17:05 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6890C433C7; Tue, 26 Sep 2023 09:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695719824; bh=BIyysZ/qJRqN0WjlvEhE3O9YSQ2fL55IakHxJk2wiFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pk0oGlfNE3jFIafSlZ/PJM8crMk0kZpKbAl63Pt8xFxC6dE772Zo11TKkyC+qAfGv mC51S4m+kdv7pUDUxDBisK7C5anncKQhVgJKdSTAjChwzIR3g0dzfcWm6nXM303C8x x5cqGmxaFPyS3dDy9omSmLG7l27/pmd1rUYsWQMlfrRc8y6bCy5Nf2Otx86cV0BHdN HZL51tnpOzeE0oBMzUdzgADTZZEB89cocxYB0GD8TJw0OYtEWP5P3uW3GvK5C0i9YG ZUwDroczEB2Rd56K6DGUbvO+ptW1PmDnExiQnH0PaNBGD494RFJpE9SwdV+GAHG3qp IA+8vSTmRBB+w== Date: Tue, 26 Sep 2023 10:16:59 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Daniel Thompson , Jingoo Han , Aisheng Dong , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, Helge Deller , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@pengutronix.de Subject: Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend Message-ID: <20230926091659.GF9999@google.com> References: <20230926084612.2074692-1-u.kleine-koenig@pengutronix.de> <20230926085336.czgrztefbrstzbw7@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230926085336.czgrztefbrstzbw7@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org On Tue, 26 Sep 2023, Uwe Kleine-König wrote: > On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote: > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > > the PWM any more. However this is necessary to suspend because PWM > > drivers usually refuse to suspend if they are still enabled. > > > > Also adapt shutdown to disable the PWM for similar reasons. > > > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") > > Reported-by: Aisheng Dong > > Tested-by: Aisheng Dong > > The two email addresses should actually be identical, the first one is > the right one. (Failure introduced by > https://lore.kernel.org/dri-devel/DB9PR04MB8477D4BBF1B31035789DA08680869@DB9PR04MB8477.eurprd04.prod.outlook.com > and picked up by b4.) Lee, can you fixup or should I resend? I'll probably forget by the time Daniel gets around to review. Your call, but probably safer to turn it around yourself. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBC5EE7D26D for ; Tue, 26 Sep 2023 09:17:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0206E10E37B; Tue, 26 Sep 2023 09:17:09 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 347AB10E37B for ; Tue, 26 Sep 2023 09:17:07 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 85914B80EBA; Tue, 26 Sep 2023 09:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6890C433C7; Tue, 26 Sep 2023 09:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695719824; bh=BIyysZ/qJRqN0WjlvEhE3O9YSQ2fL55IakHxJk2wiFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pk0oGlfNE3jFIafSlZ/PJM8crMk0kZpKbAl63Pt8xFxC6dE772Zo11TKkyC+qAfGv mC51S4m+kdv7pUDUxDBisK7C5anncKQhVgJKdSTAjChwzIR3g0dzfcWm6nXM303C8x x5cqGmxaFPyS3dDy9omSmLG7l27/pmd1rUYsWQMlfrRc8y6bCy5Nf2Otx86cV0BHdN HZL51tnpOzeE0oBMzUdzgADTZZEB89cocxYB0GD8TJw0OYtEWP5P3uW3GvK5C0i9YG ZUwDroczEB2Rd56K6DGUbvO+ptW1PmDnExiQnH0PaNBGD494RFJpE9SwdV+GAHG3qp IA+8vSTmRBB+w== Date: Tue, 26 Sep 2023 10:16:59 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2] backlight: pwm_bl: Disable PWM on shutdown and suspend Message-ID: <20230926091659.GF9999@google.com> References: <20230926084612.2074692-1-u.kleine-koenig@pengutronix.de> <20230926085336.czgrztefbrstzbw7@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230926085336.czgrztefbrstzbw7@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , linux-pwm@vger.kernel.org, Daniel Thompson , Jingoo Han , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , kernel@pengutronix.de Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 26 Sep 2023, Uwe Kleine-König wrote: > On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote: > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > > the PWM any more. However this is necessary to suspend because PWM > > drivers usually refuse to suspend if they are still enabled. > > > > Also adapt shutdown to disable the PWM for similar reasons. > > > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") > > Reported-by: Aisheng Dong > > Tested-by: Aisheng Dong > > The two email addresses should actually be identical, the first one is > the right one. (Failure introduced by > https://lore.kernel.org/dri-devel/DB9PR04MB8477D4BBF1B31035789DA08680869@DB9PR04MB8477.eurprd04.prod.outlook.com > and picked up by b4.) Lee, can you fixup or should I resend? I'll probably forget by the time Daniel gets around to review. Your call, but probably safer to turn it around yourself. -- Lee Jones [李琼斯]