From: Mads Ynddal <mads@ynddal.dk>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
John Snow <jsnow@redhat.com>, Mads Ynddal <mads@ynddal.dk>,
Cleber Rosa <crosa@redhat.com>,
Mads Ynddal <m.ynddal@samsung.com>
Subject: [PATCH v5 01/14] simpletrace: add __all__ to define public interface
Date: Tue, 26 Sep 2023 12:34:23 +0200 [thread overview]
Message-ID: <20230926103436.25700-2-mads@ynddal.dk> (raw)
In-Reply-To: <20230926103436.25700-1-mads@ynddal.dk>
From: Mads Ynddal <m.ynddal@samsung.com>
It was unclear what was the supported public interface. I.e. when
refactoring the code, what functions/classes are important to retain.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
---
scripts/simpletrace.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index 1f6d1ae1f3..b221d9a241 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -14,6 +14,8 @@
from tracetool import read_events, Event
from tracetool.backend.simple import is_string
+__all__ = ['Analyzer', 'process', 'run']
+
header_event_id = 0xffffffffffffffff
header_magic = 0xf2b177cb0aa429b4
dropped_event_id = 0xfffffffffffffffe
--
2.38.1
next prev parent reply other threads:[~2023-09-26 10:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 10:34 [PATCH v5 00/14] simpletrace: refactor and general improvements Mads Ynddal
2023-09-26 10:34 ` Mads Ynddal [this message]
2023-09-26 10:34 ` [PATCH v5 02/14] simpletrace: annotate magic constants from QEMU code Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 03/14] simpletrace: improve parsing of sys.argv; fix files never closed Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 04/14] simpletrace: changed naming of edict and idtoname to improve readability Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 05/14] simpletrace: update code for Python 3.11 Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 06/14] simpletrace: improved error handling on struct unpack Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 07/14] simpletrace: define exception and add handling Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 08/14] simpletrace: made Analyzer into context-manager Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 09/14] simpletrace: refactor to separate responsibilities Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 10/14] simpletrace: move logic of process into internal function Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 11/14] simpletrace: move event processing to Analyzer class Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 12/14] simpletrace: added simplified Analyzer2 class Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 13/14] MAINTAINERS: add maintainer of simpletrace.py Mads Ynddal
2023-09-26 10:34 ` [PATCH v5 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items() Mads Ynddal
2023-09-26 16:32 ` [PATCH v5 00/14] simpletrace: refactor and general improvements Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926103436.25700-2-mads@ynddal.dk \
--to=mads@ynddal.dk \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=m.ynddal@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.