From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84EBBE7E622 for ; Tue, 26 Sep 2023 11:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fg4Ry3uUPfI5Mzvg1iosrlnXn4MBEJEACkhLA4zkyY4=; b=zJSpmrlyyEWaxG 1gbjl58R45/Vwxdl0YBJk+4g/Xw35+UNUeiWBy1GIHKY5IaqKnMmHHDqLZCXailtnx4+JtcmhU5Eu S1zWew6xuvxFrWK7nzqn6Sqro2SMtDyawenEgIeRWECbUticIynRpd8mjvgCLBC++b9wpVSebYrqL +DIt2bk14KVi/1N2dvDswIPBjVX1ZlIv9uoad0yvWkVdOFKChZHEaXy2Y+7cWLHv7Yfl5CXCbUpjg 2t7CUPW82nwmSgR6QTcCvSCMfW8/Sw11B94ONHU6ftmRXg9YKhUkPm9fpEZNggKZgfKHg1T6rYtJs tgJWurUlszXvZs4yHohQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ql6E8-00GGFj-0f; Tue, 26 Sep 2023 11:27:40 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ql6E4-00GGEf-2Y for linux-mtd@lists.infradead.org; Tue, 26 Sep 2023 11:27:38 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id D04D11BF207; Tue, 26 Sep 2023 11:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695727651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XOl6fnlKF+niRG0ZCtakx0gehGFGsJ9KF6QsiqviyXo=; b=f/QRq7u+ltuV+v6rOPfpQRvbA0UwQNJ1Q68Rwar/CptGcq09366A1iGb/5Qw/ZWOhLHTtr tWHV/v+1q3rlV9Xiw53kP7jaR4eLs2b4KGxVzeFetbh6wqU6HN8v2+HepV9iU5lNCvl1KB iwJvOaH29e5uikgMNMcbSxO5DCCpDePFFTlsy+Y+1sVsGV/mpxwArKVheLdoz24dbLNa+e fkL/loOK3lQFr3PAHocepNzdRAlLssMBV22lCmNnnWS110GFr2Iq8HRngCE+lbQUCoinCB TqtkQelxzkXY7jM3SaqsrloFjPo/LmxzyiRImJJEkuPw22DoL4LF+e3sWeFWFg== Date: Tue, 26 Sep 2023 13:27:25 +0200 From: Miquel Raynal To: Martin =?UTF-8?B?SHVuZGViw7hsbA==?= Cc: Rouven Czerwinski , =?UTF-8?B?TcOlbnMg?= =?UTF-8?B?UnVsbGfDpXJk?= , Alexander Shiyan , Richard Weinberger , Vignesh Raghavendra , JaimeLiao , kernel@pengutronix.de, stable@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sean =?UTF-8?B?Tnlla2rDpnI=?= , Domenico Punzo , Bean Huo Subject: Re: [PATCH v2] mtd: rawnand: Ensure the nand chip supports cached reads Message-ID: <20230926132725.5d570e1b@xps-13> In-Reply-To: References: <20230922141717.35977-1-r.czerwinski@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_042737_278463_AFA912E1 X-CRM114-Status: GOOD ( 36.05 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFydGluLAoKKyBCZWFuIGFuZCBEb21lbmljbywgdGhlcmUgaXMgYSBxdWVzdGlvbiBmb3Ig eW91IGJlbG93LgoKbWFydGluQGdlYW5peC5jb20gd3JvdGUgb24gTW9uLCAyNSBTZXAgMjAyMyAx MzowMTowNiArMDIwMDoKCj4gSGkgUm91dmVuLAo+IAo+IE9uIEZyaSwgMjAyMy0wOS0yMiBhdCAx NjoxNyArMDIwMCwgUm91dmVuIEN6ZXJ3aW5za2kgd3JvdGU6Cj4gPiBCb3RoIHRoZSBKRURFQyBh bmQgT05GSSBzcGVjaWZpY2F0aW9uIHNheSB0aGF0IHJlYWQgY2FjaGUgc2VxdWVudGlhbAo+ID4g c3VwcG9ydCBpcyBhbiBvcHRpb25hbCBjb21tYW5kLiBUaGlzIG1lYW5zIHRoYXQgd2Ugbm90IG9u bHkgbmVlZCB0bwo+ID4gY2hlY2sgd2hldGhlciB0aGUgaW5kaXZpZHVhbCBjb250cm9sbGVyIHN1 cHBvcnRzIHRoZSBjb21tYW5kLCB3ZSBhbHNvCj4gPiBuZWVkIHRvIGNoZWNrIHRoZSBwYXJhbWV0 ZXIgcGFnZXMgZm9yIGJvdGggT05GSSBhbmQgSkVERUMgTkFORAo+ID4gZmxhc2hlcwo+ID4gYmVm b3JlIGVuYWJsaW5nIHNlcXVlbnRpYWwgY2FjaGUgcmVhZHMuCj4gPiAKPiA+IFRoaXMgZml4ZXMg c3VwcG9ydCBmb3IgTkFORCBmbGFzaGVzIHdoaWNoIGRvbid0IHN1cHBvcnQgZW5hYmxpbmcKPiA+ IGNhY2hlCj4gPiByZWFkcywgaS5lLiBTYW1zdW5nIEs5RjRHMDhVMEYgb3IgVG9zaGliYSBUQzU4 TlZHMFMzSFRBMDAuCj4gPiAKPiA+IFNlcXVlbnRpYWwgY2FjaGUgcmVhZHMgYXJlIG5vdyBvbmx5 IGF2YWlsYWJsZSBmb3IgT05GSSBhbmQgSkVERUMKPiA+IGRldmljZXMsIGlmIGluZGl2aWR1YWwg dmVuZG9ycyBpbXBsZW1lbnQgdGhpcywgaXQgbmVlZHMgdG8gYmUgZW5hYmxlZAo+ID4gcGVyIHZl bmRvci4KPiA+IAo+ID4gVGVzdGVkIG9uIGkuTVg2USB3aXRoIGEgU2Ftc3VuZyBOQU5EIGZsYXNo IGNoaXAgdGhhdCBkb2Vzbid0IHN1cHBvcnQKPiA+IHNlcXVlbnRpYWwgcmVhZHMuCj4gPiAKPiA+ IEZpeGVzOiAwMDNmZTRiOTU0NWIgKCJtdGQ6IHJhd25hbmQ6IFN1cHBvcnQgZm9yIHNlcXVlbnRp YWwgY2FjaGUKPiA+IHJlYWRzIikKPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBT aWduZWQtb2ZmLWJ5OiBSb3V2ZW4gQ3plcndpbnNraSA8ci5jemVyd2luc2tpQHBlbmd1dHJvbml4 LmRlPiAgCj4gCj4gVGhhbmtzIGZvciB0aGlzLiBJdCB3b3JrcyBhcyBleHBlY3RlZCBmb3IgbXkg VG9zaGliYSBjaGlwLCBvYnZpb3VzbHkKPiBiZWNhdXNlIGl0IGRvZXNuJ3QgdXNlIE9ORkkgb3Ig SkVERUMuCj4gCj4gVW5mb3J0dW5hdGVseSwgbXkgTWljcm9uIGNoaXAgZG9lcyB1c2UgT05GSSwg YW5kIGl0IHNldHMgdGhlIGNhY2hlZC0KPiByZWFkLXN1cHBvcnRlZCBiaXQuIEl0IHRoZW4gZmFp bHMgd2hlbiByZWFkaW5nIGFmdGVyd29yZHM6Cj4gCj4ga2VybmVsOiBPTkZJX09QVF9DTURfUkVB RF9DQUNIRSAjIGRlYnVnIGFkZGVkIGJ5IG1lCj4ga2VybmVsOiBuYW5kOiBkZXZpY2UgZm91bmQs IE1hbnVmYWN0dXJlciBJRDogMHgyYywgQ2hpcCBJRDogMHhkYwo+IGtlcm5lbDogbmFuZDogTWlj cm9uIE1UMjlGNEcwOEFCQUZBV1AKPiBrZXJuZWw6IG5hbmQ6IDUxMiBNaUIsIFNMQywgZXJhc2Ug c2l6ZTogMjU2IEtpQiwgcGFnZSBzaXplOiA0MDk2LCBPT0IKPiBzaXplOiAyNTYKPiBrZXJuZWw6 IG5hbmQ6IGNvbnRpbnVlZCByZWFkIHN1cHBvcnRlZCAjIGRlYnVnIGFkZGVkIGJ5IG1lCj4ga2Vy bmVsOiBCYWQgYmxvY2sgdGFibGUgZm91bmQgYXQgcGFnZSAxMzEwMDgsIHZlcnNpb24gMHgwMQo+ IGtlcm5lbDogQmFkIGJsb2NrIHRhYmxlIGZvdW5kIGF0IHBhZ2UgMTMwOTQ0LCB2ZXJzaW9uIDB4 MDEKPiBrZXJuZWw6IDIgZml4ZWQtcGFydGl0aW9ucyBwYXJ0aXRpb25zIGZvdW5kIG9uIE1URCBk ZXZpY2UgZ3BtaS1uYW5kCj4ga2VybmVsOiBDcmVhdGluZyAyIE1URCBwYXJ0aXRpb25zIG9uICJn cG1pLW5hbmQiOgo+IGtlcm5lbDogMHgwMDAwMDAwMDAwMDAtMHgwMDAwMDA4MDAwMDAgOiAiYm9v dCIKPiBrZXJuZWw6IDB4MDAwMDAwODAwMDAwLTB4MDAwMDIwMDAwMDAwIDogInViaSIKPiBrZXJu ZWw6IGdwbWktbmFuZCAxODA2MDAwLm5hbmQtY29udHJvbGxlcjogZHJpdmVyIHJlZ2lzdGVyZWQu Cj4gCj4gLi4uCj4gCj4ga2VybmVsOiB1YmkwOiBkZWZhdWx0IGZhc3RtYXAgcG9vbCBzaXplOiAx MDAKPiBrZXJuZWw6IHViaTA6IGRlZmF1bHQgZmFzdG1hcCBXTCBwb29sIHNpemU6IDUwCj4ga2Vy bmVsOiB1YmkwOiBhdHRhY2hpbmcgbXRkMQo+IGtlcm5lbDogdWJpMDogc2Nhbm5pbmcgaXMgZmlu aXNoZWQKPiBrZXJuZWw6IHViaTA6IGF0dGFjaGVkIG10ZDEgKG5hbWUgInViaSIsIHNpemUgNTA0 IE1pQikKPiBrZXJuZWw6IHViaTA6IFBFQiBzaXplOiAyNjIxNDQgYnl0ZXMgKDI1NiBLaUIpLCBM RUIgc2l6ZTogMjUzOTUyIGJ5dGVzCj4ga2VybmVsOiB1YmkwOiBtaW4uL21heC4gSS9PIHVuaXQg c2l6ZXM6IDQwOTYvNDA5Niwgc3ViLXBhZ2Ugc2l6ZSA0MDk2Cj4ga2VybmVsOiB1YmkwOiBWSUQg aGVhZGVyIG9mZnNldDogNDA5NiAoYWxpZ25lZCA0MDk2KSwgZGF0YSBvZmZzZXQ6IDgxOTIKPiBr ZXJuZWw6IHViaTA6IGdvb2QgUEVCczogMjAxMiwgYmFkIFBFQnM6IDQsIGNvcnJ1cHRlZCBQRUJz OiAwCj4ga2VybmVsOiB1YmkwOiB1c2VyIHZvbHVtZTogOSwgaW50ZXJuYWwgdm9sdW1lczogMSwg bWF4LiB2b2x1bWVzIGNvdW50Ogo+IDEyOAo+IGtlcm5lbDogdWJpMDogbWF4L21lYW4gZXJhc2Ug Y291bnRlcjogNC8yLCBXTCB0aHJlc2hvbGQ6IDQwOTYsIGltYWdlCj4gc2VxdWVuY2UgbnVtYmVy OiAxNDMxNDk3MjIxCj4ga2VybmVsOiB1YmkwOiBhdmFpbGFibGUgUEVCczogMTIsIHRvdGFsIHJl c2VydmVkIFBFQnM6IDIwMDAsIFBFQnMKPiByZXNlcnZlZCBmb3IgYmFkIFBFQiBoYW5kbGluZzog MzYKPiBrZXJuZWw6IGJsb2NrIHViaWJsb2NrMF80OiBjcmVhdGVkIGZyb20gdWJpMDo0KHJvb3Rm cy5hKQo+IGtlcm5lbDogdWJpMDogYmFja2dyb3VuZCB0aHJlYWQgInViaV9iZ3QwZCIgc3RhcnRl ZCwgUElEIDM2Cj4ga2VybmVsOiBibG9jayB1YmlibG9jazBfNjogY3JlYXRlZCBmcm9tIHViaTA6 NihhcHBmcy5hKQo+IGtlcm5lbDogYmxvY2sgdWJpYmxvY2swXzc6IGNyZWF0ZWQgZnJvbSB1Ymkw OjcoYXBwZnMuYikKPiAKPiAuLi4KPiAKPiBrZXJuZWw6IFNRVUFTSEZTIGVycm9yOiBVbmFibGUg dG8gcmVhZCBkaXJlY3RvcnkgYmxvY2sgWzRiNmQxNWM6ZWQxXQo+IGtlcm5lbDogU1FVQVNIRlMg ZXJyb3I6IFVuYWJsZSB0byByZWFkIGRpcmVjdG9yeSBibG9jayBbNGI2ZjE1ZToxMjVdCj4ga2Vy bmVsOiBTUVVBU0hGUyBlcnJvcjogVW5hYmxlIHRvIHJlYWQgZGlyZWN0b3J5IGJsb2NrIFs0YjZk MTVjOjFkYWVdCj4ga2VybmVsOiBTUVVBU0hGUyBlcnJvcjogVW5hYmxlIHRvIHJlYWQgZGlyZWN0 b3J5IGJsb2NrIFs0YjZkMTVjOmVkMV0KPiAoZC1zeXNjdGwpWzU1XTogc3lzdGVtZC1zeXNjdGwu c2VydmljZTogRmFpbGVkIHRvIHNldCB1cCBjcmVkZW50aWFsczoKPiBQcm90b2NvbCBlcnJvcgo+ IGtlcm5lbDogU1FVQVNIRlMgZXJyb3I6IFVuYWJsZSB0byByZWFkIGRpcmVjdG9yeSBibG9jayBb NGI3MzE2MjoxNGYwXQo+IGtlcm5lbDogU1FVQVNIRlMgZXJyb3I6IFVuYWJsZSB0byByZWFkIGRp cmVjdG9yeSBibG9jayBbNGI2ZjE1ZTo4MzhdCj4gc3lzdGVtZFsxXTogU3RhcnRpbmcgQ3JlYXRl IFN0YXRpYyBEZXZpY2UgTm9kZXMgaW4gL2Rldi4uLgo+IGtlcm5lbDogU1FVQVNIRlMgZXJyb3I6 IFVuYWJsZSB0byByZWFkIGRpcmVjdG9yeSBibG9jayBbNGI2ZDE1YzplZDFdCj4ga2VybmVsOiBT UVVBU0hGUyBlcnJvcjogVW5hYmxlIHRvIHJlYWQgZGlyZWN0b3J5IGJsb2NrIFs0YjZkMTVjOmVk MV0KPiBrZXJuZWw6IFNRVUFTSEZTIGVycm9yOiBVbmFibGUgdG8gcmVhZCBkaXJlY3RvcnkgYmxv Y2sgWzRiNmYxNWU6ODM4XQo+IGtlcm5lbDogU1FVQVNIRlMgZXJyb3I6IFVuYWJsZSB0byByZWFk IGRpcmVjdG9yeSBibG9jayBbNGI2ZDE1YzoxZGFlXQo+IGtlcm5lbDogU1FVQVNIRlMgZXJyb3I6 IFVuYWJsZSB0byByZWFkIGRpcmVjdG9yeSBibG9jayBbNGI2ZjE1ZToxMjVdCj4gCj4gSSd2ZSBi cmllZmx5IHRyaWVkIGFkZGluZyBzb21lIGVycm9yIGluZm8gdGhlIHRoZSBzcXVhc2hmcyBlcnJv cgo+IG1lc3NhZ2VzLCBidXQgaXQgbG9va3MgbGlrZSBpdCdzIGdldHRpbmcgYmFkIGRhdGEuIEku ZS4gb25lIGZhaWx1cmUgYQo+IHNhbml0eSBjaGVjayBvZiBgZGlyX2NvdW50YDoKPiAKPiBpZiAo ZGlyX2NvdW50ID4gU1FVQVNIRlNfRElSX0NPVU5UKQo+IAlnb3RvIGRhdGFfZXJyb3I7Cj4gCj4g SXQgZmFpbHMgd2l0aCBgZGlyX2NvdW50YCBiZWluZyAxOTUyODAzNjg0IC4uLgo+IAo+IFNvIGlz IHRoaXMgYSBjYXNlIG9mIHdyb25nL2JhZCB0aW1pbmdzPwo+IAo+IE1pcXVlbDoKPiBJIGNhbiB0 ZWxsIGZyb20gdGhlIGNvZGUsIHRoYXQgdGhlIFJFQURDQUNIRVNFUSBvcGVyYXRpb25zIGFyZSBm b2xsb3dlZAo+IGJ5IE5BTkRfT1BfV0FJVF9SRFkodFJfbWF4LCB0UlJfbWluKS4gRnJvbSB0aGUg TWljcm9uIGRhdGFzaGVldFswXSwgaXQKPiBzaG91bGQgYmUgTkFORF9PUF9XQUlUX1JEWSh0UkNC U1lfbWF4LCB0UlJfbWluKSwgd2hlcmUgdFJDQlNZIGlzCj4gZGVmaW5lZCB0byBiZSBiZXR3ZWVu IDMgYW5kIDI1IMK1cy4KCkkgZm91bmQgYSBwbGFjZSBpbiB0aGUgT05GSSBzcGVjIHN0YXRlcyB0 YWh0IHRSQ0JTWV9tYXggc2hvdWxkIGJlCmJldHdlZW4gMyBhbmQgdFJfbWF4LCBzbyBpbmRlZWQg d2Ugc2hvdWxkIGJlIGZpbmUgb24gdGhhdCByZWdhcmQuCgpIb3dldmVyLCBJIGFza2VkIG15c2Vs ZiB3aGV0aGVyIHdlIGNvdWxkIGhhdmUgaXNzdWVzIHdoZW4gY3Jvc3NpbmcKYm91bmRhcmllcy4g QmxvY2sgYm91bmRhcmllcyBzaG91bGQgYmUgZmluZSwgaG93ZXZlciB5b3VyIGRldmljZSBkb2Vz Cm5vdCBzdXBwb3J0IGNyb3NzaW5nIHBsYW5lIGJvdW5kYXJpZXMsIGFzIGJpdCA0ICgicmVhZCBj YWNoZQpzdXBwb3J0ZWQiKSBvZiBieXRlIDExNCAoIk11bHRpLXBsYW5lIG9wZXJhdGlvbiBhdHRy aWJ1dGVzIikgaW4gdGhlCm1lbW9yeSBvcmdhbml6YXRpb24gYmxvY2sgb2YgdGhlIHBhcmFtZXRl ciBwYWdlIGlzIG5vdCBzZXQgKHRoZSB2YWx1ZQpvZiB0aGUgYnl0ZSBzaG91bGQgYmUgMHgwRSBp ZiBJIGdldCBpdCByaWdodC4KCkFueXdheSwgb3VyIG1haW4gaXNzdWUgaGVyZSBkb2VzIG5vdCBz ZWVtIHJlbGF0ZWQgdG8gdGhlIGJvdW5kYXJpZXMuIEl0CmRvZXMgbm90IHNlZW0gdG8gYmUgZXhw bGljaXRseSBtYXJrZWQgYW55d2hlcmUgZWxzZSBidXQgb24gdGhlIGZyb250CnBhZ2U6CglBZHZh bmNlZCBjb21tYW5kIHNldAoJ4oCTIFByb2dyYW0gcGFnZSBjYWNoZSBtb2RlICg0KQoJ4oCTIFJl YWQgcGFnZSBjYWNoZSBtb2RlICg0KQoJ4oCTIFR3by1wbGFuZSBjb21tYW5kcyAoNCkKCgkoNCkg VGhlc2UgY29tbWFuZHMgc3VwcG9ydGVkIG9ubHkgd2l0aCBFQ0MgZGlzYWJsZWQuCgpSZWFkIHBh Z2UgY2FjaGUgbW9kZSB3aXRob3V0IEVDQyBtYWtlcyB0aGUgZmVhdHVyZSBwcmV0dHkgdXNlbGVz cyBJTUhPLgoKQmVhbiwgRG9tZW5pY28sIGhvdyBkbyB3ZSBrbm93IHdoaWNoIGRldmljZXMgYWxs b3cgRUNDIGNvcnJlY3Rpb24KZHVyaW5nIHNlcXVlbnRpYWwgcGFnZSByZWFkcyBhbmQgd2hpY2gg ZG9uJ3Q/IElzIHRoZXJlIGEgKHZlbmRvcj8pIGJpdApzb21ld2hlcmUgaW4gdGhlIHBhcmFtZXRl ciBwYWdlIGZvciB0aGF0PyBEbyB3ZSBoYXZlIGFueSB3YXkgdG8ga25vdwpiZXNpZGVzIGEgbGlz dCBvZiBkZXZpY2VzIGFsbG93aW5nIHRoYXQ/IElmIHNvLCBjYW4geW91IHByb3ZpZGUgb25lCndp dGggYSBmZXcgSURzPyAKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5804AE7E624 for ; Tue, 26 Sep 2023 11:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbjIZL1l (ORCPT ); Tue, 26 Sep 2023 07:27:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbjIZL1k (ORCPT ); Tue, 26 Sep 2023 07:27:40 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E45DE5; Tue, 26 Sep 2023 04:27:32 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id D04D11BF207; Tue, 26 Sep 2023 11:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695727651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XOl6fnlKF+niRG0ZCtakx0gehGFGsJ9KF6QsiqviyXo=; b=f/QRq7u+ltuV+v6rOPfpQRvbA0UwQNJ1Q68Rwar/CptGcq09366A1iGb/5Qw/ZWOhLHTtr tWHV/v+1q3rlV9Xiw53kP7jaR4eLs2b4KGxVzeFetbh6wqU6HN8v2+HepV9iU5lNCvl1KB iwJvOaH29e5uikgMNMcbSxO5DCCpDePFFTlsy+Y+1sVsGV/mpxwArKVheLdoz24dbLNa+e fkL/loOK3lQFr3PAHocepNzdRAlLssMBV22lCmNnnWS110GFr2Iq8HRngCE+lbQUCoinCB TqtkQelxzkXY7jM3SaqsrloFjPo/LmxzyiRImJJEkuPw22DoL4LF+e3sWeFWFg== Date: Tue, 26 Sep 2023 13:27:25 +0200 From: Miquel Raynal To: Martin =?UTF-8?B?SHVuZGViw7hsbA==?= Cc: Rouven Czerwinski , =?UTF-8?B?TcOlbnMg?= =?UTF-8?B?UnVsbGfDpXJk?= , Alexander Shiyan , Richard Weinberger , Vignesh Raghavendra , JaimeLiao , kernel@pengutronix.de, stable@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Sean =?UTF-8?B?Tnlla2rDpnI=?= , Domenico Punzo , Bean Huo Subject: Re: [PATCH v2] mtd: rawnand: Ensure the nand chip supports cached reads Message-ID: <20230926132725.5d570e1b@xps-13> In-Reply-To: References: <20230922141717.35977-1-r.czerwinski@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Martin, + Bean and Domenico, there is a question for you below. martin@geanix.com wrote on Mon, 25 Sep 2023 13:01:06 +0200: > Hi Rouven, >=20 > On Fri, 2023-09-22 at 16:17 +0200, Rouven Czerwinski wrote: > > Both the JEDEC and ONFI specification say that read cache sequential > > support is an optional command. This means that we not only need to > > check whether the individual controller supports the command, we also > > need to check the parameter pages for both ONFI and JEDEC NAND > > flashes > > before enabling sequential cache reads. > >=20 > > This fixes support for NAND flashes which don't support enabling > > cache > > reads, i.e. Samsung K9F4G08U0F or Toshiba TC58NVG0S3HTA00. > >=20 > > Sequential cache reads are now only available for ONFI and JEDEC > > devices, if individual vendors implement this, it needs to be enabled > > per vendor. > >=20 > > Tested on i.MX6Q with a Samsung NAND flash chip that doesn't support > > sequential reads. > >=20 > > Fixes: 003fe4b9545b ("mtd: rawnand: Support for sequential cache > > reads") > > Cc: stable@vger.kernel.org > > Signed-off-by: Rouven Czerwinski =20 >=20 > Thanks for this. It works as expected for my Toshiba chip, obviously > because it doesn't use ONFI or JEDEC. >=20 > Unfortunately, my Micron chip does use ONFI, and it sets the cached- > read-supported bit. It then fails when reading afterwords: >=20 > kernel: ONFI_OPT_CMD_READ_CACHE # debug added by me > kernel: nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xdc > kernel: nand: Micron MT29F4G08ABAFAWP > kernel: nand: 512 MiB, SLC, erase size: 256 KiB, page size: 4096, OOB > size: 256 > kernel: nand: continued read supported # debug added by me > kernel: Bad block table found at page 131008, version 0x01 > kernel: Bad block table found at page 130944, version 0x01 > kernel: 2 fixed-partitions partitions found on MTD device gpmi-nand > kernel: Creating 2 MTD partitions on "gpmi-nand": > kernel: 0x000000000000-0x000000800000 : "boot" > kernel: 0x000000800000-0x000020000000 : "ubi" > kernel: gpmi-nand 1806000.nand-controller: driver registered. >=20 > ... >=20 > kernel: ubi0: default fastmap pool size: 100 > kernel: ubi0: default fastmap WL pool size: 50 > kernel: ubi0: attaching mtd1 > kernel: ubi0: scanning is finished > kernel: ubi0: attached mtd1 (name "ubi", size 504 MiB) > kernel: ubi0: PEB size: 262144 bytes (256 KiB), LEB size: 253952 bytes > kernel: ubi0: min./max. I/O unit sizes: 4096/4096, sub-page size 4096 > kernel: ubi0: VID header offset: 4096 (aligned 4096), data offset: 8192 > kernel: ubi0: good PEBs: 2012, bad PEBs: 4, corrupted PEBs: 0 > kernel: ubi0: user volume: 9, internal volumes: 1, max. volumes count: > 128 > kernel: ubi0: max/mean erase counter: 4/2, WL threshold: 4096, image > sequence number: 1431497221 > kernel: ubi0: available PEBs: 12, total reserved PEBs: 2000, PEBs > reserved for bad PEB handling: 36 > kernel: block ubiblock0_4: created from ubi0:4(rootfs.a) > kernel: ubi0: background thread "ubi_bgt0d" started, PID 36 > kernel: block ubiblock0_6: created from ubi0:6(appfs.a) > kernel: block ubiblock0_7: created from ubi0:7(appfs.b) >=20 > ... >=20 > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:ed1] > kernel: SQUASHFS error: Unable to read directory block [4b6f15e:125] > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:1dae] > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:ed1] > (d-sysctl)[55]: systemd-sysctl.service: Failed to set up credentials: > Protocol error > kernel: SQUASHFS error: Unable to read directory block [4b73162:14f0] > kernel: SQUASHFS error: Unable to read directory block [4b6f15e:838] > systemd[1]: Starting Create Static Device Nodes in /dev... > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:ed1] > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:ed1] > kernel: SQUASHFS error: Unable to read directory block [4b6f15e:838] > kernel: SQUASHFS error: Unable to read directory block [4b6d15c:1dae] > kernel: SQUASHFS error: Unable to read directory block [4b6f15e:125] >=20 > I've briefly tried adding some error info the the squashfs error > messages, but it looks like it's getting bad data. I.e. one failure a > sanity check of `dir_count`: >=20 > if (dir_count > SQUASHFS_DIR_COUNT) > goto data_error; >=20 > It fails with `dir_count` being 1952803684 ... >=20 > So is this a case of wrong/bad timings? >=20 > Miquel: > I can tell from the code, that the READCACHESEQ operations are followed > by NAND_OP_WAIT_RDY(tR_max, tRR_min). From the Micron datasheet[0], it > should be NAND_OP_WAIT_RDY(tRCBSY_max, tRR_min), where tRCBSY is > defined to be between 3 and 25 =C2=B5s. I found a place in the ONFI spec states taht tRCBSY_max should be between 3 and tR_max, so indeed we should be fine on that regard. However, I asked myself whether we could have issues when crossing boundaries. Block boundaries should be fine, however your device does not support crossing plane boundaries, as bit 4 ("read cache supported") of byte 114 ("Multi-plane operation attributes") in the memory organization block of the parameter page is not set (the value of the byte should be 0x0E if I get it right. Anyway, our main issue here does not seem related to the boundaries. It does not seem to be explicitly marked anywhere else but on the front page: Advanced command set =E2=80=93 Program page cache mode (4) =E2=80=93 Read page cache mode (4) =E2=80=93 Two-plane commands (4) (4) These commands supported only with ECC disabled. Read page cache mode without ECC makes the feature pretty useless IMHO. Bean, Domenico, how do we know which devices allow ECC correction during sequential page reads and which don't? Is there a (vendor?) bit somewhere in the parameter page for that? Do we have any way to know besides a list of devices allowing that? If so, can you provide one with a few IDs?=20 Thanks, Miqu=C3=A8l