From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED78CE80A99 for ; Wed, 27 Sep 2023 06:45:35 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=JCUyZ35Y; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RwRvL1z2wz2ynB for ; Wed, 27 Sep 2023 16:45:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=JCUyZ35Y; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.194; helo=relay2-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RwRtH4Zyyz3cCl for ; Wed, 27 Sep 2023 16:44:36 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0A25640003; Wed, 27 Sep 2023 06:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w55e/rZZu6aBcdMenyM29aj/jZfbSewfoXt20wM3HE=; b=JCUyZ35Y34m8eNV5AYUbxw8m418hEdMFBN2Js5CxabrdUoH7FIHrMeVA293I3eI6POnkU7 DOAJW5vbmOydtDsh2MYc9iZd0PXdjP+UQ5gHmA2d6ZVsidSIVAizBp+R+hNTQG0MJipQi2 836XR2K6kykJDIY47I1Gc/W4BvuJI+oI8ibjeJfXMC91DmO1VHuP4eGlIjK698yaGAZ5GR zaawiGzo+wm2SPwNVqJzmrcnjT2Wr7cO111NYEKQh15D3bCLgfMm4l7KMIbAFhcIk9DDRQ ofpwEg5drYgz0WeN/2YEV6axZZXnR+EaG0eh1eHjw0NCTJFih0gujpVEfk8WCA== Date: Wed, 27 Sep 2023 08:44:24 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 07/40] soc/fsl: cpm: tsa: Convert to platform remove callback returning void Message-ID: <20230927084424.177d2764@bootlin.com> In-Reply-To: <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Li Yang , kernel@pengutronix.de, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Uwe, On Mon, 25 Sep 2023 11:54:58 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/soc/fsl/qe/tsa.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c > index 3646153117b3..3f9981335590 100644 > --- a/drivers/soc/fsl/qe/tsa.c > +++ b/drivers/soc/fsl/qe/tsa.c > @@ -706,7 +706,7 @@ static int tsa_probe(struct platform_device *pdev) > return 0; > } > > -static int tsa_remove(struct platform_device *pdev) > +static void tsa_remove(struct platform_device *pdev) > { > struct tsa *tsa = platform_get_drvdata(pdev); > int i; > @@ -729,7 +729,6 @@ static int tsa_remove(struct platform_device *pdev) > clk_put(tsa->tdm[i].l1rclk_clk); > } > } > - return 0; > } > > static const struct of_device_id tsa_id_table[] = { > @@ -744,7 +743,7 @@ static struct platform_driver tsa_driver = { > .of_match_table = of_match_ptr(tsa_id_table), > }, > .probe = tsa_probe, > - .remove = tsa_remove, > + .remove_new = tsa_remove, > }; > module_platform_driver(tsa_driver); > Acked-by: Herve Codina Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 429C4E80A93 for ; Wed, 27 Sep 2023 06:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r0uePUxWTLafC1atBvfKp/3hBlUyuINLXWAEN+Gf62E=; b=kpJdzs9oTciD2L 31RZOKVTfcgKDAah7sDGb+wAaLfIdd65HVp3+OUF856eMkG5ELx3mpwp+MJBhaZLvRzUz3Ie4pRQ/ sZxGtxQgXc07BV1aS/JJE2nPqHtikwa7ZeCIkd4mcQNCzuUKHNN2K6sWx3urPOfcVy0f9E1+36MIX 2+Ze3okBmWEqh2e0i2rjVr7IB1AtRCNdI7K0ydB5bEi1Y5OiCnv6nT14U1pmZBwN8DzBF5GwcT5/s zlfUUWyJFSHMI62wnUQy3Q8vzrmZjEwYaaXfhRWlE/BtafQfqpAEZW5gXcl4qW6A+AW3wLl235mov PNkswyVIH6MZk0peoeyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlOHk-0007EG-0S; Wed, 27 Sep 2023 06:44:36 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlOHg-0007DF-1Z for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 06:44:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0A25640003; Wed, 27 Sep 2023 06:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w55e/rZZu6aBcdMenyM29aj/jZfbSewfoXt20wM3HE=; b=JCUyZ35Y34m8eNV5AYUbxw8m418hEdMFBN2Js5CxabrdUoH7FIHrMeVA293I3eI6POnkU7 DOAJW5vbmOydtDsh2MYc9iZd0PXdjP+UQ5gHmA2d6ZVsidSIVAizBp+R+hNTQG0MJipQi2 836XR2K6kykJDIY47I1Gc/W4BvuJI+oI8ibjeJfXMC91DmO1VHuP4eGlIjK698yaGAZ5GR zaawiGzo+wm2SPwNVqJzmrcnjT2Wr7cO111NYEKQh15D3bCLgfMm4l7KMIbAFhcIk9DDRQ ofpwEg5drYgz0WeN/2YEV6axZZXnR+EaG0eh1eHjw0NCTJFih0gujpVEfk8WCA== Date: Wed, 27 Sep 2023 08:44:24 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Qiang Zhao , Li Yang , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/40] soc/fsl: cpm: tsa: Convert to platform remove callback returning void Message-ID: <20230927084424.177d2764@bootlin.com> In-Reply-To: <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_234432_692199_9676E78E X-CRM114-Status: GOOD ( 23.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKT24gTW9uLCAyNSBTZXAgMjAyMyAxMTo1NDo1OCArMDIwMApVd2UgS2xlaW5lLUvD tm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCj4gVGhlIC5yZW1v dmUoKSBjYWxsYmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBpbnQgd2hpY2gg bWFrZXMKPiBtYW55IGRyaXZlciBhdXRob3JzIHdyb25nbHkgYXNzdW1lIGl0J3MgcG9zc2libGUg dG8gZG8gZXJyb3IgaGFuZGxpbmcgYnkKPiByZXR1cm5pbmcgYW4gZXJyb3IgY29kZS4gSG93ZXZl ciB0aGUgdmFsdWUgcmV0dXJuZWQgaXMgaWdub3JlZCAoYXBhcnQKPiBmcm9tIGVtaXR0aW5nIGEg d2FybmluZykgYW5kIHRoaXMgdHlwaWNhbGx5IHJlc3VsdHMgaW4gcmVzb3VyY2UgbGVha3MuCj4g VG8gaW1wcm92ZSBoZXJlIHRoZXJlIGlzIGEgcXVlc3QgdG8gbWFrZSB0aGUgcmVtb3ZlIGNhbGxi YWNrIHJldHVybgo+IHZvaWQuIEluIHRoZSBmaXJzdCBzdGVwIG9mIHRoaXMgcXVlc3QgYWxsIGRy aXZlcnMgYXJlIGNvbnZlcnRlZCB0bwo+IC5yZW1vdmVfbmV3KCkgd2hpY2ggYWxyZWFkeSByZXR1 cm5zIHZvaWQuIEV2ZW50dWFsbHkgYWZ0ZXIgYWxsIGRyaXZlcnMKPiBhcmUgY29udmVydGVkLCAu cmVtb3ZlX25ldygpIHdpbGwgYmUgcmVuYW1lZCB0byAucmVtb3ZlKCkuCj4gCj4gVHJpdmlhbGx5 IGNvbnZlcnQgdGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJl bW92ZQo+IGNhbGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXgu ZGU+Cj4gLS0tCj4gIGRyaXZlcnMvc29jL2ZzbC9xZS90c2EuYyB8IDUgKystLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9zb2MvZnNsL3FlL3RzYS5jIGIvZHJpdmVycy9zb2MvZnNsL3FlL3RzYS5jCj4g aW5kZXggMzY0NjE1MzExN2IzLi4zZjk5ODEzMzU1OTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9z b2MvZnNsL3FlL3RzYS5jCj4gKysrIGIvZHJpdmVycy9zb2MvZnNsL3FlL3RzYS5jCj4gQEAgLTcw Niw3ICs3MDYsNyBAQCBzdGF0aWMgaW50IHRzYV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgdHNhX3JlbW92ZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICtzdGF0aWMgdm9pZCB0c2FfcmVtb3ZlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIHsKPiAgCXN0cnVjdCB0c2EgKnRzYSA9IHBs YXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ICAJaW50IGk7Cj4gQEAgLTcyOSw3ICs3MjksNiBA QCBzdGF0aWMgaW50IHRzYV9yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAg CQkJY2xrX3B1dCh0c2EtPnRkbVtpXS5sMXJjbGtfY2xrKTsKPiAgCQl9Cj4gIAl9Cj4gLQlyZXR1 cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgdHNhX2lk X3RhYmxlW10gPSB7Cj4gQEAgLTc0NCw3ICs3NDMsNyBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3Jt X2RyaXZlciB0c2FfZHJpdmVyID0gewo+ICAJCS5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX3B0 cih0c2FfaWRfdGFibGUpLAo+ICAJfSwKPiAgCS5wcm9iZSA9IHRzYV9wcm9iZSwKPiAtCS5yZW1v dmUgPSB0c2FfcmVtb3ZlLAo+ICsJLnJlbW92ZV9uZXcgPSB0c2FfcmVtb3ZlLAo+ICB9Owo+ICBt b2R1bGVfcGxhdGZvcm1fZHJpdmVyKHRzYV9kcml2ZXIpOwo+ICAKCkFja2VkLWJ5OiBIZXJ2ZSBD b2RpbmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4KCkJlc3QgcmVnYXJkcywKSGVydsOpCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F04BE80A99 for ; Wed, 27 Sep 2023 06:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjI0Gow (ORCPT ); Wed, 27 Sep 2023 02:44:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjI0Goa (ORCPT ); Wed, 27 Sep 2023 02:44:30 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3F7BEB for ; Tue, 26 Sep 2023 23:44:28 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0A25640003; Wed, 27 Sep 2023 06:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w55e/rZZu6aBcdMenyM29aj/jZfbSewfoXt20wM3HE=; b=JCUyZ35Y34m8eNV5AYUbxw8m418hEdMFBN2Js5CxabrdUoH7FIHrMeVA293I3eI6POnkU7 DOAJW5vbmOydtDsh2MYc9iZd0PXdjP+UQ5gHmA2d6ZVsidSIVAizBp+R+hNTQG0MJipQi2 836XR2K6kykJDIY47I1Gc/W4BvuJI+oI8ibjeJfXMC91DmO1VHuP4eGlIjK698yaGAZ5GR zaawiGzo+wm2SPwNVqJzmrcnjT2Wr7cO111NYEKQh15D3bCLgfMm4l7KMIbAFhcIk9DDRQ ofpwEg5drYgz0WeN/2YEV6axZZXnR+EaG0eh1eHjw0NCTJFih0gujpVEfk8WCA== Date: Wed, 27 Sep 2023 08:44:24 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Qiang Zhao , Li Yang , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 07/40] soc/fsl: cpm: tsa: Convert to platform remove callback returning void Message-ID: <20230927084424.177d2764@bootlin.com> In-Reply-To: <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-8-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uwe, On Mon, 25 Sep 2023 11:54:58 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/soc/fsl/qe/tsa.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c > index 3646153117b3..3f9981335590 100644 > --- a/drivers/soc/fsl/qe/tsa.c > +++ b/drivers/soc/fsl/qe/tsa.c > @@ -706,7 +706,7 @@ static int tsa_probe(struct platform_device *pdev) > return 0; > } > > -static int tsa_remove(struct platform_device *pdev) > +static void tsa_remove(struct platform_device *pdev) > { > struct tsa *tsa = platform_get_drvdata(pdev); > int i; > @@ -729,7 +729,6 @@ static int tsa_remove(struct platform_device *pdev) > clk_put(tsa->tdm[i].l1rclk_clk); > } > } > - return 0; > } > > static const struct of_device_id tsa_id_table[] = { > @@ -744,7 +743,7 @@ static struct platform_driver tsa_driver = { > .of_match_table = of_match_ptr(tsa_id_table), > }, > .probe = tsa_probe, > - .remove = tsa_remove, > + .remove_new = tsa_remove, > }; > module_platform_driver(tsa_driver); > Acked-by: Herve Codina Best regards, Hervé