From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EE48E80A93 for ; Wed, 27 Sep 2023 06:46:24 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=XRukPAck; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RwRwG4qw4z3cRN for ; Wed, 27 Sep 2023 16:46:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=XRukPAck; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::221; helo=relay1-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RwRtg3gCVz3cNj for ; Wed, 27 Sep 2023 16:44:58 +1000 (AEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 97F66240005; Wed, 27 Sep 2023 06:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkiMQS0h03kR9XwkdIs5uj8Y1YzwHNmKB+9PoQ4lSL0=; b=XRukPAckv6xotB3jVxFy4667OmM9aYny27MOBlx/BTcOP+fM4zVksB73m1skzTs3LuEPpg 28sKZ9s7L/Oqt1lwd7bnXWCDqokDgIuJgssp5DI1MCsncP8PLw07fdqYpQURB8PlIIaM3D 93bLk2K43GorkeGCMIk8B+OCDjV8tBPUf30PS4b4LpM1wn5+YvEI05vXKqtR6EFOczywI5 xrHINcV0dOenfCZ2+TfOVVJblcbuVpw9L0kd6HO7Om4Fz8l3QxHEMsyT9NuuX2nhyIyx2d 2p9J4fl9lVT/dZiNwsgHxJAR6mxaQrqmovXmMDr3X9tHCbxioEYFBz6WzsR54A== Date: Wed, 27 Sep 2023 08:44:46 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove callback returning void Message-ID: <20230927084446.66affc74@bootlin.com> In-Reply-To: <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Li Yang , kernel@pengutronix.de, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 25 Sep 2023 11:54:57 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/soc/fsl/qe/qmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c > index b3c292c9a14e..92ec76c03965 100644 > --- a/drivers/soc/fsl/qe/qmc.c > +++ b/drivers/soc/fsl/qe/qmc.c > @@ -1415,7 +1415,7 @@ static int qmc_probe(struct platform_device *pdev) > return ret; > } > > -static int qmc_remove(struct platform_device *pdev) > +static void qmc_remove(struct platform_device *pdev) > { > struct qmc *qmc = platform_get_drvdata(pdev); > > @@ -1427,8 +1427,6 @@ static int qmc_remove(struct platform_device *pdev) > > /* Disconnect the serial from TSA */ > tsa_serial_disconnect(qmc->tsa_serial); > - > - return 0; > } > > static const struct of_device_id qmc_id_table[] = { > @@ -1443,7 +1441,7 @@ static struct platform_driver qmc_driver = { > .of_match_table = of_match_ptr(qmc_id_table), > }, > .probe = qmc_probe, > - .remove = qmc_remove, > + .remove_new = qmc_remove, > }; > module_platform_driver(qmc_driver); > Acked-by: Herve Codina Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 816F5E80A93 for ; Wed, 27 Sep 2023 06:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jmGQP+vFFrAPCX+jTekjGdGUQ1oGgNdt81Jpeurld2Q=; b=KKydDozCTfuc7K nKdf98Oczpt5vtegOB0i3wMrkzyAhpEhgJ4OIPQFIbJKX7LkInlUbXRVHNOGIJVsQpBdfSwWnRuiy ZqRSnmPt7egK76lz4zGP90DHXP7IXNaLbjQwQ0kEBrwT71GRTU1pW5fDS6E6ty/D75lfwYsPcmdMR Vq63dk27y1ui/+oIg/LxC/2iCgbamHdTJNcRipkT4LrRIH9gJOksGse32uxG2cboHPsDXxwEBxnBn scHxEjSbQsL1Z/Okxd2uEi6fZH9Hm7W4uShYLsGzD1evr6gLYIfahn/DiCP81OIny0k2cCrhET+ld 6YUufz47Pzt7Vg4aIYZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qlOI4-0007HO-2X; Wed, 27 Sep 2023 06:44:56 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qlOI1-0007GG-0I for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2023 06:44:54 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 97F66240005; Wed, 27 Sep 2023 06:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkiMQS0h03kR9XwkdIs5uj8Y1YzwHNmKB+9PoQ4lSL0=; b=XRukPAckv6xotB3jVxFy4667OmM9aYny27MOBlx/BTcOP+fM4zVksB73m1skzTs3LuEPpg 28sKZ9s7L/Oqt1lwd7bnXWCDqokDgIuJgssp5DI1MCsncP8PLw07fdqYpQURB8PlIIaM3D 93bLk2K43GorkeGCMIk8B+OCDjV8tBPUf30PS4b4LpM1wn5+YvEI05vXKqtR6EFOczywI5 xrHINcV0dOenfCZ2+TfOVVJblcbuVpw9L0kd6HO7Om4Fz8l3QxHEMsyT9NuuX2nhyIyx2d 2p9J4fl9lVT/dZiNwsgHxJAR6mxaQrqmovXmMDr3X9tHCbxioEYFBz6WzsR54A== Date: Wed, 27 Sep 2023 08:44:46 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Qiang Zhao , Li Yang , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove callback returning void Message-ID: <20230927084446.66affc74@bootlin.com> In-Reply-To: <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230926_234453_269674_636EE11D X-CRM114-Status: GOOD ( 24.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNSBTZXAgMjAyMyAxMTo1NDo1NyArMDIwMApVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKCj4gVGhlIC5yZW1vdmUoKSBjYWxs YmFjayBmb3IgYSBwbGF0Zm9ybSBkcml2ZXIgcmV0dXJucyBhbiBpbnQgd2hpY2ggbWFrZXMKPiBt YW55IGRyaXZlciBhdXRob3JzIHdyb25nbHkgYXNzdW1lIGl0J3MgcG9zc2libGUgdG8gZG8gZXJy b3IgaGFuZGxpbmcgYnkKPiByZXR1cm5pbmcgYW4gZXJyb3IgY29kZS4gSG93ZXZlciB0aGUgdmFs dWUgcmV0dXJuZWQgaXMgaWdub3JlZCAoYXBhcnQKPiBmcm9tIGVtaXR0aW5nIGEgd2FybmluZykg YW5kIHRoaXMgdHlwaWNhbGx5IHJlc3VsdHMgaW4gcmVzb3VyY2UgbGVha3MuCj4gVG8gaW1wcm92 ZSBoZXJlIHRoZXJlIGlzIGEgcXVlc3QgdG8gbWFrZSB0aGUgcmVtb3ZlIGNhbGxiYWNrIHJldHVy bgo+IHZvaWQuIEluIHRoZSBmaXJzdCBzdGVwIG9mIHRoaXMgcXVlc3QgYWxsIGRyaXZlcnMgYXJl IGNvbnZlcnRlZCB0bwo+IC5yZW1vdmVfbmV3KCkgd2hpY2ggYWxyZWFkeSByZXR1cm5zIHZvaWQu IEV2ZW50dWFsbHkgYWZ0ZXIgYWxsIGRyaXZlcnMKPiBhcmUgY29udmVydGVkLCAucmVtb3ZlX25l dygpIHdpbGwgYmUgcmVuYW1lZCB0byAucmVtb3ZlKCkuCj4gCj4gVHJpdmlhbGx5IGNvbnZlcnQg dGhpcyBkcml2ZXIgZnJvbSBhbHdheXMgcmV0dXJuaW5nIHplcm8gaW4gdGhlIHJlbW92ZQo+IGNh bGxiYWNrIHRvIHRoZSB2b2lkIHJldHVybmluZyB2YXJpYW50Lgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4gLS0t Cj4gIGRyaXZlcnMvc29jL2ZzbC9xZS9xbWMuYyB8IDYgKystLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvc29jL2ZzbC9xZS9xbWMuYyBiL2RyaXZlcnMvc29jL2ZzbC9xZS9xbWMuYwo+IGluZGV4IGIz YzI5MmM5YTE0ZS4uOTJlYzc2YzAzOTY1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvc29jL2ZzbC9x ZS9xbWMuYwo+ICsrKyBiL2RyaXZlcnMvc29jL2ZzbC9xZS9xbWMuYwo+IEBAIC0xNDE1LDcgKzE0 MTUsNyBAQCBzdGF0aWMgaW50IHFtY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAtc3RhdGljIGludCBxbWNfcmVtb3ZlKHN0cnVj dCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gK3N0YXRpYyB2b2lkIHFtY19yZW1vdmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgewo+ICAJc3RydWN0IHFtYyAqcW1jID0gcGxhdGZv cm1fZ2V0X2RydmRhdGEocGRldik7Cj4gIAo+IEBAIC0xNDI3LDggKzE0MjcsNiBAQCBzdGF0aWMg aW50IHFtY19yZW1vdmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCj4gIAkvKiBE aXNjb25uZWN0IHRoZSBzZXJpYWwgZnJvbSBUU0EgKi8KPiAgCXRzYV9zZXJpYWxfZGlzY29ubmVj dChxbWMtPnRzYV9zZXJpYWwpOwo+IC0KPiAtCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMg Y29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBxbWNfaWRfdGFibGVbXSA9IHsKPiBAQCAtMTQ0Myw3 ICsxNDQxLDcgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgcW1jX2RyaXZlciA9IHsK PiAgCQkub2ZfbWF0Y2hfdGFibGUgPSBvZl9tYXRjaF9wdHIocW1jX2lkX3RhYmxlKSwKPiAgCX0s Cj4gIAkucHJvYmUgPSBxbWNfcHJvYmUsCj4gLQkucmVtb3ZlID0gcW1jX3JlbW92ZSwKPiArCS5y ZW1vdmVfbmV3ID0gcW1jX3JlbW92ZSwKPiAgfTsKPiAgbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihx bWNfZHJpdmVyKTsKPiAgCgpBY2tlZC1ieTogSGVydmUgQ29kaW5hIDxoZXJ2ZS5jb2RpbmFAYm9v dGxpbi5jb20+CgpCZXN0IHJlZ2FyZHMsCkhlcnbDqQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D7CE80A99 for ; Wed, 27 Sep 2023 06:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjI0GpJ (ORCPT ); Wed, 27 Sep 2023 02:45:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjI0Gow (ORCPT ); Wed, 27 Sep 2023 02:44:52 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F17DA3 for ; Tue, 26 Sep 2023 23:44:50 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 97F66240005; Wed, 27 Sep 2023 06:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695797089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkiMQS0h03kR9XwkdIs5uj8Y1YzwHNmKB+9PoQ4lSL0=; b=XRukPAckv6xotB3jVxFy4667OmM9aYny27MOBlx/BTcOP+fM4zVksB73m1skzTs3LuEPpg 28sKZ9s7L/Oqt1lwd7bnXWCDqokDgIuJgssp5DI1MCsncP8PLw07fdqYpQURB8PlIIaM3D 93bLk2K43GorkeGCMIk8B+OCDjV8tBPUf30PS4b4LpM1wn5+YvEI05vXKqtR6EFOczywI5 xrHINcV0dOenfCZ2+TfOVVJblcbuVpw9L0kd6HO7Om4Fz8l3QxHEMsyT9NuuX2nhyIyx2d 2p9J4fl9lVT/dZiNwsgHxJAR6mxaQrqmovXmMDr3X9tHCbxioEYFBz6WzsR54A== Date: Wed, 27 Sep 2023 08:44:46 +0200 From: Herve Codina To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Qiang Zhao , Li Yang , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 06/40] soc/fsl: cpm: qmc: Convert to platform remove callback returning void Message-ID: <20230927084446.66affc74@bootlin.com> In-Reply-To: <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-7-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Sep 2023 11:54:57 +0200 Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- > drivers/soc/fsl/qe/qmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c > index b3c292c9a14e..92ec76c03965 100644 > --- a/drivers/soc/fsl/qe/qmc.c > +++ b/drivers/soc/fsl/qe/qmc.c > @@ -1415,7 +1415,7 @@ static int qmc_probe(struct platform_device *pdev) > return ret; > } > > -static int qmc_remove(struct platform_device *pdev) > +static void qmc_remove(struct platform_device *pdev) > { > struct qmc *qmc = platform_get_drvdata(pdev); > > @@ -1427,8 +1427,6 @@ static int qmc_remove(struct platform_device *pdev) > > /* Disconnect the serial from TSA */ > tsa_serial_disconnect(qmc->tsa_serial); > - > - return 0; > } > > static const struct of_device_id qmc_id_table[] = { > @@ -1443,7 +1441,7 @@ static struct platform_driver qmc_driver = { > .of_match_table = of_match_ptr(qmc_id_table), > }, > .probe = qmc_probe, > - .remove = qmc_remove, > + .remove_new = qmc_remove, > }; > module_platform_driver(qmc_driver); > Acked-by: Herve Codina Best regards, Hervé