From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C781E7735F for ; Sat, 30 Sep 2023 08:08:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E112EEBF; Sat, 30 Sep 2023 10:07:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E112EEBF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696061295; bh=7ofPMqqF7hKZ/KNvv5khNQVnRR72QWJfnsa0KqMkttc=; h=Date:From:To:CC:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jEuu/BMgIXGGHtj/uE+jdjJV5ADAnu4OcZHTOg7j/KV/6n96XvNmxCmntSkdQPjJx 3GPlG5E6zhT7QrUm9KszKXZpqd1GudFDTVro8+RCmIaa00SNBCEU6CKShgNentHSrx 6HzCRknokdrkD659hRYEmZ+9aJiM5UzIqxARveug= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BDC67F80604; Sat, 30 Sep 2023 10:06:45 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0DBB8F80604; Sat, 30 Sep 2023 10:06:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E43DAF8016A; Wed, 27 Sep 2023 11:47:07 +0200 (CEST) Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by alsa1.perex.cz (Postfix) with ESMTP id BE76AF800AA for ; Wed, 27 Sep 2023 11:46:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BE76AF800AA X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.46 by mg.richtek.com with MailGates ESMTPS Server V6.0(1978120:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Wed, 27 Sep 2023 17:46:38 +0800 (CST) Received: from ex3.rt.l (192.168.10.46) by ex3.rt.l (192.168.10.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Wed, 27 Sep 2023 17:46:37 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex3.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Wed, 27 Sep 2023 17:46:37 +0800 Date: Wed, 27 Sep 2023 17:46:37 +0800 From: ChiYuan Huang To: Mark Brown CC: Jaroslav Kysela , Takashi Iwai , Allen Lin , , Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection Message-ID: <20230927094637.GA25905@linuxcarl2.richtek.com> References: <1695780376-32301-1-git-send-email-cy_huang@richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-MailFrom: prvs=1631658C43=cy_huang@richtek.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: ZXDVMG3UWFXZFJCSRIU2XYPX46PZYF7A X-Message-ID-Hash: ZXDVMG3UWFXZFJCSRIU2XYPX46PZYF7A X-Mailman-Approved-At: Sat, 30 Sep 2023 08:06:34 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Sep 27, 2023 at 11:13:22AM +0200, Mark Brown wrote: > On Wed, Sep 27, 2023 at 10:06:16AM +0800, cy_huang@richtek.com wrote: > > > Since rtq9128 can support 4 channel I2S mode audio data, there are two > > dedicated data input pins for CH12 and CH34. But in TDM mode, input > > source was already drived on one data pin for multiple data slots. In > > this case, only one input source is needed for TDM mode. > > > > This patch is to add the data source pin selection for CH12 and CH34. > > > + SOC_ENUM("CH12 TDM Data Select", rtq9128_ch12_tdm_data_select_enum), > > + SOC_ENUM("CH34 TDM Data Select", rtq9128_ch34_tdm_data_select_enum), > > Is this something that's going to be changing dynamically at runtime or > should this be a device property that's set either by firmware or when > we're doing the TDM setup? This sounds like something I'd expect to be > fixed by the board design. I may think one case if ASoC platform support multiple data source outputs that share the same bck/lcrk on different data pin. If it can be dynamically adjusted for the scenarios, this will keep the flexibility for the differet platform design. Like as in most codecs, there could be mux design that can use to choose the dedicated data input. If we fixed in device property, the flexibility will be missing. It's our original thought to have the control for the data select mutiplexer.