From: Abdel Alkuor <alkuor@gmail.com>
To: heikki.krogerus@linux.intel.com,
krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: [PATCH v7 06/14] USB: typec: tps6598x: Clear dead battery flag
Date: Wed, 27 Sep 2023 13:53:40 -0400 [thread overview]
Message-ID: <20230927175348.18041-7-alkuor@gmail.com> (raw)
In-Reply-To: <20230927175348.18041-1-alkuor@gmail.com>
From: Abdel Alkuor <abdelalkuor@geotab.com>
Dead battery flag must be cleared after switching tps25750 to APP mode
so the PD controller becomes fully functional.
Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
---
Changes in v7:
- Add driver name to commit subject
Changes in v6:
- No changes
Changes in v5:
- Incorporating tps25750 into tps6598x driver
drivers/usb/typec/tipd/core.c | 16 ++++++++++++++++
drivers/usb/typec/tipd/tps6598x.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index cd22635460d3..faeee2ffc99c 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -946,6 +946,22 @@ static int tps25750_apply_patch(struct tps6598x *tps)
} while (ret != TPS_MODE_APP);
+ /*
+ * The dead battery flag may be triggered when the controller
+ * port is connected to a device that can source power and
+ * attempts to power up both the controller and the board it is on.
+ * To restore controller functionality, it is necessary to clear
+ * this flag
+ */
+ if (status & TPS_BOOT_STATUS_DEAD_BATTERY_FLAG) {
+ ret = tps6598x_exec_cmd(tps, "DBfg", 0, NULL, 0, NULL);
+ if (ret) {
+ dev_err(tps->dev,
+ "failed to clear dead battery %d\n", ret);
+ return ret;
+ }
+ }
+
dev_info(tps->dev, "controller switched to \"APP\" mode\n");
return 0;
diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
index a80d0929f3ee..c000170f4547 100644
--- a/drivers/usb/typec/tipd/tps6598x.h
+++ b/drivers/usb/typec/tipd/tps6598x.h
@@ -200,6 +200,7 @@
#define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_B (BIT(2) | BIT(1))
/* BOOT STATUS REG*/
+#define TPS_BOOT_STATUS_DEAD_BATTERY_FLAG BIT(2)
#define TPS_BOOT_STATUS_I2C_EEPROM_PRESENT BIT(3)
#endif /* __TPS6598X_H__ */
--
2.34.1
next prev parent reply other threads:[~2023-09-27 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 17:53 [PATCH v7 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-28 5:37 ` Krzysztof Kozlowski
2023-09-28 8:06 ` Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 02/14] USB: typec: tsp6598x: Add cmd timeout and response delay Abdel Alkuor
2023-09-29 8:52 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 03/14] USB: typec: tps6598x: Add patch mode to tps6598x Abdel Alkuor
2023-09-29 10:11 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 04/14] USB: typec: tps6598x: Load TPS25750 patch bundle Abdel Alkuor
2023-09-29 10:29 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 05/14] USB: typec: tps6598x: Check for EEPROM present Abdel Alkuor
2023-09-27 17:53 ` Abdel Alkuor [this message]
2023-09-27 17:53 ` [PATCH v7 07/14] USB: typec: tps6598x: Apply patch again after power resume Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 08/14] USB: typec: tps6598x: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-29 10:43 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 09/14] USB: typec: tps6598x: Refactor tps6598x port registration Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 10/14] USB: typec: tps6598x: Add port registration for tps25750 Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 11/14] USB: typec: tps6598x: Enable sleep mode " Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 12/14] USB: typec: tps6598x: Add trace for tps25750 irq Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 13/14] USB: typec: tps6598x: Add power status trace for tps25750 Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 14/14] USB: typec: tps6598x: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927175348.18041-7-alkuor@gmail.com \
--to=alkuor@gmail.com \
--cc=abdelalkuor@geotab.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.