From: Florian Westphal <fw@strlen.de>
To: kernel test robot <oliver.sang@intel.com>
Cc: Florian Westphal <fw@strlen.de>,
oe-lkp@lists.linux.dev, lkp@intel.com, netdev@vger.kernel.org,
nharold@google.com, lorenzo@google.com, benedictwong@google.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH ipsec-next 2/2] xfrm: policy: replace session decode with flow dissector
Date: Wed, 27 Sep 2023 20:01:29 +0200 [thread overview]
Message-ID: <20230927180129.GD17767@breakpoint.cc> (raw)
In-Reply-To: <202309271628.27fd2187-oliver.sang@intel.com>
kernel test robot <oliver.sang@intel.com> wrote:
> (please refer to attached dmesg/kmsg for entire log/backtrace)
>
>
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202309271628.27fd2187-oliver.sang@intel.com
>
>
> kern :warn : [ 173.147140] ------------[ cut here ]------------
> kern :warn : [ 173.147759] WARNING: CPU: 12 PID: 2260 at net/core/flow_dissector.c:1096 __skb_flow_dissect (net/core/flow_dissector.c:1096 (discriminator 1))
Two options, more 'guess the right netns' in flow dissector:
derive netns from skb->dst->dev.
Or, pass struct net down to xfrm session decode functions.
I'll have a go at option 2 to see how much noise its going to be.
next prev parent reply other threads:[~2023-09-27 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 12:59 [PATCH ipsec-next 0/2] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-09-18 12:59 ` [PATCH ipsec-next 1/2] xfrm: move mark and oif flowi decode into common code Florian Westphal
2023-09-18 12:59 ` [PATCH ipsec-next 2/2] xfrm: policy: replace session decode with flow dissector Florian Westphal
2023-09-27 8:47 ` kernel test robot
2023-09-27 18:01 ` Florian Westphal [this message]
2023-09-21 12:22 ` [PATCH ipsec-next 0/2] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927180129.GD17767@breakpoint.cc \
--to=fw@strlen.de \
--cc=benedictwong@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=lkp@intel.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.