From: kernel test robot <lkp@intel.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC bpf-next v2 12/24] xdp: Add checksum hint
Date: Wed, 27 Sep 2023 21:27:59 +0800 [thread overview]
Message-ID: <202309272156.T4ffutLJ-lkp@intel.com> (raw)
In-Reply-To: <20230927075124.23941-13-larysa.zaremba@intel.com>
Hi Larysa,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Larysa-Zaremba/ice-make-RX-hash-reading-code-more-reusable/20230927-161804
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20230927075124.23941-13-larysa.zaremba%40intel.com
patch subject: [RFC bpf-next v2 12/24] xdp: Add checksum hint
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20230927/202309272156.T4ffutLJ-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230927/202309272156.T4ffutLJ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309272156.T4ffutLJ-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/core/xdp.c:713:17: warning: no previous declaration for 'bpf_xdp_metadata_rx_timestamp' [-Wmissing-declarations]
__bpf_kfunc int bpf_xdp_metadata_rx_timestamp(const struct xdp_md *ctx, u64 *timestamp)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/xdp.c:735:17: warning: no previous declaration for 'bpf_xdp_metadata_rx_hash' [-Wmissing-declarations]
__bpf_kfunc int bpf_xdp_metadata_rx_hash(const struct xdp_md *ctx, u32 *hash,
^~~~~~~~~~~~~~~~~~~~~~~~
net/core/xdp.c:768:17: warning: no previous declaration for 'bpf_xdp_metadata_rx_vlan_tag' [-Wmissing-declarations]
__bpf_kfunc int bpf_xdp_metadata_rx_vlan_tag(const struct xdp_md *ctx,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/core/xdp.c:790:17: warning: no previous declaration for 'bpf_xdp_metadata_rx_csum' [-Wmissing-declarations]
__bpf_kfunc int bpf_xdp_metadata_rx_csum(const struct xdp_md *ctx,
^~~~~~~~~~~~~~~~~~~~~~~~
vim +/bpf_xdp_metadata_rx_csum +790 net/core/xdp.c
698
699 __diag_push();
700 __diag_ignore_all("-Wmissing-prototypes",
701 "Global functions as their definitions will be in vmlinux BTF");
702
703 /**
704 * bpf_xdp_metadata_rx_timestamp - Read XDP frame RX timestamp.
705 * @ctx: XDP context pointer.
706 * @timestamp: Return value pointer.
707 *
708 * Return:
709 * * Returns 0 on success or ``-errno`` on error.
710 * * ``-EOPNOTSUPP`` : means device driver does not implement kfunc
711 * * ``-ENODATA`` : means no RX-timestamp available for this frame
712 */
> 713 __bpf_kfunc int bpf_xdp_metadata_rx_timestamp(const struct xdp_md *ctx, u64 *timestamp)
714 {
715 return -EOPNOTSUPP;
716 }
717
718 /**
719 * bpf_xdp_metadata_rx_hash - Read XDP frame RX hash.
720 * @ctx: XDP context pointer.
721 * @hash: Return value pointer.
722 * @rss_type: Return value pointer for RSS type.
723 *
724 * The RSS hash type (@rss_type) specifies what portion of packet headers NIC
725 * hardware used when calculating RSS hash value. The RSS type can be decoded
726 * via &enum xdp_rss_hash_type either matching on individual L3/L4 bits
727 * ``XDP_RSS_L*`` or by combined traditional *RSS Hashing Types*
728 * ``XDP_RSS_TYPE_L*``.
729 *
730 * Return:
731 * * Returns 0 on success or ``-errno`` on error.
732 * * ``-EOPNOTSUPP`` : means device driver doesn't implement kfunc
733 * * ``-ENODATA`` : means no RX-hash available for this frame
734 */
735 __bpf_kfunc int bpf_xdp_metadata_rx_hash(const struct xdp_md *ctx, u32 *hash,
736 enum xdp_rss_hash_type *rss_type)
737 {
738 return -EOPNOTSUPP;
739 }
740
741 /**
742 * bpf_xdp_metadata_rx_vlan_tag - Get XDP packet outermost VLAN tag
743 * @ctx: XDP context pointer.
744 * @vlan_proto: Destination pointer for VLAN Tag protocol identifier (TPID).
745 * @vlan_tci: Destination pointer for VLAN TCI (VID + DEI + PCP)
746 *
747 * In case of success, ``vlan_proto`` contains *Tag protocol identifier (TPID)*,
748 * usually ``ETH_P_8021Q`` or ``ETH_P_8021AD``, but some networks can use
749 * custom TPIDs. ``vlan_proto`` is stored in **network byte order (BE)**
750 * and should be used as follows:
751 * ``if (vlan_proto == bpf_htons(ETH_P_8021Q)) do_something();``
752 *
753 * ``vlan_tci`` contains the remaining 16 bits of a VLAN tag.
754 * Driver is expected to provide those in **host byte order (usually LE)**,
755 * so the bpf program should not perform byte conversion.
756 * According to 802.1Q standard, *VLAN TCI (Tag control information)*
757 * is a bit field that contains:
758 * *VLAN identifier (VID)* that can be read with ``vlan_tci & 0xfff``,
759 * *Drop eligible indicator (DEI)* - 1 bit,
760 * *Priority code point (PCP)* - 3 bits.
761 * For detailed meaning of DEI and PCP, please refer to other sources.
762 *
763 * Return:
764 * * Returns 0 on success or ``-errno`` on error.
765 * * ``-EOPNOTSUPP`` : device driver doesn't implement kfunc
766 * * ``-ENODATA`` : VLAN tag was not stripped or is not available
767 */
768 __bpf_kfunc int bpf_xdp_metadata_rx_vlan_tag(const struct xdp_md *ctx,
769 __be16 *vlan_proto, u16 *vlan_tci)
770 {
771 return -EOPNOTSUPP;
772 }
773
774 /**
775 * bpf_xdp_metadata_rx_csum - Get checksum status with additional info.
776 * @ctx: XDP context pointer.
777 * @csum_status: Destination for checksum status.
778 * @csum: Destination for complete checksum.
779 *
780 * Status (@csum_status) is a bitfield that informs, what checksum
781 * processing was performed. If ``XDP_CHECKSUM_COMPLETE`` in status is set,
782 * second argument (@csum) contains a checksum, calculated over the entire
783 * packet.
784 *
785 * Return:
786 * * Returns 0 on success or ``-errno`` on error.
787 * * ``-EOPNOTSUPP`` : device driver doesn't implement kfunc
788 * * ``-ENODATA`` : Checksum status is unknown
789 */
> 790 __bpf_kfunc int bpf_xdp_metadata_rx_csum(const struct xdp_md *ctx,
791 enum xdp_csum_status *csum_status,
792 __wsum *csum)
793 {
794 return -EOPNOTSUPP;
795 }
796
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-27 13:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 7:51 [RFC bpf-next v2 00/24] XDP metadata via kfuncs for ice + mlx5 Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 01/24] ice: make RX hash reading code more reusable Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 02/24] ice: make RX HW timestamp " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 03/24] ice: make RX checksum checking " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 04/24] ice: Make ptype internal to descriptor info processing Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 05/24] ice: Introduce ice_xdp_buff Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 06/24] ice: Support HW timestamp hint Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 07/24] ice: Support RX hash XDP hint Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 08/24] ice: Support XDP hints in AF_XDP ZC mode Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 09/24] xdp: Add VLAN tag hint Larysa Zaremba
2023-09-27 12:14 ` kernel test robot
2023-10-03 12:35 ` Jakub Kicinski
2023-10-03 13:09 ` Alexander Lobakin
2023-10-04 18:08 ` Jakub Kicinski
2023-10-05 16:58 ` [xdp-hints] " Alexander Lobakin
2023-10-05 17:16 ` Jakub Kicinski
2023-10-05 17:20 ` David Ahern
2023-10-05 18:06 ` Jakub Kicinski
2023-09-27 7:51 ` [RFC bpf-next v2 10/24] ice: Implement " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 11/24] ice: use VLAN proto from ring packet context in skb path Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 12/24] xdp: Add checksum hint Larysa Zaremba
2023-09-27 13:27 ` kernel test robot [this message]
2023-09-27 7:51 ` [RFC bpf-next v2 13/24] ice: Implement " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 14/24] ice: put XDP meta sources assignment under a static key condition Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 15/24] selftests/bpf: Allow VLAN packets in xdp_hw_metadata Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 16/24] net, xdp: allow metadata > 32 Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 17/24] selftests/bpf: Add flags and new hints to xdp_hw_metadata Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 18/24] veth: Implement VLAN tag and checksum XDP hint Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 19/24] net: make vlan_get_tag() return -ENODATA instead of -EINVAL Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 20/24] selftests/bpf: Use AF_INET for TX in xdp_metadata Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 21/24] selftests/bpf: Check VLAN tag and proto " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 22/24] selftests/bpf: check checksum state " Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 23/24] mlx5: implement VLAN tag XDP hint Larysa Zaremba
2023-09-27 7:51 ` [RFC bpf-next v2 24/24] mlx5: implement RX checksum " Larysa Zaremba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309272156.T4ffutLJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=larysa.zaremba@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.