From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andersson@kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, jun.li@nxp.com,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v3 2/2] dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required
Date: Thu, 28 Sep 2023 18:04:42 +0100 [thread overview]
Message-ID: <20230928-machine-pushcart-6e68b11afc7c@spud> (raw)
In-Reply-To: <20230927123511.45085-2-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On Wed, Sep 27, 2023 at 09:35:11AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is
> no mode-switch, only an orientation switch.
>
> Make the 'mode-switch' property a non-required one.
There seem to be very few compatibles in this file, so I guess
everything uses the generic compatible. I'm not expecting you to know
why it's like this, but should we add a compatible for this particular
mux & only relax the requirement for it specifically?
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v2:
> - Newly introduced.
>
> Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> index b61dcf8b4aad..d3b2b666ec2a 100644
> --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> @@ -51,7 +51,6 @@ required:
> - compatible
> - enable-gpios
> - select-gpios
> - - mode-switch
> - orientation-switch
> - port
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-09-28 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 12:35 [PATCH v3 1/2] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 Fabio Estevam
2023-09-27 12:35 ` [PATCH v3 2/2] dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required Fabio Estevam
2023-09-28 17:04 ` Conor Dooley [this message]
2023-09-29 18:41 ` Fabio Estevam
2023-10-09 17:36 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928-machine-pushcart-6e68b11afc7c@spud \
--to=conor@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.