From: Yuanhe Shu <xiangzao@linux.alibaba.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org,
Yuanhe Shu <xiangzao@linux.alibaba.com>,
Xingrui Yi <yixingrui@linux.alibaba.com>
Subject: [PATCH 4/5] pstore: remove the module parameter "backend"
Date: Thu, 28 Sep 2023 10:42:43 +0800 [thread overview]
Message-ID: <20230928024244.257687-5-xiangzao@linux.alibaba.com> (raw)
In-Reply-To: <20230928024244.257687-1-xiangzao@linux.alibaba.com>
Since all enabled backends have corresponding subdir in
/sys/fs/pstore, and the logic of finding unexpected is
changed by using psinfo_list rather than parameter backend,
it is not necessary to retain the parameter backend.
Remove the unnecessary module parameter "backend".
Signed-off-by: Xingrui Yi <yixingrui@linux.alibaba.com>
Signed-off-by: Yuanhe Shu <xiangzao@linux.alibaba.com>
---
fs/pstore/platform.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index d576ee48527c..90c33c1ca39f 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -77,10 +77,6 @@ static DECLARE_WORK(pstore_work, pstore_dowork);
DEFINE_MUTEX(psback_lock);
struct pstore_backends *psback;
-static char *backend;
-module_param(backend, charp, 0444);
-MODULE_PARM_DESC(backend, "specific backend to use");
-
static char *compress =
#ifdef CONFIG_PSTORE_COMPRESS_DEFAULT
CONFIG_PSTORE_COMPRESS_DEFAULT;
@@ -675,12 +671,6 @@ int pstore_register(struct pstore_info *psi)
/* Start watching for new records, if desired. */
pstore_timer_kick();
- /*
- * Update the module parameter backend, so it is visible
- * through /sys/module/pstore/parameters/backend
- */
- backend = kstrdup(psi->name, GFP_KERNEL);
-
pr_info("Registered %s as persistent store backend\n", psi->name);
mutex_unlock(&psback_lock);
--
2.39.3
next prev parent reply other threads:[~2023-09-28 2:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 2:42 [PATCH 0/5] pstore: add tty frontend and multi-backend Yuanhe Shu
2023-09-28 2:42 ` [PATCH 1/5] pstore: add tty frontend Yuanhe Shu
2023-09-28 6:43 ` Greg KH
2023-09-28 2:42 ` [PATCH 2/5] pstore: add multi-backends support Yuanhe Shu
2023-09-28 2:42 ` [PATCH 3/5] pstore: add subdirs for multi-backends Yuanhe Shu
2023-09-28 2:42 ` Yuanhe Shu [this message]
2023-09-28 2:42 ` [PATCH 5/5] tools/pstore: update pstore selftests Yuanhe Shu
2023-09-29 3:49 ` [PATCH 0/5] pstore: add tty frontend and multi-backend Kees Cook
2023-09-29 5:47 ` Greg KH
2023-11-24 21:43 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928024244.257687-5-xiangzao@linux.alibaba.com \
--to=xiangzao@linux.alibaba.com \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
--cc=yixingrui@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.