From: Peter Zijlstra <peterz@infradead.org>
To: Xiaobing Li <xiaobing.li@samsung.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com, axboe@kernel.dk,
asml.silence@gmail.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
kun.dou@samsung.com, peiwei.li@samsung.com, joshi.k@samsung.com,
kundan.kumar@samsung.com, wenwen.chen@samsung.com,
ruyi.zhang@samsung.com
Subject: Re: [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization.
Date: Thu, 28 Sep 2023 10:02:13 +0200 [thread overview]
Message-ID: <20230928080213.GD9829@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230928022228.15770-2-xiaobing.li@samsung.com>
On Thu, Sep 28, 2023 at 10:22:26AM +0800, Xiaobing Li wrote:
> + for (int i = 0; i < MAX_SQ_NUM; i++) {
> + if (sqstat[i] && (task_cpu(sqstat[i]) != task_cpu(p)
> + || sqstat[i]->__state == TASK_DEAD))
> + sqstat[i] = NULL;
> + }
This coding style is horrific, please don't ever use that again.
next prev parent reply other threads:[~2023-09-28 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230928023004epcas5p4a6dac4cda9c867f3673690521a8c18b6@epcas5p4.samsung.com>
2023-09-28 2:22 ` [PATCH 0/3] Sq thread real utilization statistics Xiaobing Li
2023-09-28 2:22 ` [PATCH 1/3] SCHEDULER: Add an interface for counting real utilization Xiaobing Li
2023-09-28 7:52 ` kernel test robot
2023-09-28 8:02 ` Peter Zijlstra [this message]
2023-09-29 0:31 ` Thomas Gleixner
2023-09-28 2:22 ` [PATCH 2/3] PROC FILESYSTEM: Add real utilization data of sq thread Xiaobing Li
2023-09-28 2:22 ` [PATCH 3/3] IO_URING: Statistics of the true utilization of sq threads Xiaobing Li
2023-09-28 8:01 ` Peter Zijlstra
2023-09-28 8:23 ` Jens Axboe
2023-09-28 8:37 ` Matthew Wilcox
2023-09-28 8:41 ` Jens Axboe
2023-09-28 18:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928080213.GD9829@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=juri.lelli@redhat.com \
--cc=kun.dou@samsung.com \
--cc=kundan.kumar@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peiwei.li@samsung.com \
--cc=rostedt@goodmis.org \
--cc=ruyi.zhang@samsung.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wenwen.chen@samsung.com \
--cc=xiaobing.li@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.