From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in the match tables
Date: Thu, 28 Sep 2023 14:44:20 +0100 [thread overview]
Message-ID: <20230928134420.GK9999@google.com> (raw)
In-Reply-To: <ZRE08RkhG2C+Pi3l@smile.fi.intel.com>
On Mon, 25 Sep 2023, Andy Shevchenko wrote:
> On Sat, Sep 23, 2023 at 06:19:20PM +0100, Biju Das wrote:
> > Convert enum->pointer for data in the match tables, so that
> > device_get_match_data() can do match against OF/ACPI/I2C tables, once i2c
> > bus type match support added to it.
> >
> > Replace enum->struct *pca955x_chipdefs for data in the match table.
> > Simplify the probe() by replacing device_get_match_data() and ID lookup
> > for retrieving data by i2c_get_match_data().
> >
> > While at it, add const definition to pca955x_chipdefs[].
>
> ...
>
> > - struct pca955x_chipdef *chipdef;
> > + const struct pca955x_chipdef *chipdef;
>
> No need to preserve TAB(s) here.
Follow-up please.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-09-28 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 17:19 [PATCH v2 0/2] Match data improvements for pca955x driver Biju Das
2023-09-23 17:19 ` [PATCH v2 1/2] leds: pca955x: Convert enum->pointer for data in the match tables Biju Das
2023-09-25 7:21 ` Andy Shevchenko
2023-09-28 13:44 ` Lee Jones [this message]
2023-09-28 13:51 ` Biju Das
2023-09-23 17:19 ` [PATCH v2 2/2] leds: pca955x: Cleanup OF/ID table terminators Biju Das
2023-09-25 7:22 ` Andy Shevchenko
2023-09-28 13:44 ` [PATCH v2 0/2] Match data improvements for pca955x driver Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928134420.GK9999@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.