From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F1DE7F154 for ; Thu, 28 Sep 2023 19:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbjI1TAr (ORCPT ); Thu, 28 Sep 2023 15:00:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjI1TAr (ORCPT ); Thu, 28 Sep 2023 15:00:47 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3BF21A1 for ; Thu, 28 Sep 2023 12:00:45 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qlwFg-0007B7-8O; Thu, 28 Sep 2023 21:00:44 +0200 Date: Thu, 28 Sep 2023 21:00:44 +0200 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nf PATCH v2 1/8] netfilter: nf_tables: Don't allocate nft_rule_dump_ctx Message-ID: <20230928190044.GF19098@breakpoint.cc> References: <20230928165244.7168-1-phil@nwl.cc> <20230928165244.7168-2-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230928165244.7168-2-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > Eliminate the direct use of netlink_callback::args when dumping rules by > casting nft_rule_dump_ctx over netlink_callback::ctx as suggested in > the struct's comment. > > The value for 's_idx' has to be stored inside nft_rule_dump_ctx now and > make it hold the 'reset' boolean as well. > > Note how this patch removes the zeroing of netlink_callback::args[1-5] - > none of the rule dump callbacks seem to make use of them. Do you think we can fix the reset race in -next instead of -nf? If yes, you could detach preparation patches like this one and split the series in several batches.