From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] mtd: rawnand: check nand support for cache reads
Date: Fri, 29 Sep 2023 22:02:35 +0800 [thread overview]
Message-ID: <202309292142.T5cC8cqe-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230922100116.145090-1-r.czerwinski@pengutronix.de>
References: <20230922100116.145090-1-r.czerwinski@pengutronix.de>
TO: Rouven Czerwinski <r.czerwinski@pengutronix.de>
TO: "Martin Hundebøll" <martin@geanix.com>
TO: "Måns Rullgård" <mans@mansr.com>
TO: Miquel Raynal <miquel.raynal@bootlin.com>
TO: Richard Weinberger <richard@nod.at>
TO: Vignesh Raghavendra <vigneshr@ti.com>
TO: JaimeLiao <jaimeliao.tw@gmail.com>
CC: kernel@pengutronix.de
CC: Rouven Czerwinski <r.czerwinski@pengutronix.de>
CC: linux-mtd@lists.infradead.org
CC: linux-kernel@vger.kernel.org
Hi Rouven,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc3 next-20230929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rouven-Czerwinski/mtd-rawnand-check-nand-support-for-cache-reads/20230922-180317
base: linus/master
patch link: https://lore.kernel.org/r/20230922100116.145090-1-r.czerwinski%40pengutronix.de
patch subject: [PATCH] mtd: rawnand: check nand support for cache reads
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-161-20230929 (https://download.01.org/0day-ci/archive/20230929/202309292142.T5cC8cqe-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230929/202309292142.T5cC8cqe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202309292142.T5cC8cqe-lkp@intel.com/
smatch warnings:
drivers/mtd/nand/raw/nand_jedec.c:98 nand_jedec_detect() warn: statement has no effect 8
drivers/mtd/nand/raw/nand_onfi.c:307 nand_onfi_detect() warn: statement has no effect 8
vim +98 drivers/mtd/nand/raw/nand_jedec.c
2e8f56f2a94176 Miquel Raynal 2020-04-28 20
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 21 /*
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 22 * Check if the NAND chip is JEDEC compliant, returns 1 if it is, 0 otherwise.
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 23 */
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 24 int nand_jedec_detect(struct nand_chip *chip)
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 25 {
53576c7bfc3589 Miquel Raynal 2020-08-27 26 struct nand_device *base = &chip->base;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 27 struct mtd_info *mtd = nand_to_mtd(chip);
629a442cad5fac Boris Brezillon 2018-10-25 28 struct nand_memory_organization *memorg;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 29 struct nand_jedec_params *p;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 30 struct jedec_ecc_info *ecc;
daca31765e8bea Miquel Raynal 2020-05-07 31 bool use_datain = false;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 32 int jedec_version = 0;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 33 char id[5];
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 34 int i, val, ret;
432ab89d3035fe Miquel Raynal 2020-04-28 35 u16 crc;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 36
629a442cad5fac Boris Brezillon 2018-10-25 37 memorg = nanddev_get_memorg(&chip->base);
629a442cad5fac Boris Brezillon 2018-10-25 38
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 39 /* Try JEDEC for unknown chip or LP */
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 40 ret = nand_readid_op(chip, 0x40, id, sizeof(id));
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 41 if (ret || strncmp(id, "JEDEC", sizeof(id)))
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 42 return 0;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 43
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 44 /* JEDEC chip: allocate a buffer to hold its parameter page */
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 45 p = kzalloc(sizeof(*p), GFP_KERNEL);
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 46 if (!p)
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 47 return -ENOMEM;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 48
9f820fc0651c32 Miquel Raynal 2023-01-12 49 if (!nand_has_exec_op(chip) || chip->controller->supported_op.data_only_read)
daca31765e8bea Miquel Raynal 2020-05-07 50 use_datain = true;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 51
2e8f56f2a94176 Miquel Raynal 2020-04-28 52 for (i = 0; i < JEDEC_PARAM_PAGES; i++) {
daca31765e8bea Miquel Raynal 2020-05-07 53 if (!i)
daca31765e8bea Miquel Raynal 2020-05-07 54 ret = nand_read_param_page_op(chip, 0x40, p,
daca31765e8bea Miquel Raynal 2020-05-07 55 sizeof(*p));
daca31765e8bea Miquel Raynal 2020-05-07 56 else if (use_datain)
daca31765e8bea Miquel Raynal 2020-05-07 57 ret = nand_read_data_op(chip, p, sizeof(*p), true,
daca31765e8bea Miquel Raynal 2020-05-07 58 false);
daca31765e8bea Miquel Raynal 2020-05-07 59 else
daca31765e8bea Miquel Raynal 2020-05-07 60 ret = nand_change_read_column_op(chip, sizeof(*p) * i,
daca31765e8bea Miquel Raynal 2020-05-07 61 p, sizeof(*p), true);
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 62 if (ret) {
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 63 ret = 0;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 64 goto free_jedec_param_page;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 65 }
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 66
432ab89d3035fe Miquel Raynal 2020-04-28 67 crc = onfi_crc16(ONFI_CRC_BASE, (u8 *)p, 510);
432ab89d3035fe Miquel Raynal 2020-04-28 68 if (crc == le16_to_cpu(p->crc))
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 69 break;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 70 }
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 71
2e8f56f2a94176 Miquel Raynal 2020-04-28 72 if (i == JEDEC_PARAM_PAGES) {
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 73 pr_err("Could not find valid JEDEC parameter page; aborting\n");
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 74 goto free_jedec_param_page;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 75 }
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 76
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 77 /* Check version */
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 78 val = le16_to_cpu(p->revision);
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 79 if (val & (1 << 2))
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 80 jedec_version = 10;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 81 else if (val & (1 << 1))
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 82 jedec_version = 1; /* vendor specific version */
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 83
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 84 if (!jedec_version) {
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 85 pr_info("unsupported JEDEC version: %d\n", val);
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 86 goto free_jedec_param_page;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 87 }
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 88
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 89 sanitize_string(p->manufacturer, sizeof(p->manufacturer));
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 90 sanitize_string(p->model, sizeof(p->model));
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 91 chip->parameters.model = kstrdup(p->model, GFP_KERNEL);
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 92 if (!chip->parameters.model) {
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 93 ret = -ENOMEM;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 94 goto free_jedec_param_page;
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 95 }
8ae3fbf81b9cfd Boris Brezillon 2018-09-07 96
040597624fe1ec Rouven Czerwinski 2023-09-22 97 if (p->opt_cmd[0] & JEDEC_OPT_CMD_READ_CACHE)
040597624fe1ec Rouven Czerwinski 2023-09-22 @98 chip->parameters.supports_read_cache;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-09-29 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 14:02 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-22 10:01 [PATCH] mtd: rawnand: check nand support for cache reads Rouven Czerwinski
2023-09-22 10:01 ` Rouven Czerwinski
2023-09-22 10:04 ` Martin Hundebøll
2023-09-22 10:04 ` Martin Hundebøll
2023-09-22 10:07 ` Rouven Czerwinski
2023-09-22 10:07 ` Rouven Czerwinski
2023-09-22 11:20 ` kernel test robot
2023-09-22 11:20 ` kernel test robot
2023-09-22 14:04 ` Miquel Raynal
2023-09-22 14:04 ` Miquel Raynal
2023-09-29 17:00 ` kernel test robot
2023-09-29 17:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309292142.T5cC8cqe-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.