All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Steven Noonan <steven@uplinklabs.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/powertop: picutils is optional, not mandatory
Date: Sat, 30 Sep 2023 19:19:28 +0200	[thread overview]
Message-ID: <20230930171928.GE2579@scaer> (raw)
In-Reply-To: <20230929161208.1106775-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2023-09-29 18:12 +0200, Fabrice Fontaine spake thusly:
> pciutils is optional, not mandatory since version 2.1 and the addition
> of the package in commit 0adc0e24eed72efca0097c7567319f07b8af6d94 and
> https://github.com/fenrus75/powertop/commit/98ca605e7cf856795facc4a3a4f9c5b9baf1cab1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, after slightly reorganinsing the _DEPENDENCIES,
thanks.

Regards,
Yann E. MORIN.

> ---
>  package/powertop/Config.in   | 1 -
>  package/powertop/powertop.mk | 3 ++-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/powertop/Config.in b/package/powertop/Config.in
> index 0f323a7bfb..fd88a3d0eb 100644
> --- a/package/powertop/Config.in
> +++ b/package/powertop/Config.in
> @@ -4,7 +4,6 @@ config BR2_PACKAGE_POWERTOP
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
>  	depends on BR2_USE_WCHAR
>  	select BR2_PACKAGE_NCURSES
> -	select BR2_PACKAGE_PCIUTILS
>  	select BR2_PACKAGE_LIBNL
>  	help
>  	  A tool to diagnose issues with power consumption and power
> diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
> index c3e8d2549c..681f5fda46 100644
> --- a/package/powertop/powertop.mk
> +++ b/package/powertop/powertop.mk
> @@ -6,7 +6,8 @@
>  
>  POWERTOP_VERSION = 2.13
>  POWERTOP_SITE = https://01.org/sites/default/files/downloads
> -POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
> +POWERTOP_DEPENDENCIES = ncurses libnl host-pkgconf \
> +	$(if $(BR2_PACKAGE_PCIUTILS),pciutils) \
>  	$(TARGET_NLS_DEPENDENCIES)
>  POWERTOP_LICENSE = GPL-2.0
>  POWERTOP_LICENSE_FILES = COPYING
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-09-30 17:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 16:12 [Buildroot] [PATCH 1/2] package/powertop: picutils is optional, not mandatory Fabrice Fontaine
2023-09-29 16:12 ` [Buildroot] [PATCH 2/2] package/powertop: bump to version 2.15 Fabrice Fontaine
2023-09-30 17:19   ` Yann E. MORIN
2023-09-30 17:19 ` Yann E. MORIN [this message]
2023-10-13  6:21 ` [Buildroot] [PATCH 1/2] package/powertop: picutils is optional, not mandatory Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230930171928.GE2579@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=steven@uplinklabs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.