From: Ondrej Zary <linux@zary.sk>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Sergey Shtylyov <s.shtylyov@omp.ru>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>,
linux-block@vger.kernel.org, linux-parport@lists.infradead.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] pata_parport: fix pata_parport_devchk
Date: Sat, 30 Sep 2023 21:15:08 +0200 [thread overview]
Message-ID: <20230930191511.24994-2-linux@zary.sk> (raw)
In-Reply-To: <20230930191511.24994-1-linux@zary.sk>
There's a 'x' missing in 0x55 in pata_parport_devchk(), causing the
detection to always fail. Fix it.
Signed-off-by: Ondrej Zary <linux@zary.sk>
---
drivers/ata/pata_parport/pata_parport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_parport/pata_parport.c b/drivers/ata/pata_parport/pata_parport.c
index 1af64d435d3c..258d189f42e5 100644
--- a/drivers/ata/pata_parport/pata_parport.c
+++ b/drivers/ata/pata_parport/pata_parport.c
@@ -64,7 +64,7 @@ static bool pata_parport_devchk(struct ata_port *ap, unsigned int device)
pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0xaa);
pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0x55);
- pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 055);
+ pi->proto->write_regr(pi, 0, ATA_REG_NSECT, 0x55);
pi->proto->write_regr(pi, 0, ATA_REG_LBAL, 0xaa);
nsect = pi->proto->read_regr(pi, 0, ATA_REG_NSECT);
--
Ondrej Zary
next prev parent reply other threads:[~2023-09-30 19:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 19:15 [PATCH 0/4] pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Ondrej Zary
2023-09-30 19:15 ` Ondrej Zary [this message]
2023-10-02 18:43 ` [PATCH 1/4] pata_parport: fix pata_parport_devchk Sergey Shtylyov
2023-10-02 19:08 ` Sergey Shtylyov
2023-10-03 17:07 ` Ondrej Zary
2023-10-03 17:18 ` Sergei Shtylyov
2023-09-30 19:15 ` [PATCH 2/4] pata_parport: implement set_devctl Ondrej Zary
2023-10-02 19:52 ` Sergey Shtylyov
2023-09-30 19:15 ` [PATCH 3/4] pata_parport: add custom version of wait_after_reset Ondrej Zary
2023-10-02 20:48 ` Sergey Shtylyov
2023-10-03 17:20 ` Ondrej Zary
2023-10-03 0:55 ` Damien Le Moal
2023-10-03 16:55 ` Sergey Shtylyov
2023-10-03 23:44 ` Damien Le Moal
2023-09-30 19:15 ` [PATCH 4/4] pata_parport-fit3: implement IDE command set registers Ondrej Zary
2023-10-02 20:06 ` Sergey Shtylyov
2023-10-03 17:13 ` Ondrej Zary
2023-10-03 0:56 ` Damien Le Moal
2023-10-03 0:34 ` [PATCH 0/4] pata_parport: fix EXP Computer CD-865 with MC-1285B EPP cable Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930191511.24994-2-linux@zary.sk \
--to=linux@zary.sk \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=s.shtylyov@omp.ru \
--cc=sudipm.mukherjee@gmail.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.