From: Simon Horman <horms@kernel.org>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Julien Panis <jpanis@baylibre.com>,
Judith Mendez <jm@ti.com>
Subject: Re: [PATCH v6 04/14] can: m_can: Implement receive coalescing
Date: Sun, 1 Oct 2023 14:23:16 +0200 [thread overview]
Message-ID: <20231001122316.GL92317@kernel.org> (raw)
In-Reply-To: <20230929141304.3934380-5-msp@baylibre.com>
On Fri, Sep 29, 2023 at 04:12:54PM +0200, Markus Schneider-Pargmann wrote:
> m_can offers the possibility to set an interrupt on reaching a watermark
> level in the receive FIFO. This can be used to implement coalescing.
> Unfortunately there is no hardware timeout available to trigger an
> interrupt if only a few messages were received within a given time. To
> solve this I am using a hrtimer to wake up the irq thread after x
> microseconds.
>
> The timer is always started if receive coalescing is enabled and new
> received frames were available during an interrupt. The timer is stopped
> if during a interrupt handling no new data was available.
>
> If the timer is started the new item interrupt is disabled and the
> watermark interrupt takes over. If the timer is not started again, the
> new item interrupt is enabled again, notifying the handler about every
> new item received.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-10-01 12:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 14:12 [PATCH v6 00/14] can: m_can: Optimizations for m_can/tcan part 2 Markus Schneider-Pargmann
2023-09-29 14:12 ` [PATCH v6 01/14] can: m_can: Start/Cancel polling timer together with interrupts Markus Schneider-Pargmann
2023-10-01 12:22 ` Simon Horman
2023-09-29 14:12 ` [PATCH v6 02/14] can: m_can: Move hrtimer init to m_can_class_register Markus Schneider-Pargmann
2023-10-01 12:22 ` Simon Horman
2023-09-29 14:12 ` [PATCH v6 03/14] can: m_can: Write transmit header and data in one transaction Markus Schneider-Pargmann
2023-09-29 14:12 ` [PATCH v6 04/14] can: m_can: Implement receive coalescing Markus Schneider-Pargmann
2023-10-01 12:23 ` Simon Horman [this message]
2023-09-29 14:12 ` [PATCH v6 05/14] can: m_can: Implement transmit coalescing Markus Schneider-Pargmann
2023-10-01 12:23 ` Simon Horman
2023-09-29 14:12 ` [PATCH v6 06/14] can: m_can: Add rx coalescing ethtool support Markus Schneider-Pargmann
2023-10-01 12:23 ` Simon Horman
2023-09-29 14:12 ` [PATCH v6 07/14] can: m_can: Add tx " Markus Schneider-Pargmann
2023-10-01 12:24 ` Simon Horman
2023-09-29 14:12 ` [PATCH v6 08/14] can: m_can: Use u32 for putidx Markus Schneider-Pargmann
2023-09-29 14:12 ` [PATCH v6 09/14] can: m_can: Cache tx putidx Markus Schneider-Pargmann
2023-09-29 14:13 ` [PATCH v6 10/14] can: m_can: Use the workqueue as queue Markus Schneider-Pargmann
2023-09-29 14:13 ` [PATCH v6 11/14] can: m_can: Introduce a tx_fifo_in_flight counter Markus Schneider-Pargmann
2023-09-29 14:13 ` [PATCH v6 12/14] can: m_can: Use tx_fifo_in_flight for netif_queue control Markus Schneider-Pargmann
2023-09-29 14:13 ` [PATCH v6 13/14] can: m_can: Implement BQL Markus Schneider-Pargmann
2023-09-29 14:13 ` [PATCH v6 14/14] can: m_can: Implement transmit submission coalescing Markus Schneider-Pargmann
2023-10-17 8:44 ` [PATCH v6 00/14] can: m_can: Optimizations for m_can/tcan part 2 Markus Schneider-Pargmann
2023-11-13 13:25 ` Martin Hundebøll
2023-11-13 13:30 ` Marc Kleine-Budde
2023-11-13 13:31 ` Martin Hundebøll
2023-11-13 20:51 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231001122316.GL92317@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jm@ti.com \
--cc=jpanis@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.