All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: usb: Remove unnecessary whitespace in function pointer declaration
Date: Sun, 1 Oct 2023 08:12:34 +0200	[thread overview]
Message-ID: <2023100116-headscarf-dreaded-cf8e@gregkh> (raw)
In-Reply-To: <20230930204136.62015-1-bergh.jonathan@gmail.com>

On Sat, Sep 30, 2023 at 10:41:36PM +0200, Jonathan Bergh wrote:
> Fixed a formatting issue flagged by checkpatch where unnecessary
> whitespace was included before the parameter list in the function
> pointer declaration.
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> ---
>  drivers/usb/c67x00/c67x00.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/c67x00/c67x00.h b/drivers/usb/c67x00/c67x00.h
> index a4456d0fffa9..3673357818b4 100644
> --- a/drivers/usb/c67x00/c67x00.h
> +++ b/drivers/usb/c67x00/c67x00.h
> @@ -193,7 +193,7 @@ struct c67x00_sie {
>  	/* Entries to be used by the subdrivers */
>  	spinlock_t lock;	/* protect this structure */
>  	void *private_data;
> -	void (*irq) (struct c67x00_sie *sie, u16 int_status, u16 msg);
> +	void (*irq)(struct c67x00_sie *sie, u16 int_status, u16 msg);

Same comment as on the other patches, subject line is incorrect, and why
do this?

thanks,

greg k-h

      reply	other threads:[~2023-10-01  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 20:41 [PATCH] drivers: usb: Remove unnecessary whitespace in function pointer declaration Jonathan Bergh
2023-10-01  6:12 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023100116-headscarf-dreaded-cf8e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bergh.jonathan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.