Re: [sj:damon/next 25/28] mm/damon/sysfs-schemes.c:1869:6: warning: no previous prototype for 'damos_sysfs_tried_regions_reset_update_status'

[sj@kernel.org]

Hi robot,

On Sun, 1 Oct 2023 08:50:48 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   ee9e834252d5110f424abdef73f776cd4dc5ceae
> commit: d3dfc5443e1f05dd03955ba5fe214812d0219395 [25/28] mm/damon/sysfs-schemes: update tried regions for only one apply interval
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231001/202310010851.UTmHwpyH-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310010851.UTmHwpyH-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310010851.UTmHwpyH-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>    mm/damon/sysfs-schemes.c:127:60: error: field 'update_status' has incomplete type
>      127 |         enum damos_sysfs_tried_regions_reset_update_status update_status;
>          |                                                            ^~~~~~~~~~~~~
> >> mm/damon/sysfs-schemes.c:1869:6: warning: no previous prototype for 'damos_sysfs_tried_regions_reset_update_status' [-Wmissing-prototypes]
>     1869 | void damos_sysfs_tried_regions_reset_update_status(struct damon_ctx *ctx)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    mm/damon/sysfs-schemes.c: In function 'damos_sysfs_tried_regions_reset_update_status':
>    mm/damon/sysfs-schemes.c:1876:17: error: 'sysfs_Schemes' undeclared (first use in this function); did you mean 'sysfs_schemes'?
>     1876 |                 sysfs_Schemes->schemes_arr[i]->tried_regions->update_status =
>          |                 ^~~~~~~~~~~~~
>          |                 sysfs_schemes
>    mm/damon/sysfs-schemes.c:1876:17: note: each undeclared identifier is reported only once for each function it appears in

Thank you for this report.  I made a fix for this as a followup commit[1].  I
will squash the fix into the original broken commit and push by today.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?h=damon/next&id=ff3d1bf4122213fbcae73b075149e7cc3f5c0f34


Thanks,
SJ

>
>
> vim +/damos_sysfs_tried_regions_reset_update_status +1869 mm/damon/sysfs-schemes.c
>
>   1868
> > 1869        void damos_sysfs_tried_regions_reset_update_status(struct damon_ctx *ctx)
>   1870        {
>   1871                struct damon_sysfs_schemes *sysfs_schemes =
>   1872                        damon_sysfs_schemes_for_damos_callback;
>   1873                int i;
>   1874
>   1875                for (i = 0; i < sysfs_schemes->nr; i++)
>   1876                        sysfs_Schemes->schemes_arr[i]->tried_regions->update_status =
>   1877                                damos_tried_region_update_idle;
>   1878        }
>   1879
>