From: kernel test robot <lkp@intel.com>
To: Hector Martin <marcan@marcan.st>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP'
Date: Sun, 1 Oct 2023 18:26:54 +0800 [thread overview]
Message-ID: <202310011802.cL64lJDc-lkp@intel.com> (raw)
tree: https://github.com/AsahiLinux/linux bits/140-pci
head: 07c5be0c765a02a50f5777ec7cb2e33c82d641c3
commit: bc47733313473d25b60a7f875cf6f806d62a641d [10/15] PCIE: apple: Add T602x PCIe support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231001/202310011802.cL64lJDc-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231001/202310011802.cL64lJDc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310011802.cL64lJDc-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pci/controller/pcie-apple.c: In function 'apple_pcie_port_setup_irq':
>> drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
468 | writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +/FIELD_PREP +468 drivers/pci/controller/pcie-apple.c
430
431 static int apple_pcie_port_setup_irq(struct apple_pcie_port *port)
432 {
433 struct fwnode_handle *fwnode = &port->np->fwnode;
434 struct apple_pcie *pcie = port->pcie;
435 unsigned int irq;
436
437 /* FIXME: consider moving each interrupt under each port */
438 irq = irq_of_parse_and_map(to_of_node(dev_fwnode(port->pcie->dev)),
439 port->idx);
440 if (!irq)
441 return -ENXIO;
442
443 port->domain = irq_domain_create_linear(fwnode, 32,
444 &apple_port_irq_domain_ops,
445 port);
446 if (!port->domain)
447 return -ENOMEM;
448
449 /* Disable all interrupts */
450 writel_relaxed(~0, port->base + PORT_INTMSK);
451 writel_relaxed(~0, port->base + PORT_INTSTAT);
452 writel_relaxed(~0, port->base + PORT_LINKCMDSTS);
453
454 irq_set_chained_handler_and_data(irq, apple_port_irq_handler, port);
455
456 /* Configure MSI base address */
457 BUG_ON(upper_32_bits(DOORBELL_ADDR));
458 writel_relaxed(lower_32_bits(DOORBELL_ADDR),
459 port->base + pcie->hw->port_msiaddr);
460 if (pcie->hw->port_msiaddr_hi)
461 writel_relaxed(0, port->base + pcie->hw->port_msiaddr_hi);
462
463 /* Enable MSIs, shared between all ports */
464 if (pcie->hw->port_msimap) {
465 int i;
466
467 for (i = 0; i < pcie->nvecs; i++) {
> 468 writel_relaxed(FIELD_PREP(PORT_MSIMAP_TARGET, i) |
469 PORT_MSIMAP_ENABLE,
470 port->base + pcie->hw->port_msimap + 4 * i);
471 }
472
473 writel_relaxed(PORT_MSICFG_EN, port->base + PORT_MSICFG);
474 } else {
475 writel_relaxed(0, port->base + PORT_MSIBASE);
476 writel_relaxed((ilog2(pcie->nvecs) << PORT_MSICFG_L2MSINUM_SHIFT) |
477 PORT_MSICFG_EN, port->base + PORT_MSICFG);
478 }
479
480 return 0;
481 }
482
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-10-01 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 10:26 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-12 8:31 [asahilinux:bits/140-pci 10/15] drivers/pci/controller/pcie-apple.c:468:40: error: implicit declaration of function 'FIELD_PREP' kernel test robot
2023-07-28 0:51 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310011802.cL64lJDc-lkp@intel.com \
--to=lkp@intel.com \
--cc=marcan@marcan.st \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.