All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: "Wolfgang Grandegger" <wg@grandegger.com>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Eric Dumazet" <edumazet@google.com>,
	netdev@vger.kernel.org, linux-can@vger.kernel.org,
	"Jérémie Dautheribes" <jeremie.dautheribes@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	sylvain.girard@se.com, pascal.eberhard@se.com
Subject: Re: [PATCH net-next] can: sja1000: Fix comment
Date: Sun, 1 Oct 2023 19:13:16 +0200	[thread overview]
Message-ID: <20231001191316.466d0482@xps-13> (raw)
In-Reply-To: <20230928123556.GH24230@kernel.org>

Hi Simon,

horms@kernel.org wrote on Thu, 28 Sep 2023 14:35:56 +0200:

> On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote:
> > There is likely a copy-paste error here, as the exact same comment
> > appears below in this function, one time calling set_reset_mode(), the
> > other set_normal_mode().
> > 
> > Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")  
> 
> I'm not sure this warrants a fixes tag, which implies backporting,
> but in any case the tag is correct.

My understanding is that "Fixes" does not imply backporting, whereas
"Cc: stable@vger.kernel.org" actually does. In practice, stable
maintainers are using magic scripts which, it's true, often select
patches which contain a Fixes tag, but that's more a consequence of
people not Cc'ing stable when it's relevant :)

> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> The above comment notwithstanding, this seems correct to me.
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Thanks for the review,
Miquèl

  reply	other threads:[~2023-10-01 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 15:51 [PATCH net-next] can: sja1000: Fix comment Miquel Raynal
2023-09-28 12:35 ` Simon Horman
2023-10-01 17:13   ` Miquel Raynal [this message]
2023-10-04 10:14 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231001191316.466d0482@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jeremie.dautheribes@bootlin.com \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pascal.eberhard@se.com \
    --cc=sylvain.girard@se.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.