From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A36DE7849A for ; Mon, 2 Oct 2023 06:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235540AbjJBGtU (ORCPT ); Mon, 2 Oct 2023 02:49:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235321AbjJBGtT (ORCPT ); Mon, 2 Oct 2023 02:49:19 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7FFCA4 for ; Sun, 1 Oct 2023 23:49:16 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id E51D168C7B; Mon, 2 Oct 2023 08:49:12 +0200 (CEST) Date: Mon, 2 Oct 2023 08:49:12 +0200 From: Christoph Hellwig To: Al Viro Cc: linux-fsdevel@vger.kernel.org, Christian Brauner , Christoph Hellwig , Linus Torvalds , Namjae Jeon , David Sterba , David Howells , Miklos Szeredi , Amir Goldstein , Trond Myklebust , Bob Peterson , Steve French , Luis Chamberlain Subject: Re: [PATCH 04/15] hfsplus: switch to rcu-delayed unloading of nls and freeing ->s_fs_info Message-ID: <20231002064912.GA2013@lst.de> References: <20231002022815.GQ800259@ZenIV> <20231002022846.GA3389589@ZenIV> <20231002023125.GE3389589@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231002023125.GE3389589@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Instead of all this duplicatio in the file system, can we please just add a struct nls_table *s_nls; to struct super_block and RCU free it in common code and drop all the code in the file systems?