From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3BBFE784AF for ; Mon, 2 Oct 2023 09:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KMQRvGd0ehyK+mBbA2lrDx03fTdhxZQhy1z3+99trI4=; b=VzzYnZMojdMpmv /hWswIgVxjc4Cm7aGcm9cf9ySEAg9AgZAjZ8L2V+DjcgeYzD2xSeNQ8Qy7JRuZs2L30Dv77+5czva 0IFGbVUEGQJHZQY71Mn02v7/73nuvyZV0of4M4doJDSmwxGRNn2grJJfhUt8+Qb0K4pHFLhekzgGG 6rSkcE8+Vfi4LjuJxD8V13/WvKFqDJcOUlXzR5sJRl2hIGa2Po0U/uVY7lYgyjPeN21GPufigH7XQ NEU8FBgTzDIrnEu50DXXX4uPXQJiVc0kRGId4VL4eSg3nRyjFbnqJeLB9JntFoK3/YZVQPairpBe8 QP94UmnlbP0tHXf1zlrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnFUG-00CFzq-2R; Mon, 02 Oct 2023 09:45:12 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnFUD-00CFyU-0Y for linux-mtd@lists.infradead.org; Mon, 02 Oct 2023 09:45:11 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 58CD2240012; Mon, 2 Oct 2023 09:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696239905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRukAf2u3WRWfmx+HCNdHblYYcJv+Zb9WqDcKGDdaw4=; b=PvJ/8QH0yMf/nAAi/XQOuBdImhyM8dVHnNnXFqU/UP5EOA9fWJLKNXiQpTxQ+MchTq3Nkc Fe7m9lruD32WCFl8t6ooHSDChiU5QrcLP+R5Py6hBvlYz96ImWssErOzw3Di7bogHvdM+h 73bjsOoxGOgrs6sPs1y+pXaEsHSdAu9K359Wquy9D2fDUKinDi6RSziy+oBI5FOI8KRTDL R7C9jumlUnHGZp50TnXfQfi42KCYCaOMsUvl4XPVEJR7iGLBwrTtmA76SFCE5X5ePTw9I8 IZtGUF1y1alpQePBAz2Q5m4wr1x3JntnqKEHI/LyyN441us2ZYrxwIYSdzJmpA== Date: Mon, 2 Oct 2023 11:44:50 +0200 From: Miquel Raynal To: Martin Kurbanov Cc: Richard Weinberger , Vignesh Raghavendra , Mario Kicherer , Chuanhong Guo , Dhruva Gole , , , Subject: Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G Message-ID: <20231002114450.4ce69141@xps-13> In-Reply-To: <20230929144934.192649-1-mmkurbanov@salutedevices.com> References: <20230929144934.192649-1-mmkurbanov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_024509_482546_06BFDA30 X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFydGluLAoKbW1rdXJiYW5vdkBzYWx1dGVkZXZpY2VzLmNvbSB3cm90ZSBvbiBGcmksIDI5 IFNlcCAyMDIzIDE3OjQ5OjM0ICswMzAwOgoKPiBBZGQgc3VwcG9ydCBmb3IgRk9SRVNFRSBGMzVT UUEwMDJHIFNQSSBOQU5ELgo+IERhdGFzaGVldDoKPiAgIGh0dHBzOi8vd3d3LmxvbmdzeXMuY29t L3VwbG9hZHMvTE0tMDAwMDZGT1JFU0VFRjM1U1FBMDAyR0RhdGFzaGVldF8xNjUwMTgzNzAxLnBk Zgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcnRpbiBLdXJiYW5vdiA8bW1rdXJiYW5vdkBzYWx1dGVk ZXZpY2VzLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFrZWZpbGUgIHwgICAy ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYyAgICB8ICAgMSArCj4gIGRyaXZlcnMv bXRkL25hbmQvc3BpL2ZvcmVzZWUuYyB8IDEwMSArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysKPiAgaW5jbHVkZS9saW51eC9tdGQvc3BpbmFuZC5oICAgIHwgICAxICsKPiAgNCBmaWxl cyBjaGFuZ2VkLCAxMDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgZHJpdmVycy9tdGQvbmFuZC9zcGkvZm9yZXNlZS5jCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvbXRkL25hbmQvc3BpL01ha2VmaWxlIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFr ZWZpbGUKPiBpbmRleCBjZDhiNjZiZjc3NDAuLjE5Y2M3NzI4OGViYiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL210ZC9uYW5kL3NwaS9NYWtlZmlsZQo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvc3Bp L01ha2VmaWxlCj4gQEAgLTEsNCArMSw0IEBACj4gICMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6 IEdQTC0yLjAKPiAtc3BpbmFuZC1vYmpzIDo9IGNvcmUubyBhbGxpYW5jZW1lbW9yeS5vIGF0by5v IGVzbXQubyBnaWdhZGV2aWNlLm8gbWFjcm9uaXgubwo+ICtzcGluYW5kLW9ianMgOj0gY29yZS5v IGFsbGlhbmNlbWVtb3J5Lm8gYXRvLm8gZXNtdC5vIGZvcmVzZWUubyBnaWdhZGV2aWNlLm8gbWFj cm9uaXgubwo+ICBzcGluYW5kLW9ianMgKz0gbWljcm9uLm8gcGFyYWdvbi5vIHRvc2hpYmEubyB3 aW5ib25kLm8geHR4Lm8KPiAgb2JqLSQoQ09ORklHX01URF9TUElfTkFORCkgKz0gc3BpbmFuZC5v Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYyBiL2RyaXZlcnMvbXRk L25hbmQvc3BpL2NvcmUuYwo+IGluZGV4IDM5M2ZmMzdmMGQyMy4uODQ5Y2NmZWRiYzcyIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbXRk L25hbmQvc3BpL2NvcmUuYwo+IEBAIC05NDAsNiArOTQwLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBzcGluYW5kX21hbnVmYWN0dXJlciAqc3BpbmFuZF9tYW51ZmFjdHVyZXJzW10gPSB7Cj4gIAkm YWxsaWFuY2VtZW1vcnlfc3BpbmFuZF9tYW51ZmFjdHVyZXIsCj4gIAkmYXRvX3NwaW5hbmRfbWFu dWZhY3R1cmVyLAo+ICAJJmVzbXRfYzhfc3BpbmFuZF9tYW51ZmFjdHVyZXIsCj4gKwkmZm9yZXNl ZV9zcGluYW5kX21hbnVmYWN0dXJlciwKPiAgCSZnaWdhZGV2aWNlX3NwaW5hbmRfbWFudWZhY3R1 cmVyLAo+ICAJJm1hY3Jvbml4X3NwaW5hbmRfbWFudWZhY3R1cmVyLAo+ICAJJm1pY3Jvbl9zcGlu YW5kX21hbnVmYWN0dXJlciwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9zcGkvZm9y ZXNlZS5jIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvZm9yZXNlZS5jCj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLjU1ZDRmZjFmMDkxYQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9mb3Jlc2VlLmMKPiBAQCAtMCwwICsxLDEwMSBA QAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogKEdQTC0yLjArIE9SIE1JVCkKPiArLyoK PiArICogQ29weXJpZ2h0IChjKSAyMDIzLCBTYmVyRGV2aWNlcy4gQWxsIFJpZ2h0cyBSZXNlcnZl ZC4KPiArICoKPiArICogQXV0aG9yOiBNYXJ0aW4gS3VyYmFub3YgPG1ta3VyYmFub3ZAc2FsdXRl ZGV2aWNlcy5jb20+Cj4gKyAqLwo+ICsKPiArI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+ICsj aW5jbHVkZSA8bGludXgva2VybmVsLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9tdGQvc3BpbmFuZC5o Pgo+ICsKPiArI2RlZmluZSBTUElOQU5EX01GUl9GT1JFU0VFCQkweENECj4gKwo+ICtzdGF0aWMg U1BJTkFORF9PUF9WQVJJQU5UUyhyZWFkX2NhY2hlX3ZhcmlhbnRzLAo+ICsJCVNQSU5BTkRfUEFH RV9SRUFEX0ZST01fQ0FDSEVfWDRfT1AoMCwgMSwgTlVMTCwgMCksCj4gKwkJU1BJTkFORF9QQUdF X1JFQURfRlJPTV9DQUNIRV9YMl9PUCgwLCAxLCBOVUxMLCAwKSwKPiArCQlTUElOQU5EX1BBR0Vf UkVBRF9GUk9NX0NBQ0hFX09QKHRydWUsIDAsIDEsIE5VTEwsIDApLAo+ICsJCVNQSU5BTkRfUEFH RV9SRUFEX0ZST01fQ0FDSEVfT1AoZmFsc2UsIDAsIDEsIE5VTEwsIDApKTsKPiArCj4gK3N0YXRp YyBTUElOQU5EX09QX1ZBUklBTlRTKHdyaXRlX2NhY2hlX3ZhcmlhbnRzLAo+ICsJCVNQSU5BTkRf UFJPR19MT0FEX1g0KHRydWUsIDAsIE5VTEwsIDApLAo+ICsJCVNQSU5BTkRfUFJPR19MT0FEKHRy dWUsIDAsIE5VTEwsIDApKTsKPiArCj4gK3N0YXRpYyBTUElOQU5EX09QX1ZBUklBTlRTKHVwZGF0 ZV9jYWNoZV92YXJpYW50cywKPiArCQlTUElOQU5EX1BST0dfTE9BRF9YNChmYWxzZSwgMCwgTlVM TCwgMCksCj4gKwkJU1BJTkFORF9QUk9HX0xPQUQoZmFsc2UsIDAsIE5VTEwsIDApKTsKPiArCj4g K3N0YXRpYyBpbnQgZjM1c3FhMDAyZ19vb2JsYXlvdXRfZWNjKHN0cnVjdCBtdGRfaW5mbyAqbXRk LCBpbnQgc2VjdGlvbiwKPiArCQkJCSAgICBzdHJ1Y3QgbXRkX29vYl9yZWdpb24gKnJlZ2lvbikK PiArewo+ICsJcmV0dXJuIC1FUkFOR0U7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgZjM1c3FhMDAy Z19vb2JsYXlvdXRfZnJlZShzdHJ1Y3QgbXRkX2luZm8gKm10ZCwgaW50IHNlY3Rpb24sCj4gKwkJ CQkgICAgIHN0cnVjdCBtdGRfb29iX3JlZ2lvbiAqcmVnaW9uKQo+ICt7Cj4gKwkvKiBYWFg6IEl0 IGlzIG5vdCBwb3NzaWJsZSB0byBwYXJ0aWFsbHkgd3JpdGUgdG8gdGhpcyBPT0IgYXJlYSwgYXMg Ym90aAo+ICsJICogdGhlIG1haW4gYW5kIE9PQiBhcmVhcyBhcmUgcHJvdGVjdGVkIGJ5IEVDQy4g VGhlIHVzZXIgbmVlZHMgdG8KPiArCSAqIHByb2dyYW0gYm90aCB0aGUgbWFpbiBhcmVhIGFuZCBP T0IgYXJlYSBhdCBvbmUgcHJvZ3JhbW1pbmcgdGltZSwKPiArCSAqIHNvIHRoYXQgdGhlIEVDQyBw YXJpdHkgY29kZSBjYW4gYmUgY2FsY3VsYXRlZCBwcm9wZXJseS4KPiArCSAqLwoKSXMgdGhpcyBj b21tZW50IHJlYWxseSBuZWVkZWQ/IEkgYmVsaWV2ZSBpdCBjb3VsZCBiZSBkcm9wcGVkLCB1bmxl c3MKeW91IGFyZSByZWFsbHkgZXhwZXJpZW5jaW5nIHN0cmFuZ2Ugc3VicGFnZSB3cml0ZSBhdHRl bXB0cz8KCj4gKwo+ICsJaWYgKHNlY3Rpb24pCj4gKwkJcmV0dXJuIC1FUkFOR0U7Cj4gKwo+ICsJ LyogUmVzZXJ2ZSAyIGJ5dGVzIGZvciB0aGUgQkJNLiAqLwo+ICsJcmVnaW9uLT5vZmZzZXQgPSAy Owo+ICsJcmVnaW9uLT5sZW5ndGggPSA2MjsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAr c3RhdGljIGNvbnN0IHN0cnVjdCBtdGRfb29ibGF5b3V0X29wcyBmMzVzcWEwMDJnX29vYmxheW91 dCA9IHsKPiArCS5lY2MgPSBmMzVzcWEwMDJnX29vYmxheW91dF9lY2MsCj4gKwkuZnJlZSA9IGYz NXNxYTAwMmdfb29ibGF5b3V0X2ZyZWUsCj4gK307Cj4gKwo+ICtzdGF0aWMgaW50IGYzNXNxYTAw MmdfZWNjX2dldF9zdGF0dXMoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5kLCB1OCBzdGF0 dXMpCj4gK3sKPiArCXN0cnVjdCBuYW5kX2RldmljZSAqbmFuZCA9IHNwaW5hbmRfdG9fbmFuZChz cGluYW5kKTsKPiArCj4gKwlzd2l0Y2ggKHN0YXR1cyAmIFNUQVRVU19FQ0NfTUFTSykgewo+ICsJ Y2FzZSBTVEFUVVNfRUNDX05PX0JJVEZMSVBTOgo+ICsJCXJldHVybiAwOwo+ICsKPiArCWNhc2Ug U1RBVFVTX0VDQ19IQVNfQklURkxJUFM6Cj4gKwkJcmV0dXJuIG5hbmRkZXZfZ2V0X2VjY19jb25m KG5hbmQpLT5zdHJlbmd0aDsKPiArCj4gKwlkZWZhdWx0Ogo+ICsJCWJyZWFrOwo+ICsJfQo+ICsK PiArCS8qIE1vcmUgdGhhbiAxLWJpdCBlcnJvciB3YXMgZGV0ZWN0ZWQgaW4gb25lIG9yIG1vcmUg c2VjdG9ycyBhbmQKPiArCSAqIGNhbm5vdCBiZSBjb3JyZWN0ZWQuCj4gKwkgKi8KPiArCXJldHVy biAtRUJBRE1TRzsKPiArfQo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBzcGluYW5kX2luZm8g Zm9yZXNlZV9zcGluYW5kX3RhYmxlW10gPSB7Cj4gKwlTUElOQU5EX0lORk8oIkYzNVNRQTAwMkci LAo+ICsJCSAgICAgU1BJTkFORF9JRChTUElOQU5EX1JFQURJRF9NRVRIT0RfT1BDT0RFX0RVTU1Z LCAweDcyLCAweDcyKSwKPiArCQkgICAgIE5BTkRfTUVNT1JHKDEsIDIwNDgsIDY0LCA2NCwgMjA0 OCwgNDAsIDEsIDEsIDEpLAo+ICsJCSAgICAgTkFORF9FQ0NSRVEoMSwgNTEyKSwKPiArCQkgICAg IFNQSU5BTkRfSU5GT19PUF9WQVJJQU5UUygmcmVhZF9jYWNoZV92YXJpYW50cywKPiArCQkJCQkg ICAgICAmd3JpdGVfY2FjaGVfdmFyaWFudHMsCj4gKwkJCQkJICAgICAgJnVwZGF0ZV9jYWNoZV92 YXJpYW50cyksCj4gKwkJICAgICBTUElOQU5EX0hBU19RRV9CSVQsCj4gKwkJICAgICBTUElOQU5E X0VDQ0lORk8oJmYzNXNxYTAwMmdfb29ibGF5b3V0LAo+ICsJCQkJICAgICBmMzVzcWEwMDJnX2Vj Y19nZXRfc3RhdHVzKSksCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHNwaW5hbmRf bWFudWZhY3R1cmVyX29wcyBmb3Jlc2VlX3NwaW5hbmRfbWFudWZfb3BzID0gewo+ICt9Owo+ICsK PiArY29uc3Qgc3RydWN0IHNwaW5hbmRfbWFudWZhY3R1cmVyIGZvcmVzZWVfc3BpbmFuZF9tYW51 ZmFjdHVyZXIgPSB7Cj4gKwkuaWQgPSBTUElOQU5EX01GUl9GT1JFU0VFLAo+ICsJLm5hbWUgPSAi Rk9SRVNFRSIsCj4gKwkuY2hpcHMgPSBmb3Jlc2VlX3NwaW5hbmRfdGFibGUsCj4gKwkubmNoaXBz ID0gQVJSQVlfU0laRShmb3Jlc2VlX3NwaW5hbmRfdGFibGUpLAo+ICsJLm9wcyA9ICZmb3Jlc2Vl X3NwaW5hbmRfbWFudWZfb3BzLAo+ICt9Owo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L210 ZC9zcGluYW5kLmggYi9pbmNsdWRlL2xpbnV4L210ZC9zcGluYW5kLmgKPiBpbmRleCAzZTI4NWMw OWQxNmQuLmJhZGI0YzFhYzA3OSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L210ZC9zcGlu YW5kLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L210ZC9zcGluYW5kLmgKPiBAQCAtMjYzLDYgKzI2 Myw3IEBAIHN0cnVjdCBzcGluYW5kX21hbnVmYWN0dXJlciB7Cj4gIGV4dGVybiBjb25zdCBzdHJ1 Y3Qgc3BpbmFuZF9tYW51ZmFjdHVyZXIgYWxsaWFuY2VtZW1vcnlfc3BpbmFuZF9tYW51ZmFjdHVy ZXI7Cj4gIGV4dGVybiBjb25zdCBzdHJ1Y3Qgc3BpbmFuZF9tYW51ZmFjdHVyZXIgYXRvX3NwaW5h bmRfbWFudWZhY3R1cmVyOwo+ICBleHRlcm4gY29uc3Qgc3RydWN0IHNwaW5hbmRfbWFudWZhY3R1 cmVyIGVzbXRfYzhfc3BpbmFuZF9tYW51ZmFjdHVyZXI7Cj4gK2V4dGVybiBjb25zdCBzdHJ1Y3Qg c3BpbmFuZF9tYW51ZmFjdHVyZXIgZm9yZXNlZV9zcGluYW5kX21hbnVmYWN0dXJlcjsKPiAgZXh0 ZXJuIGNvbnN0IHN0cnVjdCBzcGluYW5kX21hbnVmYWN0dXJlciBnaWdhZGV2aWNlX3NwaW5hbmRf bWFudWZhY3R1cmVyOwo+ICBleHRlcm4gY29uc3Qgc3RydWN0IHNwaW5hbmRfbWFudWZhY3R1cmVy IG1hY3Jvbml4X3NwaW5hbmRfbWFudWZhY3R1cmVyOwo+ICBleHRlcm4gY29uc3Qgc3RydWN0IHNw aW5hbmRfbWFudWZhY3R1cmVyIG1pY3Jvbl9zcGluYW5kX21hbnVmYWN0dXJlcjsKCk90aGVyd2lz ZSBsb29rcyBnb29kLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGlu ZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt bXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82DEE784AF for ; Mon, 2 Oct 2023 09:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236185AbjJBJpM (ORCPT ); Mon, 2 Oct 2023 05:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236168AbjJBJpJ (ORCPT ); Mon, 2 Oct 2023 05:45:09 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82084BD for ; Mon, 2 Oct 2023 02:45:06 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 58CD2240012; Mon, 2 Oct 2023 09:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696239905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRukAf2u3WRWfmx+HCNdHblYYcJv+Zb9WqDcKGDdaw4=; b=PvJ/8QH0yMf/nAAi/XQOuBdImhyM8dVHnNnXFqU/UP5EOA9fWJLKNXiQpTxQ+MchTq3Nkc Fe7m9lruD32WCFl8t6ooHSDChiU5QrcLP+R5Py6hBvlYz96ImWssErOzw3Di7bogHvdM+h 73bjsOoxGOgrs6sPs1y+pXaEsHSdAu9K359Wquy9D2fDUKinDi6RSziy+oBI5FOI8KRTDL R7C9jumlUnHGZp50TnXfQfi42KCYCaOMsUvl4XPVEJR7iGLBwrTtmA76SFCE5X5ePTw9I8 IZtGUF1y1alpQePBAz2Q5m4wr1x3JntnqKEHI/LyyN441us2ZYrxwIYSdzJmpA== Date: Mon, 2 Oct 2023 11:44:50 +0200 From: Miquel Raynal To: Martin Kurbanov Cc: Richard Weinberger , Vignesh Raghavendra , Mario Kicherer , Chuanhong Guo , Dhruva Gole , , , Subject: Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G Message-ID: <20231002114450.4ce69141@xps-13> In-Reply-To: <20230929144934.192649-1-mmkurbanov@salutedevices.com> References: <20230929144934.192649-1-mmkurbanov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, mmkurbanov@salutedevices.com wrote on Fri, 29 Sep 2023 17:49:34 +0300: > Add support for FORESEE F35SQA002G SPI NAND. > Datasheet: > https://www.longsys.com/uploads/LM-00006FORESEEF35SQA002GDatasheet_1650= 183701.pdf >=20 > Signed-off-by: Martin Kurbanov > --- > drivers/mtd/nand/spi/Makefile | 2 +- > drivers/mtd/nand/spi/core.c | 1 + > drivers/mtd/nand/spi/foresee.c | 101 +++++++++++++++++++++++++++++++++ > include/linux/mtd/spinand.h | 1 + > 4 files changed, 104 insertions(+), 1 deletion(-) > create mode 100644 drivers/mtd/nand/spi/foresee.c >=20 > diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile > index cd8b66bf7740..19cc77288ebb 100644 > --- a/drivers/mtd/nand/spi/Makefile > +++ b/drivers/mtd/nand/spi/Makefile > @@ -1,4 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0 > -spinand-objs :=3D core.o alliancememory.o ato.o esmt.o gigadevice.o macr= onix.o > +spinand-objs :=3D core.o alliancememory.o ato.o esmt.o foresee.o gigadev= ice.o macronix.o > spinand-objs +=3D micron.o paragon.o toshiba.o winbond.o xtx.o > obj-$(CONFIG_MTD_SPI_NAND) +=3D spinand.o > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 393ff37f0d23..849ccfedbc72 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -940,6 +940,7 @@ static const struct spinand_manufacturer *spinand_man= ufacturers[] =3D { > &alliancememory_spinand_manufacturer, > &ato_spinand_manufacturer, > &esmt_c8_spinand_manufacturer, > + &foresee_spinand_manufacturer, > &gigadevice_spinand_manufacturer, > ¯onix_spinand_manufacturer, > µn_spinand_manufacturer, > diff --git a/drivers/mtd/nand/spi/foresee.c b/drivers/mtd/nand/spi/forese= e.c > new file mode 100644 > index 000000000000..55d4ff1f091a > --- /dev/null > +++ b/drivers/mtd/nand/spi/foresee.c > @@ -0,0 +1,101 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2023, SberDevices. All Rights Reserved. > + * > + * Author: Martin Kurbanov > + */ > + > +#include > +#include > +#include > + > +#define SPINAND_MFR_FORESEE 0xCD > + > +static SPINAND_OP_VARIANTS(read_cache_variants, > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); > + > +static SPINAND_OP_VARIANTS(write_cache_variants, > + SPINAND_PROG_LOAD_X4(true, 0, NULL, 0), > + SPINAND_PROG_LOAD(true, 0, NULL, 0)); > + > +static SPINAND_OP_VARIANTS(update_cache_variants, > + SPINAND_PROG_LOAD_X4(false, 0, NULL, 0), > + SPINAND_PROG_LOAD(false, 0, NULL, 0)); > + > +static int f35sqa002g_ooblayout_ecc(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + return -ERANGE; > +} > + > +static int f35sqa002g_ooblayout_free(struct mtd_info *mtd, int section, > + struct mtd_oob_region *region) > +{ > + /* XXX: It is not possible to partially write to this OOB area, as both > + * the main and OOB areas are protected by ECC. The user needs to > + * program both the main area and OOB area at one programming time, > + * so that the ECC parity code can be calculated properly. > + */ Is this comment really needed? I believe it could be dropped, unless you are really experiencing strange subpage write attempts? > + > + if (section) > + return -ERANGE; > + > + /* Reserve 2 bytes for the BBM. */ > + region->offset =3D 2; > + region->length =3D 62; > + > + return 0; > +} > + > +static const struct mtd_ooblayout_ops f35sqa002g_ooblayout =3D { > + .ecc =3D f35sqa002g_ooblayout_ecc, > + .free =3D f35sqa002g_ooblayout_free, > +}; > + > +static int f35sqa002g_ecc_get_status(struct spinand_device *spinand, u8 = status) > +{ > + struct nand_device *nand =3D spinand_to_nand(spinand); > + > + switch (status & STATUS_ECC_MASK) { > + case STATUS_ECC_NO_BITFLIPS: > + return 0; > + > + case STATUS_ECC_HAS_BITFLIPS: > + return nanddev_get_ecc_conf(nand)->strength; > + > + default: > + break; > + } > + > + /* More than 1-bit error was detected in one or more sectors and > + * cannot be corrected. > + */ > + return -EBADMSG; > +} > + > +static const struct spinand_info foresee_spinand_table[] =3D { > + SPINAND_INFO("F35SQA002G", > + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x72, 0x72), > + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1), > + NAND_ECCREQ(1, 512), > + SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > + &write_cache_variants, > + &update_cache_variants), > + SPINAND_HAS_QE_BIT, > + SPINAND_ECCINFO(&f35sqa002g_ooblayout, > + f35sqa002g_ecc_get_status)), > +}; > + > +static const struct spinand_manufacturer_ops foresee_spinand_manuf_ops = =3D { > +}; > + > +const struct spinand_manufacturer foresee_spinand_manufacturer =3D { > + .id =3D SPINAND_MFR_FORESEE, > + .name =3D "FORESEE", > + .chips =3D foresee_spinand_table, > + .nchips =3D ARRAY_SIZE(foresee_spinand_table), > + .ops =3D &foresee_spinand_manuf_ops, > +}; > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 3e285c09d16d..badb4c1ac079 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -263,6 +263,7 @@ struct spinand_manufacturer { > extern const struct spinand_manufacturer alliancememory_spinand_manufact= urer; > extern const struct spinand_manufacturer ato_spinand_manufacturer; > extern const struct spinand_manufacturer esmt_c8_spinand_manufacturer; > +extern const struct spinand_manufacturer foresee_spinand_manufacturer; > extern const struct spinand_manufacturer gigadevice_spinand_manufacturer; > extern const struct spinand_manufacturer macronix_spinand_manufacturer; > extern const struct spinand_manufacturer micron_spinand_manufacturer; Otherwise looks good. Thanks, Miqu=C3=A8l