From: Jakub Kicinski <kuba@kernel.org>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"davidhwei@meta.com" <davidhwei@meta.com>
Subject: Re: Sockmap's parser/verdict programs and epoll notifications
Date: Tue, 3 Oct 2023 05:41:56 -0700 [thread overview]
Message-ID: <20231003054156.52816535@kernel.org> (raw)
In-Reply-To: <651ba39d55792_53e4920861@john.notmuch>
On Mon, 02 Oct 2023 22:16:13 -0700 John Fastabend wrote:
> > This with the other piece we want from our side to allow running
> > verdict and sk_msg programs on sockets without having them in a
> > sockmap/sockhash it would seem like a better system to me. The
> > idea to drop the sockmap/sockhash is because we never remove progs
> > once they are added and we add them from sockops side. The filter
> > to socketes is almost always the port + metadata related to the
> > process or environment. This simplifies having to manage the
> > sockmap/sockhash and guess what size it should be. Sometimes we
> > overrun these maps and have to kill connections until we can
> > get more space.
That's a step in the right direction for sure, but I still think that
Google's auto-lowat is the best approach. We just need a hook that
looks at incoming data and sets rcvlowat appropriately. That's it.
TCP looks at rcvlowat in a number of places to make protocol decisions,
not just the wake-up. Plus Google will no longer have to carry their
OOT patch..
next prev parent reply other threads:[~2023-10-03 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 18:30 Sockmap's parser/verdict programs and epoll notifications Andrii Nakryiko
2023-07-17 4:37 ` John Fastabend
2023-09-08 22:46 ` Andrii Nakryiko
2023-09-11 14:43 ` John Fastabend
2023-09-11 18:01 ` Andrii Nakryiko
2023-10-03 5:04 ` John Fastabend
2023-10-03 5:16 ` John Fastabend
2023-10-03 12:41 ` Jakub Kicinski [this message]
2023-10-03 22:22 ` Andrii Nakryiko
2023-10-04 5:40 ` John Fastabend
2023-10-03 22:18 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003054156.52816535@kernel.org \
--to=kuba@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davidhwei@meta.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.