From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F1ABE75435 for ; Tue, 3 Oct 2023 09:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjJCJDF (ORCPT ); Tue, 3 Oct 2023 05:03:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239299AbjJCJDE (ORCPT ); Tue, 3 Oct 2023 05:03:04 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ADA1AB; Tue, 3 Oct 2023 02:03:01 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id B7A974000B; Tue, 3 Oct 2023 09:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696323780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10eDGalXqUFx1plS+nqHC9qTy/c98P26lcDQXh/vEcM=; b=Osw/i3JU9VGknE2CuivGOzHuNithMhN/CSNQublSeSj1D6G/boY+iGmuvLRD+bUxxzAJAF bp7xDpHnwu1ZIFNNo14sY9OBnF6prOXHq5IXiAmJId1HTrEcLJ0ISOVtMBzoXJhlj+OOo8 EYeS7GgXHazgWn6d6JkywLJHCQHTs2rwNLfow5JtHsTRLvPXb1tT2azbYgDxGKrE2m9D+5 bPopaLx6QkU7YjxAOZhQ9ssL8BrFXDT9Tm5LXiVgidWI4+SqVDsR8ZjffEQWGuucBPncm+ vXjwSUAsHdlmYsi3p0SZjyMJxFBosTori59OfuUiWVKVZ6mKy/HCuQC/45miag== Date: Tue, 3 Oct 2023 11:02:56 +0200 From: Miquel Raynal To: Vinod Koul Cc: Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dmaengine: xilinx: xdma: Support cyclic transfers Message-ID: <20231003110256.44286fcd@xps-13> In-Reply-To: References: <20230922162056.594933-1-miquel.raynal@bootlin.com> <20230922162056.594933-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Hi Vinod, Thanks for the feedback. vkoul@kernel.org wrote on Thu, 28 Sep 2023 16:24:31 +0530: > On 22-09-23, 18:20, Miquel Raynal wrote: >=20 > > @@ -583,7 +690,36 @@ static int xdma_alloc_chan_resources(struct dma_ch= an *chan) > > static enum dma_status xdma_tx_status(struct dma_chan *chan, dma_cooki= e_t cookie, > > struct dma_tx_state *state) > > { > > - return dma_cookie_status(chan, cookie, state); > > + struct xdma_chan *xdma_chan =3D to_xdma_chan(chan); > > + struct xdma_desc *desc =3D NULL; > > + struct virt_dma_desc *vd; > > + enum dma_status ret; > > + unsigned long flags; > > + unsigned int period_idx; > > + u32 residue =3D 0; > > + > > + ret =3D dma_cookie_status(chan, cookie, state); > > + if (ret =3D=3D DMA_COMPLETE) > > + return ret; > > + > > + spin_lock_irqsave(&xdma_chan->vchan.lock, flags); > > + > > + vd =3D vchan_find_desc(&xdma_chan->vchan, cookie); > > + if (vd) > > + desc =3D to_xdma_desc(vd); =20 >=20 > vd is not used in below check, so should be done after below checks, why > do this for cyclic case? I'm not sure I get this comment. vd is my way to get the descriptor, and I need the descriptor to know whether we are in a cyclic transfer or not. If the transfer is not cyclic, I just return the value from dma_cookie_status() like before, otherwise I update the residue based on the content of desc. Maybe I don't understand what you mean, would you mind explaining it again? > Otherwise series lgtm, just fix the error reported by test bot I will. >=20 > > + if (!desc || !desc->cyclic) { > > + spin_unlock_irqrestore(&xdma_chan->vchan.lock, flags); > > + return ret; > > + } =20 Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF628E75433 for ; Tue, 3 Oct 2023 09:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TST1CVq04pWjZT1EhgDON/EMJGtfXAIwmZg3Xk/fz1E=; b=Lo3Xbh51Z+1x/g 2r4AdQeRbCBC0mWXhpYArr+xycodIYpo4kLM3f0lFdO1LUJ/NkBfpMBbd6c0aFDHlzCAEfcdKZ/M7 6xGXG0eXPg+i8i3pi2QS3x/Sdbp1ei5AYEOeHj4Wt0PYjQzp4jf7GUp22SZnAmuhQy02nkZjb0fBt qCfKwagD/4DUmbVKIuaB2UrfcePJeWXccL9ZXCCXskg8dFNNMxvStNNVc8o/z8G9gya2SDIhDmZJj 6VYKXr4bf8mGgfuDcszG6d8M42ypFsdy1x7m052qArHVhnfe4X34evq0OiME9lPPvQwDSVAwC35pW amcKF+I1mwTeXYhSW5CA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnbJ7-00EBtq-14; Tue, 03 Oct 2023 09:03:09 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnbJ4-00EBtB-2I for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 09:03:08 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id B7A974000B; Tue, 3 Oct 2023 09:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696323780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10eDGalXqUFx1plS+nqHC9qTy/c98P26lcDQXh/vEcM=; b=Osw/i3JU9VGknE2CuivGOzHuNithMhN/CSNQublSeSj1D6G/boY+iGmuvLRD+bUxxzAJAF bp7xDpHnwu1ZIFNNo14sY9OBnF6prOXHq5IXiAmJId1HTrEcLJ0ISOVtMBzoXJhlj+OOo8 EYeS7GgXHazgWn6d6JkywLJHCQHTs2rwNLfow5JtHsTRLvPXb1tT2azbYgDxGKrE2m9D+5 bPopaLx6QkU7YjxAOZhQ9ssL8BrFXDT9Tm5LXiVgidWI4+SqVDsR8ZjffEQWGuucBPncm+ vXjwSUAsHdlmYsi3p0SZjyMJxFBosTori59OfuUiWVKVZ6mKy/HCuQC/45miag== Date: Tue, 3 Oct 2023 11:02:56 +0200 From: Miquel Raynal To: Vinod Koul Cc: Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dmaengine: xilinx: xdma: Support cyclic transfers Message-ID: <20231003110256.44286fcd@xps-13> In-Reply-To: References: <20230922162056.594933-1-miquel.raynal@bootlin.com> <20230922162056.594933-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_020306_888756_7E7433F2 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVmlub2QsCgpUaGFua3MgZm9yIHRoZSBmZWVkYmFjay4KCnZrb3VsQGtlcm5lbC5vcmcgd3Jv dGUgb24gVGh1LCAyOCBTZXAgMjAyMyAxNjoyNDozMSArMDUzMDoKCj4gT24gMjItMDktMjMsIDE4 OjIwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+IAo+ID4gQEAgLTU4Myw3ICs2OTAsMzYgQEAgc3Rh dGljIGludCB4ZG1hX2FsbG9jX2NoYW5fcmVzb3VyY2VzKHN0cnVjdCBkbWFfY2hhbiAqY2hhbikK PiA+ICBzdGF0aWMgZW51bSBkbWFfc3RhdHVzIHhkbWFfdHhfc3RhdHVzKHN0cnVjdCBkbWFfY2hh biAqY2hhbiwgZG1hX2Nvb2tpZV90IGNvb2tpZSwKPiA+ICAJCQkJICAgICAgc3RydWN0IGRtYV90 eF9zdGF0ZSAqc3RhdGUpCj4gPiAgewo+ID4gLQlyZXR1cm4gZG1hX2Nvb2tpZV9zdGF0dXMoY2hh biwgY29va2llLCBzdGF0ZSk7Cj4gPiArCXN0cnVjdCB4ZG1hX2NoYW4gKnhkbWFfY2hhbiA9IHRv X3hkbWFfY2hhbihjaGFuKTsKPiA+ICsJc3RydWN0IHhkbWFfZGVzYyAqZGVzYyA9IE5VTEw7Cj4g PiArCXN0cnVjdCB2aXJ0X2RtYV9kZXNjICp2ZDsKPiA+ICsJZW51bSBkbWFfc3RhdHVzIHJldDsK PiA+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ICsJdW5zaWduZWQgaW50IHBlcmlvZF9pZHg7 Cj4gPiArCXUzMiByZXNpZHVlID0gMDsKPiA+ICsKPiA+ICsJcmV0ID0gZG1hX2Nvb2tpZV9zdGF0 dXMoY2hhbiwgY29va2llLCBzdGF0ZSk7Cj4gPiArCWlmIChyZXQgPT0gRE1BX0NPTVBMRVRFKQo+ ID4gKwkJcmV0dXJuIHJldDsKPiA+ICsKPiA+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJnhkbWFfY2hh bi0+dmNoYW4ubG9jaywgZmxhZ3MpOwo+ID4gKwo+ID4gKwl2ZCA9IHZjaGFuX2ZpbmRfZGVzYygm eGRtYV9jaGFuLT52Y2hhbiwgY29va2llKTsKPiA+ICsJaWYgKHZkKQo+ID4gKwkJZGVzYyA9IHRv X3hkbWFfZGVzYyh2ZCk7ICAKPiAKPiB2ZCBpcyBub3QgdXNlZCBpbiBiZWxvdyBjaGVjaywgc28g c2hvdWxkIGJlIGRvbmUgYWZ0ZXIgYmVsb3cgY2hlY2tzLCB3aHkKPiBkbyB0aGlzIGZvciBjeWNs aWMgY2FzZT8KCkknbSBub3Qgc3VyZSBJIGdldCB0aGlzIGNvbW1lbnQuIHZkIGlzIG15IHdheSB0 byBnZXQgdGhlIGRlc2NyaXB0b3IsCmFuZCBJIG5lZWQgdGhlIGRlc2NyaXB0b3IgdG8ga25vdyB3 aGV0aGVyIHdlIGFyZSBpbiBhIGN5Y2xpYyB0cmFuc2ZlcgpvciBub3QuIElmIHRoZSB0cmFuc2Zl ciBpcyBub3QgY3ljbGljLCBJIGp1c3QgcmV0dXJuIHRoZSB2YWx1ZSBmcm9tCmRtYV9jb29raWVf c3RhdHVzKCkgbGlrZSBiZWZvcmUsIG90aGVyd2lzZSBJIHVwZGF0ZSB0aGUgcmVzaWR1ZSBiYXNl ZApvbiB0aGUgY29udGVudCBvZiBkZXNjLgoKTWF5YmUgSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQg eW91IG1lYW4sIHdvdWxkIHlvdSBtaW5kIGV4cGxhaW5pbmcgaXQKYWdhaW4/Cgo+IE90aGVyd2lz ZSBzZXJpZXMgbGd0bSwganVzdCBmaXggdGhlIGVycm9yIHJlcG9ydGVkIGJ5IHRlc3QgYm90CgpJ IHdpbGwuCgo+IAo+ID4gKwlpZiAoIWRlc2MgfHwgIWRlc2MtPmN5Y2xpYykgewo+ID4gKwkJc3Bp bl91bmxvY2tfaXJxcmVzdG9yZSgmeGRtYV9jaGFuLT52Y2hhbi5sb2NrLCBmbGFncyk7Cj4gPiAr CQlyZXR1cm4gcmV0Owo+ID4gKwl9ICAKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK