From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com,
chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de,
netdev@vger.kernel.org
Subject: Re: [PATCH v8 3/3] NFSD: add rpc_status netlink support
Date: Tue, 3 Oct 2023 11:03:58 -0700 [thread overview]
Message-ID: <20231003110358.4a08b826@kernel.org> (raw)
In-Reply-To: <ac18892ea3f718c63f0a12e39aeaac812c081515.1694436263.git.lorenzo@kernel.org>
On Mon, 11 Sep 2023 14:49:46 +0200 Lorenzo Bianconi wrote:
> + hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,
> + &nfsd_server_nl_family, NLM_F_MULTI,
> + NFSD_CMD_RPC_STATUS_GET);
> + if (!hdr)
> + return -ENOBUFS;
Why NLM_F_MULTI? AFAIU that means "I'm splitting one object over
multiple messages". 99% of the time the right thing to do is change
what we consider to be "an object" rather than do F_MULTI. In theory
user space should re-constitute all the NLM_F_MULTI messages into as
single object, which none of YNL does today :(
next prev parent reply other threads:[~2023-10-03 18:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 12:49 [PATCH v8 0/3] add rpc_status netlink support for NFSD Lorenzo Bianconi
2023-09-11 12:49 ` [PATCH v8 1/3] Documentation: netlink: add a YAML spec for nfsd_server Lorenzo Bianconi
2023-09-11 17:20 ` Jeff Layton
2023-09-11 18:10 ` Chuck Lever
2023-09-14 10:46 ` Lorenzo Bianconi
2023-10-03 17:55 ` Jakub Kicinski
2023-10-03 18:40 ` Chuck Lever III
2023-10-03 19:02 ` Jakub Kicinski
2023-10-03 23:00 ` Chuck Lever III
2023-10-04 0:24 ` Jakub Kicinski
2023-09-11 12:49 ` [PATCH v8 2/3] NFSD: introduce netlink rpc_status stubs Lorenzo Bianconi
2023-09-11 19:35 ` Jeff Layton
2023-09-11 19:55 ` Chuck Lever
2023-09-14 11:20 ` Lorenzo Bianconi
2023-09-12 15:07 ` Simon Horman
2023-09-14 11:25 ` Lorenzo Bianconi
2023-09-11 12:49 ` [PATCH v8 3/3] NFSD: add rpc_status netlink support Lorenzo Bianconi
2023-09-11 19:43 ` Jeff Layton
2023-09-12 15:13 ` Simon Horman
2023-09-14 11:41 ` Lorenzo Bianconi
2023-10-03 18:03 ` Jakub Kicinski [this message]
2023-10-04 10:14 ` Lorenzo Bianconi
2023-10-04 13:27 ` Chuck Lever III
2023-10-04 14:04 ` Lorenzo Bianconi
2023-12-11 18:56 ` Jeff Layton
2023-12-12 12:07 ` Jeff Layton
2023-09-15 19:24 ` [PATCH v8 0/3] add rpc_status netlink support for NFSD Chuck Lever
2023-09-15 21:30 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003110358.4a08b826@kernel.org \
--to=kuba@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.