From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C97E7543C for ; Tue, 3 Oct 2023 09:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/MniQBq8L2rl/Lx87raHol/4PBiEgnPvSZujHPPgmvQ=; b=v6ePt4n/eqJwlq NL2en+dvU+ru5eCBTYtm5OYYyELuqS2nQWZwpuoLcm8jhZdi2ip2rC3TCQwur8jFqJpsUOn+BoexK FlahZQuwBDpwlFd7uAVC53U0Ad46jNsOyfdDVpfV6Qel0iobqivGoxfmvdFhAXOZueHJxDxOUEfys BRW3AWl+72vDr8R04bgx9HcR1XIlQM+QVQD85aF6cXsQXdo+suK6cXQF/4Ns+6deylRySBUx2RU++ evdT6/JyaYO9XgIeJlRrgQAyreuvo/PH3gBFZXFD+KgvabJ70Mkn+Ahd7tqJTYCMw8xdPy51003fb gl+AwK1VA6p/mpOigXKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnbhe-00EElk-31; Tue, 03 Oct 2023 09:28:30 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnbhb-00EEkj-18 for linux-mtd@lists.infradead.org; Tue, 03 Oct 2023 09:28:29 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 19075240011; Tue, 3 Oct 2023 09:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696325302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LUpeZWYWn2dpMeICgIzJ1OnKQMz83J2Ptk+IlDZ7bZ0=; b=CcX5WgNZ/g86NLb2gp6kIt3CMp3RGip5kj1CmUPLesutlePOS5m9KX5nrR6vdLSVbXvbWV XyefnWVwl/wUYUgeivRrawjEBnO76yYGaudgjSuXDS6VG4lZ/l54pHuANstHsdLCEaO3e1 Okz5E+nHaO7Ga2i/gfRJ+6Tj+OAIZT7031iRAi0yBzjSbNFpisS+IcZmyxEPwLmFKAsXho k0zr0MI59D2x0Q9GW3ERMMnITySpHjEKt9CtNumwuks94rfkRm7Pg05a9P1Gzw4o7Z3a/u dKE3+sT0X5PhkMSfwaG1/nHYEya+Axuu3KcGubHBe9dY/nIX2NSdb/2Oi3lETA== Date: Tue, 3 Oct 2023 11:28:19 +0200 From: Miquel Raynal To: William Zhang Cc: dregan@mail.com, bcm-kernel-feedback-list@broadcom.com, linux-mtd@lists.infradead.org, f.fainelli@gmail.com, rafal@milecki.pl, joel.peshkin@broadcom.com, computersforpeace@gmail.com, dan.beygelman@broadcom.com, frieder.schrempf@kontron.de, linux-kernel@vger.kernel.org, vigneshr@ti.com, richard@nod.at, bbrezillon@kernel.org, kdasu.kdev@gmail.com Subject: Re: [PATCH v2] mtd: rawnand: brcmnand: Initial exec_op implementation Message-ID: <20231003112819.53707d54@xps-13> In-Reply-To: <04350e70-6ef0-4998-664f-20b96b63b0f4@broadcom.com> References: <20230922162424.4a7b27ec@xps-13> <20231002143527.4ccf254a@xps-13> <04350e70-6ef0-4998-664f-20b96b63b0f4@broadcom.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_022827_822093_84A257C2 X-CRM114-Status: GOOD ( 43.93 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgV2lsbGlhbSwKCndpbGxpYW0uemhhbmdAYnJvYWRjb20uY29tIHdyb3RlIG9uIE1vbiwgMiBP Y3QgMjAyMyAxMjo1NzowMSAtMDcwMDoKCj4gSGkgTWlxdWVsLAo+IAo+IE9uIDEwLzAyLzIwMjMg MDU6MzUgQU0sIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiBIaSBEYXZpZCwKPiA+IAo+ID4gZHJl Z2FuQG1haWwuY29tIHdyb3RlIG9uIFNhdCwgMzAgU2VwIDIwMjMgMDM6NTc6MzUgKzAyMDA6Cj4g PiAgIAo+ID4+IEluaXRpYWwgZXhlY19vcCBpbXBsZW1lbnRhdGlvbiBmb3IgQnJvYWRjb20gU1RC LCBCcm9hZGJhbmQgYW5kIGlQcm9jIFNvQwo+ID4+IFRoaXMgYWRkcyBleGVjX29wIGFuZCByZW1v dmVzIHRoZSBsZWdhY3kgaW50ZXJmYWNlLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogRGF2aWQg UmVnYW4gPGRyZWdhbkBtYWlsLmNvbT4KPiA+PiBSZXZpZXdlZC1ieTogV2lsbGlhbSBaaGFuZyA8 d2lsbGlhbS56aGFuZ0Bicm9hZGNvbS5jb20+Cj4gPj4KPiA+PiAtLS0KPiA+PiAgCj4gPiAKPiA+ IC4uLgo+ID4gICAKPiA+PiArc3RhdGljIGludCBicmNtbmFuZF9wYXJzZXJfZXhlY19tYXRjaGVk X29wKHN0cnVjdCBuYW5kX2NoaXAgKmNoaXAsCj4gPj4gKwkJCQkJIGNvbnN0IHN0cnVjdCBuYW5k X3N1Ym9wICpzdWJvcCkKPiA+PiArewo+ID4+ICsJc3RydWN0IGJyY21uYW5kX2hvc3QgKmhvc3Qg PSBuYW5kX2dldF9jb250cm9sbGVyX2RhdGEoY2hpcCk7Cj4gPj4gKwlzdHJ1Y3QgYnJjbW5hbmRf Y29udHJvbGxlciAqY3RybCA9IGhvc3QtPmN0cmw7Cj4gPj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10 ZCA9IG5hbmRfdG9fbXRkKGNoaXApOwo+ID4+ICsJY29uc3Qgc3RydWN0IG5hbmRfb3BfaW5zdHIg Kmluc3RyID0gJnN1Ym9wLT5pbnN0cnNbMF07Cj4gPj4gKwl1bnNpZ25lZCBpbnQgaTsKPiA+PiAr CWludCByZXQgPSAwOwo+ID4+ICsKPiA+PiArCWZvciAoaSA9IDA7IGkgPCBzdWJvcC0+bmluc3Ry czsgaSsrKSB7Cj4gPj4gKwkJaW5zdHIgPSAmc3Vib3AtPmluc3Ryc1tpXTsKPiA+PiArCj4gPj4g KwkJaWYgKChpbnN0ci0+dHlwZSA9PSBOQU5EX09QX0NNRF9JTlNUUikgJiYKPiA+PiArCQkJKGlu c3RyLT5jdHguY21kLm9wY29kZSA9PSBOQU5EX0NNRF9TVEFUVVMpKQo+ID4+ICsJCQljdHJsLT5z dGF0dXNfY21kID0gMTsKPiA+PiArCQllbHNlIGlmIChjdHJsLT5zdGF0dXNfY21kICYmIChpbnN0 ci0+dHlwZSA9PSBOQU5EX09QX0RBVEFfSU5fSU5TVFIpKSB7Cj4gPj4gKwkJCS8qCj4gPj4gKwkJ CSAqIG5lZWQgdG8gZmFrZSB0aGUgbmFuZCBkZXZpY2Ugd3JpdGUgcHJvdGVjdCBiZWNhdXNlIG5h bmRfYmFzZSBkb2VzIGEKPiA+PiArCQkJICogbmFuZF9jaGVja193cCB3aGljaCBjYWxscyBuYW5k X3N0YXR1c19vcCBOQU5EX0NNRF9TVEFUVVMgd2hpY2ggY2hlY2tzCj4gPj4gKwkJCSAqIHRoYXQg dGhlIG5hbmQgaXMgbm90IHdyaXRlIHByb3RlY3RlZCBiZWZvcmUgYW4gb3BlcmF0aW9uIHN0YXJ0 cy4KPiA+PiArCQkJICogVGhlIHByb2JsZW0gd2l0aCB0aGlzIGlzIGl0J3MgZG9uZSBvdXRzaWRl IGV4ZWNfb3Agc28gdGhlIG5hbmQgaXMKPiA+PiArCQkJICogd3JpdGUgcHJvdGVjdGVkIGFuZCB0 aGlzIGNoZWNrIHdpbGwgZmFpbCB1bnRpbCB0aGUgd3JpdGUgb3IgZXJhc2UKPiA+PiArCQkJICog b3Igd3JpdGUgYmFjayBvcGVyYXRpb24gYWN0dWFsbHkgaGFwcGVucyB3aGVyZSB3ZSB0dXJuIG9m ZiB3cC4KPiA+PiArCQkJICovCj4gPj4gKwkJCXU4ICppbjsKPiA+PiArCj4gPj4gKwkJCWN0cmwt PnN0YXR1c19jbWQgPSAwOwo+ID4+ICsKPiA+PiArCQkJaW5zdHIgPSAmc3Vib3AtPmluc3Ryc1tp XTsKPiA+PiArCQkJaW4gPSBpbnN0ci0+Y3R4LmRhdGEuYnVmLmluOwo+ID4+ICsJCQlpblswXSA9 IGJyY21uYW5kX3N0YXR1cyhob3N0KSB8IE5BTkRfU1RBVFVTX1dQOyAvKiBoaWRlIFdQIHN0YXR1 cyAqLyAgCj4gPiAKPiA+IEkgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgeW91IGFyZSBmYWtpbmcgdGhl IFdQIGJpdC4gSWYgaXQncyBzZXQsCj4gPiBicmNtbmFuZF9zdGF0dXMoKSBzaG91bGQgcmV0dXJu IGl0IGFuZCB5b3Ugc2hvdWxkIG5vdCBjYXJlIGFib3V0IGl0LiBJZgo+ID4gaXQncyBub3QgaG93 ZXZlciwgY2FuIHlvdSBwbGVhc2UgZ2l2ZSBtZSB0aGUgcGF0aCB1c2VkIHdoZW4gd2UgaGF2ZQo+ ID4gdGhpcyBpc3N1ZT8gRWl0aGVyIHdlIG5lZWQgdG8gbW9kaWZ5IHRoZSBjb3JlIG9yIHdlIG5l ZWQgdG8gcHJvdmlkZQo+ID4gYWRkaXRpb25hbCBoZWxwZXJzIGluIHRoaXMgZHJpdmVyIHRvIGNp cmN1bXZlbnQgdGhlIGZhdWx0eSBwYXRoLiAgCj4gCj4gVGhlIHJlYXNvbiB3ZSBoYXZlIHRvIGhp ZGUgd3Agc3RhdHVzIGZvciBzdGF0dXMgY29tbWFuZCBpcyBiZWNhdXNlCj4gbmFuZF9iYXNlIGNh bGxzIG5hbmRfY2hlY2tfd3AgYXQgdGhlIHZlcnkgYmVnaW5uaW5nIG9mIHdyaXRlIGFuZCBlcmFz ZQo+IGZ1bmN0aW9uLiBUaGlzIGFwcGxpZXMgdG8gYm90aCBleGVjX29wIHBhdGggYW5kIGxlZ2Fj eSBwYXRoLiBXaXRoCj4gQnJvYWRjb20gbmFuZCBjb250cm9sbGVyIGFuZCBtb3N0IG9mIG91ciBi b2FyZCBkZXNpZ24gdXNpbmcgdGhlIFdQIHBpbgo+IGFuZCBoYXZlIGl0IGFzc2VydGVkIGJ5IGRl ZmF1bHQsIHRoZSBuYW5kX2NoZWNrX3dwIGZ1bmN0aW9uIHdpbGwgZmFpbAo+IGFuZCB3cml0ZS9l cmFzZSBhYm9ydHMuICBUaGlzIHdvcmthcm91bmQgaGFzIGJlZW4gdGhlcmUgYmVmb3JlIHRoaXMK PiBleGVjX29wIHBhdGNoLgo+IAo+IEkgYWdyZWUgaXQgaXMgdWdseSBhbmQgYmV0dGVyIHRvIGJl IGFkZHJlc3NlZCBpbiB0aGUgbmFuZCBiYXNlIGNvZGUuIEFuZAo+IEkgdW5kZXJzdGFuZCBCcm9h ZGNvbSdzIFdQIGFwcHJvYWNoIG1heSBzb3VuZCBhIGJpdCBvdmVyIGNhdXRpb3VzIGJ1dCB3ZQo+ IHdhbnQgdG8gbWFrZSBzdXJlIG5vIHNwdXJpb3VzIGVyYXNlL3dyaXRlIGNhbiBoYXBwZW4gdW5k ZXIgYW55Cj4gY2lyY3Vtc3RhbmNlIGV4Y2VwdCBzb2Z0d2FyZSBleHBsaWNpdGx5IHdhbnQgdG8g d3JpdGUgYW5kIGVyYXNlLiAgV1AgaXMKPiBzdGFuZGFyZCBuYW5kIGNoaXAgcGluIGFuZCBJIHRo aW5rIG1vc3QgdGhlIG5hbmQgY29udHJvbGxlciBoYXMgdGhhdAo+IHRoYXQgcGluIGluIHRoZSBk ZXNpZ24gdG9vIGJ1dCBpdCBpcyBwb3NzaWJsZSBpdCBpcyBub3QgdXNlZCBhbmQKPiBib290bG9h ZGVyIGNhbiBkZS1hc3NlcnQgdGhlIHBpbiBhbmQgaGF2ZSBhIGFsd2F5cy13cml0YWJsZSBuYW5k IGZsYXNoCj4gZm9yIGxpbnV4LiBTbyBtYXliZSB3ZSBjYW4gYWRkIG5hbmQgY29udHJvbGxlciBk dHMgb3B0aW9uICJuYW5kLXVzZS13cCIuCj4gSWYgdGhpcyBwcm9wZXJ0eSBleGlzdCBhbmQgc2V0 IHRvIDEsICB3cCBjb250cm9sIGlzIGluIHVzZSBhbmQgbmFuZAo+IGRyaXZlciBuZWVkIHRvIGNv bnRyb2wgdGhlIHBpbiBvbi9mZiBhcyBuZWVkZWQgd2hlbiBkb2luZyB3cml0ZSBhbmQKPiBlcmFz ZSBmdW5jdGlvbi4gQWxzbyBuYW5kIGJhc2UgY29kZSBzaG91bGQgbm90IGNhbGwgbmFuZF9jaGVj a193cCB3aGVuCj4gd3AgaXMgaW4gdXNlLiBUaGVuIHdlIGNhbiByZW1vdmUgdGhlIGZha2luZyBX UCBzdGF0dXMgd29ya2Fyb3VuZC4KPiAKPiA+ICAgCj4gPj4gKwkJfSBlbHNlIGlmIChpbnN0ci0+ dHlwZSA9PSBOQU5EX09QX1dBSVRSRFlfSU5TVFIpIHsKPiA+PiArCQkJcmV0ID0gYmNtbmFuZF9j dHJsX3BvbGxfc3RhdHVzKGhvc3QsIE5BTkRfQ1RSTF9SRFksIE5BTkRfQ1RSTF9SRFksIDApOwo+ ID4+ICsJCQlpZiAoY3RybC0+d3BfY21kKSB7Cj4gPj4gKwkJCQljdHJsLT53cF9jbWQgPSAwOwo+ ID4+ICsJCQkJYnJjbW5hbmRfd3AobXRkLCAxKTsgIAo+ID4gCj4gPiBUaGlzIGlkZWFsbHkgc2hv dWxkIGRpc2FwcGVhci4KPiA+ICAgCj4gTWF5YmUgd2UgY2FuIGhhdmUgdGhlIGRlc3RydWN0aXZl IG9wZXJhdGlvbiBwYXRjaCBmcm9tIEJvcnJpcy4KPiBDb250cm9sbGVyIGRyaXZlciBzdGlsbCBu ZWVkIHRvIGFzc2VydC9kZWFzc2VydCB0aGUgcGluIGlmIGl0IHVzZXMgbmFuZAo+IHdwIGZlYXR1 cmUgYnV0IGF0IGxlYXN0IGl0IGRvZXMgbm90IG5lZWQgdG8gZ3Vlc3MgdGhlIG9wIGNvZGUuCgpB aCwgeWVhaCwgSSBnZXQgaXQuCgpQbGVhc2UgYmUgbXkgZ3Vlc3QsIHlvdSBjYW4gcmV2aXZlIHRo aXMgcGF0Y2ggc2VyaWVzIChtaWdodCBuZWVkIGxpZ2h0CnR3ZWFraW5nLCBub3RoaW5nIGJpZykg YW5kIGFsc28gdGFrZSBpbnNwaXJhdGlvbiBmcm9tIGl0IGlmIG5lY2Vzc2FyeToKaHR0cHM6Ly9n aXRodWIuY29tL2JicmV6aWxsb24vbGludXgvY29tbWl0L2U2MTJlMWYyYzY5YTMzYWM1ZjJjOTFk MTM2NjlmMGYxNzJkNTg3MTcKaHR0cHM6Ly9naXRodWIuY29tL2JicmV6aWxsb24vbGludXgvY29t bWl0LzRlYzZmOGQ4ZDgzZjVhYWNhNWQxODc3ZjAyZDQ4ZGE5NmQ0MWZjYmEKaHR0cHM6Ly9naXRo dWIuY29tL2JicmV6aWxsb24vbGludXgvY29tbWl0LzExYjRhY2ZmZDc2MWM0OTI4NjUyZDcwMjhk MTlmY2Q2ZjQ1ZTQ2OTYKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxp bmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8530AE75438 for ; Tue, 3 Oct 2023 09:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239602AbjJCJ23 (ORCPT ); Tue, 3 Oct 2023 05:28:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231199AbjJCJ22 (ORCPT ); Tue, 3 Oct 2023 05:28:28 -0400 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3859890 for ; Tue, 3 Oct 2023 02:28:24 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 19075240011; Tue, 3 Oct 2023 09:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696325302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LUpeZWYWn2dpMeICgIzJ1OnKQMz83J2Ptk+IlDZ7bZ0=; b=CcX5WgNZ/g86NLb2gp6kIt3CMp3RGip5kj1CmUPLesutlePOS5m9KX5nrR6vdLSVbXvbWV XyefnWVwl/wUYUgeivRrawjEBnO76yYGaudgjSuXDS6VG4lZ/l54pHuANstHsdLCEaO3e1 Okz5E+nHaO7Ga2i/gfRJ+6Tj+OAIZT7031iRAi0yBzjSbNFpisS+IcZmyxEPwLmFKAsXho k0zr0MI59D2x0Q9GW3ERMMnITySpHjEKt9CtNumwuks94rfkRm7Pg05a9P1Gzw4o7Z3a/u dKE3+sT0X5PhkMSfwaG1/nHYEya+Axuu3KcGubHBe9dY/nIX2NSdb/2Oi3lETA== Date: Tue, 3 Oct 2023 11:28:19 +0200 From: Miquel Raynal To: William Zhang Cc: dregan@mail.com, bcm-kernel-feedback-list@broadcom.com, linux-mtd@lists.infradead.org, f.fainelli@gmail.com, rafal@milecki.pl, joel.peshkin@broadcom.com, computersforpeace@gmail.com, dan.beygelman@broadcom.com, frieder.schrempf@kontron.de, linux-kernel@vger.kernel.org, vigneshr@ti.com, richard@nod.at, bbrezillon@kernel.org, kdasu.kdev@gmail.com Subject: Re: [PATCH v2] mtd: rawnand: brcmnand: Initial exec_op implementation Message-ID: <20231003112819.53707d54@xps-13> In-Reply-To: <04350e70-6ef0-4998-664f-20b96b63b0f4@broadcom.com> References: <20230922162424.4a7b27ec@xps-13> <20231002143527.4ccf254a@xps-13> <04350e70-6ef0-4998-664f-20b96b63b0f4@broadcom.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi William, william.zhang@broadcom.com wrote on Mon, 2 Oct 2023 12:57:01 -0700: > Hi Miquel, >=20 > On 10/02/2023 05:35 AM, Miquel Raynal wrote: > > Hi David, > >=20 > > dregan@mail.com wrote on Sat, 30 Sep 2023 03:57:35 +0200: > > =20 > >> Initial exec_op implementation for Broadcom STB, Broadband and iProc S= oC > >> This adds exec_op and removes the legacy interface. > >> > >> Signed-off-by: David Regan > >> Reviewed-by: William Zhang > >> > >> --- > >> =20 > >=20 > > ... > > =20 > >> +static int brcmnand_parser_exec_matched_op(struct nand_chip *chip, > >> + const struct nand_subop *subop) > >> +{ > >> + struct brcmnand_host *host =3D nand_get_controller_data(chip); > >> + struct brcmnand_controller *ctrl =3D host->ctrl; > >> + struct mtd_info *mtd =3D nand_to_mtd(chip); > >> + const struct nand_op_instr *instr =3D &subop->instrs[0]; > >> + unsigned int i; > >> + int ret =3D 0; > >> + > >> + for (i =3D 0; i < subop->ninstrs; i++) { > >> + instr =3D &subop->instrs[i]; > >> + > >> + if ((instr->type =3D=3D NAND_OP_CMD_INSTR) && > >> + (instr->ctx.cmd.opcode =3D=3D NAND_CMD_STATUS)) > >> + ctrl->status_cmd =3D 1; > >> + else if (ctrl->status_cmd && (instr->type =3D=3D NAND_OP_DATA_IN_IN= STR)) { > >> + /* > >> + * need to fake the nand device write protect because nand_base do= es a > >> + * nand_check_wp which calls nand_status_op NAND_CMD_STATUS which = checks > >> + * that the nand is not write protected before an operation starts. > >> + * The problem with this is it's done outside exec_op so the nand = is > >> + * write protected and this check will fail until the write or era= se > >> + * or write back operation actually happens where we turn off wp. > >> + */ > >> + u8 *in; > >> + > >> + ctrl->status_cmd =3D 0; > >> + > >> + instr =3D &subop->instrs[i]; > >> + in =3D instr->ctx.data.buf.in; > >> + in[0] =3D brcmnand_status(host) | NAND_STATUS_WP; /* hide WP statu= s */ =20 > >=20 > > I don't understand why you are faking the WP bit. If it's set, > > brcmnand_status() should return it and you should not care about it. If > > it's not however, can you please give me the path used when we have > > this issue? Either we need to modify the core or we need to provide > > additional helpers in this driver to circumvent the faulty path. =20 >=20 > The reason we have to hide wp status for status command is because > nand_base calls nand_check_wp at the very beginning of write and erase > function. This applies to both exec_op path and legacy path. With > Broadcom nand controller and most of our board design using the WP pin > and have it asserted by default, the nand_check_wp function will fail > and write/erase aborts. This workaround has been there before this > exec_op patch. >=20 > I agree it is ugly and better to be addressed in the nand base code. And > I understand Broadcom's WP approach may sound a bit over cautious but we > want to make sure no spurious erase/write can happen under any > circumstance except software explicitly want to write and erase. WP is > standard nand chip pin and I think most the nand controller has that > that pin in the design too but it is possible it is not used and > bootloader can de-assert the pin and have a always-writable nand flash > for linux. So maybe we can add nand controller dts option "nand-use-wp". > If this property exist and set to 1, wp control is in use and nand > driver need to control the pin on/ff as needed when doing write and > erase function. Also nand base code should not call nand_check_wp when > wp is in use. Then we can remove the faking WP status workaround. >=20 > > =20 > >> + } else if (instr->type =3D=3D NAND_OP_WAITRDY_INSTR) { > >> + ret =3D bcmnand_ctrl_poll_status(host, NAND_CTRL_RDY, NAND_CTRL_RD= Y, 0); > >> + if (ctrl->wp_cmd) { > >> + ctrl->wp_cmd =3D 0; > >> + brcmnand_wp(mtd, 1); =20 > >=20 > > This ideally should disappear. > > =20 > Maybe we can have the destructive operation patch from Borris. > Controller driver still need to assert/deassert the pin if it uses nand > wp feature but at least it does not need to guess the op code. Ah, yeah, I get it. Please be my guest, you can revive this patch series (might need light tweaking, nothing big) and also take inspiration from it if necessary: https://github.com/bbrezillon/linux/commit/e612e1f2c69a33ac5f2c91d13669f0f1= 72d58717 https://github.com/bbrezillon/linux/commit/4ec6f8d8d83f5aaca5d1877f02d48da9= 6d41fcba https://github.com/bbrezillon/linux/commit/11b4acffd761c4928652d7028d19fcd6= f45e4696 Thanks, Miqu=C3=A8l