From: Trevor Woerner <twoerner@gmail.com>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: anthony.t.davies@gmail.com, yocto@lists.yoctoproject.org
Subject: Re: [yocto] [meta-rockchip] [PATCH] Allow KERNEL_IMAGETYPE override v3
Date: Tue, 3 Oct 2023 10:03:36 -0400 [thread overview]
Message-ID: <20231003140336.GA7989@localhost> (raw)
In-Reply-To: <847e16c0-a63a-fc56-9a1a-214e53b68b0b@theobroma-systems.com>
On Tue 2023-10-03 @ 12:17:13 PM, Quentin Schulz wrote:
> Hi Anthony,
>
> On 10/3/23 02:43, Anthony Davies via lists.yoctoproject.org wrote:
> > [You don't often get email from anthony.t.davies=gmail.com@lists.yoctoproject.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > From: Anthony Davies <anthony.t.davies@gmail.com>
> >
> > Updated inc files to allow overriding KERNEL_IMAGETYPE in local.conf
> >
> > Signed-off-by: Anthony Davies <anthony.t.davies@gmail.com>
>
> Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Unrelated to this patch set, KERNEL_IMAGETYPE actually defaults to zImage so
> we could just avoid doing it again in rk3066, rk3188, rk3328.
>
> Also, for newer versions of patch series, please use:
> git format-patch -v3
> or
> git send-email -v3
>
> and it should create a mail with:
> [PATCH v3] in there
> because with the current subject being
> Allow KERNEL_IMAGETYPE override v3
> this would be the commit title inside the git repo and this is the kind of
> information we don't necessarily need in the git repo :) (but thanks for
> thinknig about adding it, it makes it easier to follow which patch mail is
> the latest version :) ).
Would "git send-email -v3" also add the "meta-rockchip"?
I usually just do:
$ git format-patch --subject-prefix="meta-rockchip][PATCH v3" ...
$ git send-email <patch>
I'll fix the commit messages up so don't worry about sending a v4. Thanks for
your patches! It's nice to not be the only one thinking about this layer.
Best regards,
Trevor
next prev parent reply other threads:[~2023-10-03 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 0:43 [meta-rockchip] [PATCH] Allow KERNEL_IMAGETYPE override v3 anthony.t.davies
2023-10-03 10:17 ` [yocto] " Quentin Schulz
2023-10-03 14:03 ` Trevor Woerner [this message]
2023-10-03 14:11 ` Quentin Schulz
2023-11-16 23:56 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003140336.GA7989@localhost \
--to=twoerner@gmail.com \
--cc=anthony.t.davies@gmail.com \
--cc=quentin.schulz@theobroma-systems.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.