From: Ross Zwisler <zwisler@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Stevie Alvarez <stevie.6strings@gmail.com>
Subject: Re: [PATCH v2] libtraceeval: Fix comparing unsigned against zero
Date: Tue, 3 Oct 2023 09:19:14 -0600 [thread overview]
Message-ID: <20231003151914.GA1935474@google.com> (raw)
In-Reply-To: <20231003091032.06e697a3@gandalf.local.home>
On Tue, Oct 03, 2023 at 09:10:32AM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
>
> nr_key_types and nr_val_types are both size_t which is an unsized number.
> A compare against zero is always false:
>
> if (teval->nr_key_types < 0)
>
> Change them to ssize_t (signed type).
>
> Also change the few places the "size_t i" is used where it does:
>
> for (; i >= 0; i--)
>
> as that too needs to be signed to work.
>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Ross Zwisler <zwisler@google.com>
prev parent reply other threads:[~2023-10-03 15:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 13:10 [PATCH v2] libtraceeval: Fix comparing unsigned against zero Steven Rostedt
2023-10-03 15:19 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003151914.GA1935474@google.com \
--to=zwisler@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stevie.6strings@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.