From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F21B4E7B614 for ; Wed, 4 Oct 2023 13:16:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA12010E375; Wed, 4 Oct 2023 13:16:13 +0000 (UTC) Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEE2D10E348; Wed, 4 Oct 2023 08:53:28 +0000 (UTC) Date: Wed, 4 Oct 2023 10:53:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696409607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rgf8GRivj4qTsOt2d3XGukyfDCF2xbBG1R3w7WzCNvo=; b=hX/rO9iom5L8UkraYSKmVK/Rh2VGAwKpYbh6N8iWKusVg4rlobvQe1FgpsZtS0Qd0F6bWy EjihWD6jajPbtws1i55RhLLMh2SYTQxAM6NYtibIqrruG/z2LSkSDGJpJhYJFskpDIClIU Q1LTks99YbavJru9/G2Detk6ph7ghCt29+FoJBEeftQdVhS6fu77kYAmODhNFejF+7eM2g WBp26546c2t9HkuFz5y7ruJhx7l8bxCF/mcEUAVE4IIo8RXRkAYQ4Qnbh6ZXZ/5Thz2pRH lKsn1kE3AZ66IT++Al2wtMKaMuNMOtXC/mGyFsKYHKtz5e6Eo78lcsWaFPYzYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696409607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rgf8GRivj4qTsOt2d3XGukyfDCF2xbBG1R3w7WzCNvo=; b=VkA+R1ryLwSNaqdBtS0ALyRYsEc9TwdCz3bamM7HFUu0WvYO8CcdLI2rLyuRkeSGhnUbOA NI4/wWCe4ec/nQAg== From: Sebastian Andrzej Siewior To: Harry Wentland Subject: Re: [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin(). Message-ID: <20231004085325.PandDs8m@linutronix.de> References: <20230921141516.520471-1-bigeasy@linutronix.de> <20230921141516.520471-2-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Wed, 04 Oct 2023 13:16:11 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tianci Yin , Leo Li , "Pan, Xinhui" , Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, Peter Zijlstra , Aurabindo Pillai , dri-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , Thomas Gleixner , David Airlie , Christian =?utf-8?B?S8O2bmln?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On 2023-10-03 15:53:41 [-0400], Harry Wentland wrote: > On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote: > > This is a revert of the commit mentioned below while it is not wrong, as > > in the kernel will explode, having migrate_disable() here it is > > complete waste of resources. > > > > Additionally commit message is plain wrong the review tag does not make > > Not sure I follow what's unhelpful about the review tag with > 0c316556d1249 ("drm/amd/display: Disable migration to ensure consistency of per-CPU variable") I explained it below with two points what the reviewer should have noticed why reading the commit message even if he does not know what migrate_disable() itself does. > I do wish the original patch showed the splat it's attempting > to fix. It apparently made a difference for something, whether > inadvertently or not. I wish I knew what that "something" was. As far as I can tell the patch does make a difference. > Harry Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8185E8FDDB for ; Wed, 4 Oct 2023 08:53:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A0F810E348; Wed, 4 Oct 2023 08:53:31 +0000 (UTC) Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEE2D10E348; Wed, 4 Oct 2023 08:53:28 +0000 (UTC) Date: Wed, 4 Oct 2023 10:53:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696409607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rgf8GRivj4qTsOt2d3XGukyfDCF2xbBG1R3w7WzCNvo=; b=hX/rO9iom5L8UkraYSKmVK/Rh2VGAwKpYbh6N8iWKusVg4rlobvQe1FgpsZtS0Qd0F6bWy EjihWD6jajPbtws1i55RhLLMh2SYTQxAM6NYtibIqrruG/z2LSkSDGJpJhYJFskpDIClIU Q1LTks99YbavJru9/G2Detk6ph7ghCt29+FoJBEeftQdVhS6fu77kYAmODhNFejF+7eM2g WBp26546c2t9HkuFz5y7ruJhx7l8bxCF/mcEUAVE4IIo8RXRkAYQ4Qnbh6ZXZ/5Thz2pRH lKsn1kE3AZ66IT++Al2wtMKaMuNMOtXC/mGyFsKYHKtz5e6Eo78lcsWaFPYzYw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696409607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rgf8GRivj4qTsOt2d3XGukyfDCF2xbBG1R3w7WzCNvo=; b=VkA+R1ryLwSNaqdBtS0ALyRYsEc9TwdCz3bamM7HFUu0WvYO8CcdLI2rLyuRkeSGhnUbOA NI4/wWCe4ec/nQAg== From: Sebastian Andrzej Siewior To: Harry Wentland Subject: Re: [PATCH 1/5] drm/amd/display: Remove migrate_en/dis from dc_fpu_begin(). Message-ID: <20231004085325.PandDs8m@linutronix.de> References: <20230921141516.520471-1-bigeasy@linutronix.de> <20230921141516.520471-2-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tianci Yin , Leo Li , "Pan, Xinhui" , Rodrigo Siqueira , amd-gfx@lists.freedesktop.org, Peter Zijlstra , Aurabindo Pillai , dri-devel@lists.freedesktop.org, Alex Deucher , Thomas Gleixner , Christian =?utf-8?B?S8O2bmln?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2023-10-03 15:53:41 [-0400], Harry Wentland wrote: > On 2023-09-21 10:15, Sebastian Andrzej Siewior wrote: > > This is a revert of the commit mentioned below while it is not wrong, as > > in the kernel will explode, having migrate_disable() here it is > > complete waste of resources. > > > > Additionally commit message is plain wrong the review tag does not make > > Not sure I follow what's unhelpful about the review tag with > 0c316556d1249 ("drm/amd/display: Disable migration to ensure consistency of per-CPU variable") I explained it below with two points what the reviewer should have noticed why reading the commit message even if he does not know what migrate_disable() itself does. > I do wish the original patch showed the splat it's attempting > to fix. It apparently made a difference for something, whether > inadvertently or not. I wish I knew what that "something" was. As far as I can tell the patch does make a difference. > Harry Sebastian