From: Jakub Kicinski <kuba@kernel.org>
To: David Kahurani <k.kahurani@gmail.com>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
wei.liu@kernel.org, paul@xen.org
Subject: Re: [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1
Date: Wed, 4 Oct 2023 11:47:58 -0700 [thread overview]
Message-ID: <20231004114758.44944e5d@kernel.org> (raw)
In-Reply-To: <20230927082918.197030-1-k.kahurani@gmail.com>
On Wed, 27 Sep 2023 11:29:18 +0300 David Kahurani wrote:
> If XEN_NETBK_LEGACY_SLOTS_MAX and MAX_SKB_FRAGS have a difference of
> more than 1, with MAX_SKB_FRAGS being the lesser value, it opens up a
> path for null-dereference. It was also noted that some distributions
> were modifying upstream behaviour in that direction which necessitates
> this patch.
MAX_SKB_FRAGS can now be set via Kconfig, this allows us to create
larger super-packets. Can XEN_NETBK_LEGACY_SLOTS_MAX be made relative
to MAX_SKB_FRAGS, or does the number have to match between guest and
host? Option #2 would be to add a Kconfig dependency for the driver
to make sure high MAX_SKB_FRAGS is incompatible with it.
Breaking the build will make build bots very sad.
We'll also need a Fixes tag, I presume this is a fix?
--
pw-bot: cr
next prev parent reply other threads:[~2023-10-04 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 8:29 [PATCH] net/xen-netback: Break build if netback slots > max_skbs + 1 David Kahurani
2023-09-27 9:42 ` Paul Durrant
2023-10-04 18:47 ` Jakub Kicinski [this message]
2023-10-05 15:39 ` David Kahurani
2023-10-05 16:03 ` Jakub Kicinski
2023-10-05 16:24 ` David Kahurani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004114758.44944e5d@kernel.org \
--to=kuba@kernel.org \
--cc=k.kahurani@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.