All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: <trini@konsulko.com>, <vigneshr@ti.com>, <m-chawdhry@ti.com>,
	<sjg@chromium.org>, <jonas@kwiboo.se>, <srk@ti.com>, <afd@ti.com>,
	<bb@ti.com>, <praneeth@ti.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH 2/2] board: ti: am64x: Switch to standard boot flow
Date: Wed, 4 Oct 2023 08:59:00 -0500	[thread overview]
Message-ID: <20231004135900.hcsptl5ho6imm4nk@unblessed> (raw)
In-Reply-To: <20231004132324.44198-3-rogerq@kernel.org>

On 16:23-20231004, Roger Quadros wrote:
> Switch to using bootstd. Note with this change, we will stop using
> distro_bootcmd and instead depend entirely on bootflow method of
> starting the system up.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>


> ---
>  board/ti/am64x/am64x.env        | 1 +
>  configs/am64x_evm_a53_defconfig | 5 +++--
>  include/configs/am64x_evm.h     | 2 --
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/board/ti/am64x/am64x.env b/board/ti/am64x/am64x.env
> index 68e42222b7..efd736b99b 100644
> --- a/board/ti/am64x/am64x.env
> +++ b/board/ti/am64x/am64x.env
> @@ -15,6 +15,7 @@ console=ttyS2,115200n8
>  args_all=setenv optargs earlycon=ns16550a,mmio32,0x02800000 ${mtdparts}
>  run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr}
>  
> +boot_targets=mmc1 mmc0 usb pxe dhcp
>  boot=mmc
>  mmcdev=1
>  bootpart=1:2
> diff --git a/configs/am64x_evm_a53_defconfig b/configs/am64x_evm_a53_defconfig
> index 718ad176cb..43bfcf957a 100644
> --- a/configs/am64x_evm_a53_defconfig
> +++ b/configs/am64x_evm_a53_defconfig
> @@ -31,8 +31,9 @@ CONFIG_SPL_SPI=y
>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_SPL_LOAD_FIT=y
>  CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
> -CONFIG_DISTRO_DEFAULTS=y
> -CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
> +CONFIG_BOOTSTD_FULL=y
> +CONFIG_BOOTSTD_DEFAULTS=y
> +CONFIG_BOOTCOMMAND="run envboot; bootflow scan -lb"
>  CONFIG_BOARD_LATE_INIT=y
>  CONFIG_SPL_MAX_SIZE=0x180000
>  CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
> diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h
> index 062102a610..d3d9eac8b6 100644
> --- a/include/configs/am64x_evm.h
> +++ b/include/configs/am64x_evm.h
> @@ -10,8 +10,6 @@
>  #define __CONFIG_AM642_EVM_H
>  
>  #include <linux/sizes.h>
Do we really need this?
> -#include <config_distro_bootcmd.h>
> -#include <env/ti/mmc.h>
>  #include <asm/arch/am64_hardware.h>

OR this?

>  #include <env/ti/k3_dfu.h>
you dont need k3_dfu.h either. the env setup is already in
board/ti/am64x/am64x.env (k3_dfu.env)

and we dont seem to be using CFG_SYS_SDRAM_BASE1

might be that we could reduce it down to am62x_evm.h ?

>  
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

      reply	other threads:[~2023-10-04 13:59 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 13:23 [PATCH 0/2] board: ti: am6x: Switch to standard boot Roger Quadros
2023-10-04 13:23 ` [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets Roger Quadros
2023-10-04 13:48   ` Andrew Davis
2023-10-04 13:54     ` Nishanth Menon
2023-10-05 14:19       ` Andrew Davis
2023-10-05 16:36         ` Tom Rini
2023-10-05 17:10           ` Nishanth Menon
2023-10-05 17:16             ` Nishanth Menon
2023-10-05 17:22               ` Andrew Davis
2023-10-05 17:28                 ` Nishanth Menon
2023-10-05 17:22               ` Simon Glass
2023-10-06  9:54                 ` Roger Quadros
2023-11-06  5:53                 ` Manorit Chawdhry
2023-11-06 15:31                   ` Tom Rini
2023-11-06 17:27                     ` Andrew Davis
2023-11-06 17:47                       ` Simon Glass
2023-11-06 18:05                         ` Andrew Davis
2023-11-28  9:31                           ` Manorit Chawdhry
2023-11-30  2:16                             ` Simon Glass
2023-11-30  2:45                           ` Simon Glass
2023-12-31 12:48                             ` Simon Glass
2024-01-02 14:58                               ` Andrew Davis
2024-01-04  7:52                                 ` Manorit Chawdhry
2024-01-04 15:55                                   ` Andrew Davis
2024-01-04 22:23                                     ` Jon Humphreys
2024-01-05  7:46                                     ` Manorit Chawdhry
2023-10-04 13:59   ` Nishanth Menon
2023-10-04 13:23 ` [PATCH 2/2] board: ti: am64x: Switch to standard boot flow Roger Quadros
2023-10-04 13:59   ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231004135900.hcsptl5ho6imm4nk@unblessed \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=jonas@kwiboo.se \
    --cc=m-chawdhry@ti.com \
    --cc=praneeth@ti.com \
    --cc=rogerq@kernel.org \
    --cc=sjg@chromium.org \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.